You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by danny0405 <gi...@git.apache.org> on 2017/12/04 04:43:55 UTC

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

Github user danny0405 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2433#discussion_r154558915
  
    --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
    @@ -231,7 +183,15 @@
     
         @VisibleForTesting
         public static final List<ACL> ZK_ACLS = Arrays.asList(ZooDefs.Ids.CREATOR_ALL_ACL.get(0),
    -            new ACL(ZooDefs.Perms.READ | ZooDefs.Perms.CREATE, ZooDefs.Ids.ANYONE_ID_UNSAFE));
    +            new ACL(ZooDefs.Perms.READ ^ ZooDefs.Perms.CREATE, ZooDefs.Ids.ANYONE_ID_UNSAFE));
    --- End diff --
    
    yeah, you are right


---