[GitHub] [incubator-superset] khtruong commented on a change in pull request #7461: [WIP] Live query validation, where supported

[GitBox <gi...@apache.org>]

khtruong commented on a change in pull request #7461: [WIP] Live query validation, where supported
URL: https://github.com/apache/incubator-superset/pull/7461#discussion_r281280087
 
 

 ##########
 File path: superset/assets/src/SqlLab/actions/sqlLab.js
 ##########
 @@ -77,6 +81,26 @@ export function resetState() {
   return { type: RESET_STATE };
 }
 
+export function startQueryValidation(query) {
+  if (query == null) {
+    const msg = "programmer error: tried to validate a null query object";
+    console.error(msg);
 
 Review comment:
   I think we have lint rules against console statements. Maybe just throw new Error(...) instead?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org