You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/11/21 22:20:45 UTC
[kudu-CR] Change 100M-int cfile tests to use BIT SHUFFLE instead of GROUP VARINT
Hello Dan Burkert,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5168
to review the following change.
Change subject: Change 100M-int cfile tests to use BIT_SHUFFLE instead of GROUP_VARINT
......................................................................
Change 100M-int cfile tests to use BIT_SHUFFLE instead of GROUP_VARINT
We no longer use GROUP_VARINT for encoding user data, since it only
supports unsigned ints, and we don't expose unsigned int types to users
anymore. So, it makes more sense to use signed ints with BIT_SHUFFLE for
this test.
Change-Id: I4c2b7727e1147ac86db0ba2d97640220938149ea
---
M src/kudu/cfile/cfile-test.cc
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/5168/1
--
To view, visit http://gerrit.cloudera.org:8080/5168
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4c2b7727e1147ac86db0ba2d97640220938149ea
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
[kudu-CR] Change 100M-int cfile tests to use BIT SHUFFLE instead of GROUP VARINT
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: Change 100M-int cfile tests to use BIT_SHUFFLE instead of GROUP_VARINT
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5168
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c2b7727e1147ac86db0ba2d97640220938149ea
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] Change 100M-int cfile tests to use BIT SHUFFLE instead of GROUP VARINT
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: Change 100M-int cfile tests to use BIT_SHUFFLE instead of GROUP_VARINT
......................................................................
Change 100M-int cfile tests to use BIT_SHUFFLE instead of GROUP_VARINT
We no longer use GROUP_VARINT for encoding user data, since it only
supports unsigned ints, and we don't expose unsigned int types to users
anymore. So, it makes more sense to use signed ints with BIT_SHUFFLE for
this test.
Change-Id: I4c2b7727e1147ac86db0ba2d97640220938149ea
Reviewed-on: http://gerrit.cloudera.org:8080/5168
Reviewed-by: Dan Burkert <da...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/cfile/cfile-test.cc
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Dan Burkert: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5168
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4c2b7727e1147ac86db0ba2d97640220938149ea
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Change 100M-int cfile tests to use BIT SHUFFLE instead of GROUP VARINT
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: Change 100M-int cfile tests to use BIT_SHUFFLE instead of GROUP_VARINT
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5168
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c2b7727e1147ac86db0ba2d97640220938149ea
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] Change 100M-int cfile tests to use BIT SHUFFLE instead of GROUP VARINT
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Hello Dan Burkert, David Ribeiro Alves, Adar Dembo, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5168
to look at the new patch set (#5).
Change subject: Change 100M-int cfile tests to use BIT_SHUFFLE instead of GROUP_VARINT
......................................................................
Change 100M-int cfile tests to use BIT_SHUFFLE instead of GROUP_VARINT
We no longer use GROUP_VARINT for encoding user data, since it only
supports unsigned ints, and we don't expose unsigned int types to users
anymore. So, it makes more sense to use signed ints with BIT_SHUFFLE for
this test.
Change-Id: I4c2b7727e1147ac86db0ba2d97640220938149ea
---
M src/kudu/cfile/cfile-test.cc
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/5168/5
--
To view, visit http://gerrit.cloudera.org:8080/5168
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4c2b7727e1147ac86db0ba2d97640220938149ea
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins