You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@htrace.apache.org by "Colin P. McCabe" <cm...@apache.org> on 2015/09/19 03:05:26 UTC
[VOTE] HTrace 4.0.1 release RC0
I've posted the first release candidate here:
http://people.apache.org/~cmccabe/htrace/releases/4.0.1/rc0
The jars have been staged here:
https://repository.apache.org/content/repositories/orgapachehtrace-1019
As mentioned earlier, this is a cleanup release with just some build
fixes, log level changes, and cleanups.
The vote will run for 3 days.
cheers,
Colin
Release Notes - HTrace - Version 4.0.1
** Bug
* [HTRACE-253] - Tracer loadSamplers and loadSpanReceivers logs are too chatty
* [HTRACE-256] - Change the artifactId for htrace-core in branch 4.0
to be htrace-core4
* [HTRACE-238] - Change maven compiler source level to 1.7 to match targetJdk
* [HTRACE-245] - NOTICE.txt: change "developed by The Apache
Software...” to "developed at The Apache Software...”
* [HTRACE-246] - HTrace WebApp not properly defined and therefore not
packaged into .war
* [HTRACE-251] - Fix "mvn clean" target
* [HTRACE-255] - Failed finding GODEPs on mac os x
* [HTRACE-257] - htrace-htraced: add web symlink rather than
generating programmatically
** Task
* [HTRACE-254] - Minor compatible API cleanup: Take name on Tracer
construction, deprecate Span#getChild
Re: [VOTE] HTrace 4.0.1 release RC0
Posted by Stack <st...@duboce.net>.
Signature and md5 and rat check are all good. Built with all unit tests
passing. Started up htraced. All good.
I tested using the maven repository artifacts building an hbase that had
moved to 4.0.0 running on an hdfs that had not and it works.
The src tarball as is won't build. It fails because the tgz has
htrace-core4 module in it (and mvn repository also has htrace-core4) but
the top-level pom refers to htrace-core. Needs this change to build:
diff --git a/pom.xml b/pom.xml
index 0e0342f..42e19ca 100644
--- a/pom.xml
+++ b/pom.xml
@@ -29,7 +29,7 @@ language governing permissions and limitations under the
License. -->
<modules>
<module>htrace-c</module>
- <module>htrace-core</module>
+ <module>htrace-core4</module>
<module>htrace-webapp</module>
<module>htrace-zipkin</module>
<module>htrace-hbase</module>
This is not the end of the world I'd say. (HTRACE-259 has a fix.. there may
be a simpler fix than renaming the module, just altering the assembly
src.xml... We can fix in next release. Can include note on this change
needed to build from src in the release note).
I'm +1.
St.Ack
On Fri, Sep 18, 2015 at 6:05 PM, Colin P. McCabe <cm...@apache.org> wrote:
> I've posted the first release candidate here:
>
> http://people.apache.org/~cmccabe/htrace/releases/4.0.1/rc0
>
> The jars have been staged here:
>
> https://repository.apache.org/content/repositories/orgapachehtrace-1019
>
> As mentioned earlier, this is a cleanup release with just some build
> fixes, log level changes, and cleanups.
>
> The vote will run for 3 days.
>
> cheers,
> Colin
>
> Release Notes - HTrace - Version 4.0.1
>
> ** Bug
> * [HTRACE-253] - Tracer loadSamplers and loadSpanReceivers logs are too
> chatty
> * [HTRACE-256] - Change the artifactId for htrace-core in branch 4.0
> to be htrace-core4
> * [HTRACE-238] - Change maven compiler source level to 1.7 to match
> targetJdk
> * [HTRACE-245] - NOTICE.txt: change "developed by The Apache
> Software...” to "developed at The Apache Software...”
> * [HTRACE-246] - HTrace WebApp not properly defined and therefore not
> packaged into .war
> * [HTRACE-251] - Fix "mvn clean" target
> * [HTRACE-255] - Failed finding GODEPs on mac os x
> * [HTRACE-257] - htrace-htraced: add web symlink rather than
> generating programmatically
>
> ** Task
> * [HTRACE-254] - Minor compatible API cleanup: Take name on Tracer
> construction, deprecate Span#getChild
>
Re: [VOTE] HTrace 4.0.1 release RC0
Posted by Stack <st...@duboce.net>.
Need the patch on htrace-259.
St.Ack
On Sat, Sep 19, 2015 at 9:14 PM, Colin P. McCabe <cm...@apache.org> wrote:
> Good catch, Stack. Let me make an RC1 just to avoid any confusion.
>
> Colin
>
> On Sat, Sep 19, 2015 at 8:47 PM, Stack <st...@duboce.net> wrote:
> > Signature and md5 and rat check are all good. Built with all unit tests
> > passing. Started up htraced. All good.
> >
> > I tested using the maven repository artifacts building an hbase that had
> > moved to 4.0.0 running on an hdfs that had not and it works.
> >
> > The src tarball as is won't build. It fails because the tgz has
> > htrace-core4 module in it (and mvn repository also has htrace-core4) but
> > the top-level pom refers to htrace-core. Needs this change to build:
> >
> >
> > diff --git a/pom.xml b/pom.xml
> > index 0e0342f..42e19ca 100644
> > --- a/pom.xml
> > +++ b/pom.xml
> > @@ -29,7 +29,7 @@ language governing permissions and limitations under
> the
> > License. -->
> >
> > <modules>
> > <module>htrace-c</module>
> > - <module>htrace-core</module>
> > + <module>htrace-core4</module>
> > <module>htrace-webapp</module>
> > <module>htrace-zipkin</module>
> > <module>htrace-hbase</module>
> >
> >
> > This is not the end of the world I'd say. (HTRACE-259 has a fix.. there
> may
> > be a simpler fix than renaming the module, just altering the assembly
> > src.xml... We can fix in next release. Can include note on this change
> > needed to build from src in the release note).
> >
> > I'm +1.
> >
> > St.Ack
> >
> > On Fri, Sep 18, 2015 at 6:05 PM, Colin P. McCabe <cm...@apache.org>
> wrote:
> >
> >> I've posted the first release candidate here:
> >>
> >> http://people.apache.org/~cmccabe/htrace/releases/4.0.1/rc0
> >>
> >> The jars have been staged here:
> >>
> >> https://repository.apache.org/content/repositories/orgapachehtrace-1019
> >>
> >> As mentioned earlier, this is a cleanup release with just some build
> >> fixes, log level changes, and cleanups.
> >>
> >> The vote will run for 3 days.
> >>
> >> cheers,
> >> Colin
> >>
> >> Release Notes - HTrace - Version 4.0.1
> >>
> >> ** Bug
> >> * [HTRACE-253] - Tracer loadSamplers and loadSpanReceivers logs are too
> >> chatty
> >> * [HTRACE-256] - Change the artifactId for htrace-core in branch 4.0
> >> to be htrace-core4
> >> * [HTRACE-238] - Change maven compiler source level to 1.7 to match
> >> targetJdk
> >> * [HTRACE-245] - NOTICE.txt: change "developed by The Apache
> >> Software...” to "developed at The Apache Software...”
> >> * [HTRACE-246] - HTrace WebApp not properly defined and therefore not
> >> packaged into .war
> >> * [HTRACE-251] - Fix "mvn clean" target
> >> * [HTRACE-255] - Failed finding GODEPs on mac os x
> >> * [HTRACE-257] - htrace-htraced: add web symlink rather than
> >> generating programmatically
> >>
> >> ** Task
> >> * [HTRACE-254] - Minor compatible API cleanup: Take name on Tracer
> >> construction, deprecate Span#getChild
> >>
>
Re: [VOTE] HTrace 4.0.1 release RC0
Posted by "Colin P. McCabe" <cm...@apache.org>.
This vote is closed. I opened a new vote for RC1 which fixes the
HTRACE-259 issue Stack found.
thanks, all.
Colin
On Sat, Sep 19, 2015 at 9:22 PM, Stack <st...@duboce.net> wrote:
> Need the patch on htrace-259.
> St.Ack
>
> On Sat, Sep 19, 2015 at 9:14 PM, Colin P. McCabe <cm...@apache.org> wrote:
>
>> Good catch, Stack. Let me make an RC1 just to avoid any confusion.
>>
>> Colin
>>
>> On Sat, Sep 19, 2015 at 8:47 PM, Stack <st...@duboce.net> wrote:
>> > Signature and md5 and rat check are all good. Built with all unit tests
>> > passing. Started up htraced. All good.
>> >
>> > I tested using the maven repository artifacts building an hbase that had
>> > moved to 4.0.0 running on an hdfs that had not and it works.
>> >
>> > The src tarball as is won't build. It fails because the tgz has
>> > htrace-core4 module in it (and mvn repository also has htrace-core4) but
>> > the top-level pom refers to htrace-core. Needs this change to build:
>> >
>> >
>> > diff --git a/pom.xml b/pom.xml
>> > index 0e0342f..42e19ca 100644
>> > --- a/pom.xml
>> > +++ b/pom.xml
>> > @@ -29,7 +29,7 @@ language governing permissions and limitations under
>> the
>> > License. -->
>> >
>> > <modules>
>> > <module>htrace-c</module>
>> > - <module>htrace-core</module>
>> > + <module>htrace-core4</module>
>> > <module>htrace-webapp</module>
>> > <module>htrace-zipkin</module>
>> > <module>htrace-hbase</module>
>> >
>> >
>> > This is not the end of the world I'd say. (HTRACE-259 has a fix.. there
>> may
>> > be a simpler fix than renaming the module, just altering the assembly
>> > src.xml... We can fix in next release. Can include note on this change
>> > needed to build from src in the release note).
>> >
>> > I'm +1.
>> >
>> > St.Ack
>> >
>> > On Fri, Sep 18, 2015 at 6:05 PM, Colin P. McCabe <cm...@apache.org>
>> wrote:
>> >
>> >> I've posted the first release candidate here:
>> >>
>> >> http://people.apache.org/~cmccabe/htrace/releases/4.0.1/rc0
>> >>
>> >> The jars have been staged here:
>> >>
>> >> https://repository.apache.org/content/repositories/orgapachehtrace-1019
>> >>
>> >> As mentioned earlier, this is a cleanup release with just some build
>> >> fixes, log level changes, and cleanups.
>> >>
>> >> The vote will run for 3 days.
>> >>
>> >> cheers,
>> >> Colin
>> >>
>> >> Release Notes - HTrace - Version 4.0.1
>> >>
>> >> ** Bug
>> >> * [HTRACE-253] - Tracer loadSamplers and loadSpanReceivers logs are too
>> >> chatty
>> >> * [HTRACE-256] - Change the artifactId for htrace-core in branch 4.0
>> >> to be htrace-core4
>> >> * [HTRACE-238] - Change maven compiler source level to 1.7 to match
>> >> targetJdk
>> >> * [HTRACE-245] - NOTICE.txt: change "developed by The Apache
>> >> Software...” to "developed at The Apache Software...”
>> >> * [HTRACE-246] - HTrace WebApp not properly defined and therefore not
>> >> packaged into .war
>> >> * [HTRACE-251] - Fix "mvn clean" target
>> >> * [HTRACE-255] - Failed finding GODEPs on mac os x
>> >> * [HTRACE-257] - htrace-htraced: add web symlink rather than
>> >> generating programmatically
>> >>
>> >> ** Task
>> >> * [HTRACE-254] - Minor compatible API cleanup: Take name on Tracer
>> >> construction, deprecate Span#getChild
>> >>
>>
Re: [VOTE] HTrace 4.0.1 release RC0
Posted by "Colin P. McCabe" <cm...@apache.org>.
Good catch, Stack. Let me make an RC1 just to avoid any confusion.
Colin
On Sat, Sep 19, 2015 at 8:47 PM, Stack <st...@duboce.net> wrote:
> Signature and md5 and rat check are all good. Built with all unit tests
> passing. Started up htraced. All good.
>
> I tested using the maven repository artifacts building an hbase that had
> moved to 4.0.0 running on an hdfs that had not and it works.
>
> The src tarball as is won't build. It fails because the tgz has
> htrace-core4 module in it (and mvn repository also has htrace-core4) but
> the top-level pom refers to htrace-core. Needs this change to build:
>
>
> diff --git a/pom.xml b/pom.xml
> index 0e0342f..42e19ca 100644
> --- a/pom.xml
> +++ b/pom.xml
> @@ -29,7 +29,7 @@ language governing permissions and limitations under the
> License. -->
>
> <modules>
> <module>htrace-c</module>
> - <module>htrace-core</module>
> + <module>htrace-core4</module>
> <module>htrace-webapp</module>
> <module>htrace-zipkin</module>
> <module>htrace-hbase</module>
>
>
> This is not the end of the world I'd say. (HTRACE-259 has a fix.. there may
> be a simpler fix than renaming the module, just altering the assembly
> src.xml... We can fix in next release. Can include note on this change
> needed to build from src in the release note).
>
> I'm +1.
>
> St.Ack
>
> On Fri, Sep 18, 2015 at 6:05 PM, Colin P. McCabe <cm...@apache.org> wrote:
>
>> I've posted the first release candidate here:
>>
>> http://people.apache.org/~cmccabe/htrace/releases/4.0.1/rc0
>>
>> The jars have been staged here:
>>
>> https://repository.apache.org/content/repositories/orgapachehtrace-1019
>>
>> As mentioned earlier, this is a cleanup release with just some build
>> fixes, log level changes, and cleanups.
>>
>> The vote will run for 3 days.
>>
>> cheers,
>> Colin
>>
>> Release Notes - HTrace - Version 4.0.1
>>
>> ** Bug
>> * [HTRACE-253] - Tracer loadSamplers and loadSpanReceivers logs are too
>> chatty
>> * [HTRACE-256] - Change the artifactId for htrace-core in branch 4.0
>> to be htrace-core4
>> * [HTRACE-238] - Change maven compiler source level to 1.7 to match
>> targetJdk
>> * [HTRACE-245] - NOTICE.txt: change "developed by The Apache
>> Software...” to "developed at The Apache Software...”
>> * [HTRACE-246] - HTrace WebApp not properly defined and therefore not
>> packaged into .war
>> * [HTRACE-251] - Fix "mvn clean" target
>> * [HTRACE-255] - Failed finding GODEPs on mac os x
>> * [HTRACE-257] - htrace-htraced: add web symlink rather than
>> generating programmatically
>>
>> ** Task
>> * [HTRACE-254] - Minor compatible API cleanup: Take name on Tracer
>> construction, deprecate Span#getChild
>>