[GitHub] [accumulo] ctubbsii commented on a diff in pull request #2879: Add new params to import table

[GitBox <gi...@apache.org>]

ctubbsii commented on code in PR #2879:
URL: https://github.com/apache/accumulo/pull/2879#discussion_r964059342


##########
core/src/main/java/org/apache/accumulo/core/client/admin/TableOperations.java:
##########
@@ -192,11 +192,14 @@ default void importTable(String tableName, String importDir)
    *
    * @param tableName
    *          Name of a table to create and import into.
+   * @param ic
+   *          ImportConfiguration for the table being created. If no configuration is needed pass
+   *          {@link ImportConfiguration#empty}
    * @param importDirs
    *          A set of directories containing the files copied by distcp from exportTable
    * @since 2.1.0
    */
-  void importTable(String tableName, Set<String> importDirs)
+  void importTable(String tableName, Set<String> importDirs, ImportConfiguration ic)

Review Comment:
   Should the table name and import directories also be pushed into ImportConfiguration, so we're not splitting them up into an object with parameters, plus more parameters when the object is used?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org