You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/10/18 19:02:25 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #4689: binfmt/Makefile: remove the specified prefix from target variables
xiaoxiang781216 opened a new pull request #4689:
URL: https://github.com/apache/incubator-nuttx/pull/4689
## Summary
Unify the Makefile style
## Impact
Minor change
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #4689: binfmt/Makefile: remove the specified prefix from target variables
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on a change in pull request #4689:
URL: https://github.com/apache/incubator-nuttx/pull/4689#discussion_r731236149
##########
File path: binfmt/Makefile
##########
@@ -22,54 +22,54 @@ include $(TOPDIR)/Make.defs
# Basic BINFMT source files
-BINFMT_CSRCS = binfmt_globals.c binfmt_initialize.c binfmt_register.c binfmt_unregister.c
-BINFMT_CSRCS += binfmt_loadmodule.c binfmt_unloadmodule.c binfmt_execmodule.c
-BINFMT_CSRCS += binfmt_exec.c binfmt_copyargv.c binfmt_dumpmodule.c
+CSRCS = binfmt_globals.c binfmt_initialize.c binfmt_register.c binfmt_unregister.c
+CSRCS += binfmt_loadmodule.c binfmt_unloadmodule.c binfmt_execmodule.c
+CSRCS += binfmt_exec.c binfmt_copyargv.c binfmt_dumpmodule.c
ifeq ($(CONFIG_BINFMT_LOADABLE),y)
-BINFMT_CSRCS += binfmt_exit.c
+CSRCS += binfmt_exit.c
endif
ifeq ($(CONFIG_LIBC_EXECFUNCS),y)
-BINFMT_CSRCS += binfmt_execsymtab.c
+CSRCS += binfmt_execsymtab.c
endif
# Builtin application interfaces
ifeq ($(CONFIG_BUILTIN),y)
-BINFMT_CSRCS += builtin.c
+CSRCS += builtin.c
endif
# Add configured binary modules
include libnxflat/Make.defs
include libelf/Make.defs
-BINFMT_AOBJS = $(BINFMT_ASRCS:.S=$(OBJEXT))
-BINFMT_COBJS = $(BINFMT_CSRCS:.c=$(OBJEXT))
+AOBJS = $(BINFMT_ASRCS:.S=$(OBJEXT))
Review comment:
Any reason for skipping `BINFMT_ASRCS`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #4689: binfmt/Makefile: remove the specified prefix from target variables
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #4689:
URL: https://github.com/apache/incubator-nuttx/pull/4689#discussion_r731241486
##########
File path: binfmt/Makefile
##########
@@ -22,54 +22,54 @@ include $(TOPDIR)/Make.defs
# Basic BINFMT source files
-BINFMT_CSRCS = binfmt_globals.c binfmt_initialize.c binfmt_register.c binfmt_unregister.c
-BINFMT_CSRCS += binfmt_loadmodule.c binfmt_unloadmodule.c binfmt_execmodule.c
-BINFMT_CSRCS += binfmt_exec.c binfmt_copyargv.c binfmt_dumpmodule.c
+CSRCS = binfmt_globals.c binfmt_initialize.c binfmt_register.c binfmt_unregister.c
+CSRCS += binfmt_loadmodule.c binfmt_unloadmodule.c binfmt_execmodule.c
+CSRCS += binfmt_exec.c binfmt_copyargv.c binfmt_dumpmodule.c
ifeq ($(CONFIG_BINFMT_LOADABLE),y)
-BINFMT_CSRCS += binfmt_exit.c
+CSRCS += binfmt_exit.c
endif
ifeq ($(CONFIG_LIBC_EXECFUNCS),y)
-BINFMT_CSRCS += binfmt_execsymtab.c
+CSRCS += binfmt_execsymtab.c
endif
# Builtin application interfaces
ifeq ($(CONFIG_BUILTIN),y)
-BINFMT_CSRCS += builtin.c
+CSRCS += builtin.c
endif
# Add configured binary modules
include libnxflat/Make.defs
include libelf/Make.defs
-BINFMT_AOBJS = $(BINFMT_ASRCS:.S=$(OBJEXT))
-BINFMT_COBJS = $(BINFMT_CSRCS:.c=$(OBJEXT))
+AOBJS = $(BINFMT_ASRCS:.S=$(OBJEXT))
Review comment:
No, just forget it. It fix now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 merged pull request #4689: binfmt/Makefile: remove the specified prefix from target variables
Posted by GitBox <gi...@apache.org>.
Ouss4 merged pull request #4689:
URL: https://github.com/apache/incubator-nuttx/pull/4689
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org