You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2026/07/07 11:12:02 UTC

Re: [I] [Refactor] Centralize checked byte-size and offset accounting for variable-size string builders [datafusion]

alamb commented on issue #22688:
URL: https://github.com/apache/datafusion/issues/22688#issuecomment-4903129935

   As I mentioned in https://github.com/apache/datafusion/pull/23223#issuecomment-4903107653
   
   I think the offset overflow issue is a problem for Utf8 (StringArray). I am not aware of it being a problem for other string types -- LargeStringArray has 64 bit offsets and StringView has 32 bit offsets *per value*
   
   In other words, I think we should be careful of over engineering / adding lots of complexity to the code for cases that are never really seen


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org