[Impala-ASF-CR] IMPALA-5317: [DOCS] Doc for DATE TRUNC() function

["John Russell (Code Review)" <ge...@cloudera.org>]

John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8768 )

Change subject: IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function
......................................................................


Patch Set 4:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/8768/4/docs/topics/impala_datetime_functions.xml
File docs/topics/impala_datetime_functions.xml:

http://gerrit.cloudera.org:8080/#/c/8768/4/docs/topics/impala_datetime_functions.xml@403
PS4, Line 403: values
> TIMESTAMP value or values?
'values' is grammatically correct here.


http://gerrit.cloudera.org:8080/#/c/8768/4/docs/topics/impala_datetime_functions.xml@422
PS4, Line 422: TS
> caps on TS and small TS mentioned earlier??
Sure. I follow a consistent pattern of capitalization for discussions in a pure SQL context - identifiers are lowercase in a statement like 'CREATE TABLE foo', but if I'm referring to the identifier itself I'll capitalize it, as in 'the table named FOO'. But in the discussions of built-in functions I use lowercase more frequently, more of a C-like style.


http://gerrit.cloudera.org:8080/#/c/8768/4/docs/topics/impala_datetime_functions.xml@430
PS4, Line 430: one secon
> what do you think about "one second" vs "second"
Grammatically there would need to be one other word there, either "a second" or "one second". Let's leave it as-is.



-- 
To view, visit http://gerrit.cloudera.org:8080/8768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcf38903bb10db12cbb8d73a2dc875aef29cd359
Gerrit-Change-Number: 8768
Gerrit-PatchSet: 4
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: sandeep akinapelli <sa...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Jan 2018 20:04:13 +0000
Gerrit-HasComments: Yes