You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Olga Natkovich (JIRA)" <ji...@apache.org> on 2009/08/04 17:32:14 UTC
[jira] Created: (PIG-905) TOKENIZE throws exception on null data
TOKENIZE throws exception on null data
--------------------------------------
Key: PIG-905
URL: https://issues.apache.org/jira/browse/PIG-905
Project: Pig
Issue Type: Bug
Reporter: Olga Natkovich
it should just return null
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-905) TOKENIZE throws exception on null data
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai updated PIG-905:
---------------------------
Status: Open (was: Patch Available)
> TOKENIZE throws exception on null data
> --------------------------------------
>
> Key: PIG-905
> URL: https://issues.apache.org/jira/browse/PIG-905
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.3.0
> Reporter: Olga Natkovich
> Fix For: 0.4.0
>
> Attachments: PIG-905-1.patch, PIG-905-2.patch, PIG-905-3.patch
>
>
> it should just return null
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-905) TOKENIZE throws exception on null data
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12740524#action_12740524 ]
Hudson commented on PIG-905:
----------------------------
Integrated in Pig-trunk #515 (See [http://hudson.zones.apache.org/hudson/job/Pig-trunk/515/])
: TOKENIZE throws exception on null data
> TOKENIZE throws exception on null data
> --------------------------------------
>
> Key: PIG-905
> URL: https://issues.apache.org/jira/browse/PIG-905
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.3.0
> Reporter: Olga Natkovich
> Fix For: 0.4.0
>
> Attachments: PIG-905-1.patch, PIG-905-2.patch, PIG-905-3.patch
>
>
> it should just return null
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-905) TOKENIZE throws exception on null data
Posted by "Jeff Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12739320#action_12739320 ]
Jeff Zhang commented on PIG-905:
--------------------------------
I find that TOKENIZE can not handle DataByteArray. It can only handle string.
I believe it should be better to handle both DataByteArray and String. In my opinion, whenever an UDF support one of them, it should support both of them.
Because they are almost the same except that DataByteArray is Comparable and Serializable.
> TOKENIZE throws exception on null data
> --------------------------------------
>
> Key: PIG-905
> URL: https://issues.apache.org/jira/browse/PIG-905
> Project: Pig
> Issue Type: Bug
> Reporter: Olga Natkovich
>
> it should just return null
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-905) TOKENIZE throws exception on null data
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12740352#action_12740352 ]
Hadoop QA commented on PIG-905:
-------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12415765/PIG-905-3.patch
against trunk revision 801460.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-minerva.apache.org/154/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-minerva.apache.org/154/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-minerva.apache.org/154/console
This message is automatically generated.
> TOKENIZE throws exception on null data
> --------------------------------------
>
> Key: PIG-905
> URL: https://issues.apache.org/jira/browse/PIG-905
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.3.0
> Reporter: Olga Natkovich
> Fix For: 0.4.0
>
> Attachments: PIG-905-1.patch, PIG-905-2.patch, PIG-905-3.patch
>
>
> it should just return null
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (PIG-905) TOKENIZE throws exception on null data
Posted by "Alan Gates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alan Gates reassigned PIG-905:
------------------------------
Assignee: Daniel Dai
> TOKENIZE throws exception on null data
> --------------------------------------
>
> Key: PIG-905
> URL: https://issues.apache.org/jira/browse/PIG-905
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.3.0
> Reporter: Olga Natkovich
> Assignee: Daniel Dai
> Fix For: 0.4.0
>
> Attachments: PIG-905-1.patch, PIG-905-2.patch, PIG-905-3.patch
>
>
> it should just return null
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-905) TOKENIZE throws exception on null data
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai updated PIG-905:
---------------------------
Attachment: PIG-905-3.patch
Fix unit test
> TOKENIZE throws exception on null data
> --------------------------------------
>
> Key: PIG-905
> URL: https://issues.apache.org/jira/browse/PIG-905
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.3.0
> Reporter: Olga Natkovich
> Fix For: 0.4.0
>
> Attachments: PIG-905-1.patch, PIG-905-2.patch, PIG-905-3.patch
>
>
> it should just return null
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-905) TOKENIZE throws exception on null data
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai updated PIG-905:
---------------------------
Attachment: PIG-905-2.patch
Address Olga's comments and add unit test
> TOKENIZE throws exception on null data
> --------------------------------------
>
> Key: PIG-905
> URL: https://issues.apache.org/jira/browse/PIG-905
> Project: Pig
> Issue Type: Bug
> Reporter: Olga Natkovich
> Attachments: PIG-905-1.patch, PIG-905-2.patch
>
>
> it should just return null
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-905) TOKENIZE throws exception on null data
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai updated PIG-905:
---------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Patch committed.
> TOKENIZE throws exception on null data
> --------------------------------------
>
> Key: PIG-905
> URL: https://issues.apache.org/jira/browse/PIG-905
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.3.0
> Reporter: Olga Natkovich
> Fix For: 0.4.0
>
> Attachments: PIG-905-1.patch, PIG-905-2.patch, PIG-905-3.patch
>
>
> it should just return null
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-905) TOKENIZE throws exception on null data
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12740141#action_12740141 ]
Hadoop QA commented on PIG-905:
-------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12415639/PIG-905-2.patch
against trunk revision 801460.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-minerva.apache.org/151/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-minerva.apache.org/151/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-minerva.apache.org/151/console
This message is automatically generated.
> TOKENIZE throws exception on null data
> --------------------------------------
>
> Key: PIG-905
> URL: https://issues.apache.org/jira/browse/PIG-905
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.3.0
> Reporter: Olga Natkovich
> Fix For: 0.4.0
>
> Attachments: PIG-905-1.patch, PIG-905-2.patch
>
>
> it should just return null
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-905) TOKENIZE throws exception on null data
Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12739527#action_12739527 ]
Olga Natkovich commented on PIG-905:
------------------------------------
I think we should also check for null or empty input tuple and return null in those cases as well. Other than that the patch looks good.
> TOKENIZE throws exception on null data
> --------------------------------------
>
> Key: PIG-905
> URL: https://issues.apache.org/jira/browse/PIG-905
> Project: Pig
> Issue Type: Bug
> Reporter: Olga Natkovich
> Attachments: PIG-905-1.patch
>
>
> it should just return null
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-905) TOKENIZE throws exception on null data
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai updated PIG-905:
---------------------------
Attachment: PIG-905-1.patch
Include null handling suggested by Olga. For Jeff's comment on DataByteArray, it is because TOKENIZE do not declare getArgToFuncMapping. If UDF declare getArgToFuncMapping, Pig can handle type cast correctly. I also include getArgToFuncMapping in the patch.
> TOKENIZE throws exception on null data
> --------------------------------------
>
> Key: PIG-905
> URL: https://issues.apache.org/jira/browse/PIG-905
> Project: Pig
> Issue Type: Bug
> Reporter: Olga Natkovich
> Attachments: PIG-905-1.patch
>
>
> it should just return null
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-905) TOKENIZE throws exception on null data
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai updated PIG-905:
---------------------------
Status: Patch Available (was: Open)
> TOKENIZE throws exception on null data
> --------------------------------------
>
> Key: PIG-905
> URL: https://issues.apache.org/jira/browse/PIG-905
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.3.0
> Reporter: Olga Natkovich
> Fix For: 0.4.0
>
> Attachments: PIG-905-1.patch, PIG-905-2.patch, PIG-905-3.patch
>
>
> it should just return null
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-905) TOKENIZE throws exception on null data
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai updated PIG-905:
---------------------------
Fix Version/s: 0.4.0
Affects Version/s: 0.3.0
Status: Patch Available (was: Open)
> TOKENIZE throws exception on null data
> --------------------------------------
>
> Key: PIG-905
> URL: https://issues.apache.org/jira/browse/PIG-905
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.3.0
> Reporter: Olga Natkovich
> Fix For: 0.4.0
>
> Attachments: PIG-905-1.patch, PIG-905-2.patch
>
>
> it should just return null
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.