You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/08/13 10:43:42 UTC
[GitHub] [flink] elphastori opened a new pull request #16815: [FLINK-23705][connectors/kinesis] Unregistering metric reporting for closed shards
elphastori opened a new pull request #16815:
URL: https://github.com/apache/flink/pull/16815
## What is the purpose of the change
This pull request unregisters metrics reporting for closed shards in the Kinesis connector. This avoids confusing and incorrect aggregated metrics after resharding.
## Brief change log
- ShardConsumerMetricsReporter has an unregister method
- ShardConsumer unregisters ShardConsumerMetricsReporter after consuming shard
## Verifying this change
This change added tests and can be verified as follows:
- Added unit test that checks that the registered MetricGroup is closed after a shard completes.
- Manually verified the change by running a Kinesis Data Analytics app reading from a Kinesis stream with 1 shard then increasing the number of shards to 2, verifying that the metrics for the closed shard are zeroed in the Flink dashboard
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16815: [FLINK-23705][connectors/kinesis] Unregistering metric reporting for closed shards
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16815:
URL: https://github.com/apache/flink/pull/16815#issuecomment-898382012
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "194397942a2539e9bc507c57aa58e66270097e93",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22099",
"triggerID" : "194397942a2539e9bc507c57aa58e66270097e93",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 194397942a2539e9bc507c57aa58e66270097e93 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22099)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dannycranmer commented on pull request #16815: [FLINK-23705][connectors/kinesis] Unregistering metric reporting for closed shards
Posted by GitBox <gi...@apache.org>.
dannycranmer commented on pull request #16815:
URL: https://github.com/apache/flink/pull/16815#issuecomment-898556384
LGTM, thanks @elphastori. Will merge once e2e tests pass
✅ 1. The [description] looks good.
✅ 2. There is [consensus] that the contribution should go into to Flink.
✅ 3. Needs [attention] from. N/A
✅ 4. The change fits into the overall [architecture].
✅ 5. Overall code [quality] is good.
✅ 6. License check N/A
⏲️ 7. E2e tests pass
✅ 8. Commit contains the Jira ID
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dannycranmer merged pull request #16815: [FLINK-23705][connectors/kinesis] Unregistering metric reporting for closed shards
Posted by GitBox <gi...@apache.org>.
dannycranmer merged pull request #16815:
URL: https://github.com/apache/flink/pull/16815
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dannycranmer merged pull request #16815: [FLINK-23705][connectors/kinesis] Unregistering metric reporting for closed shards
Posted by GitBox <gi...@apache.org>.
dannycranmer merged pull request #16815:
URL: https://github.com/apache/flink/pull/16815
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16815: [FLINK-23705][connectors/kinesis] Unregistering metric reporting for closed shards
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16815:
URL: https://github.com/apache/flink/pull/16815#issuecomment-898382012
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "194397942a2539e9bc507c57aa58e66270097e93",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22099",
"triggerID" : "194397942a2539e9bc507c57aa58e66270097e93",
"triggerType" : "PUSH"
}, {
"hash" : "a8d74f7ecabc69b6281ae86a449302461a7e1496",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a8d74f7ecabc69b6281ae86a449302461a7e1496",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 194397942a2539e9bc507c57aa58e66270097e93 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22099)
* a8d74f7ecabc69b6281ae86a449302461a7e1496 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16815: [FLINK-23705][connectors/kinesis] Unregistering metric reporting for closed shards
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16815:
URL: https://github.com/apache/flink/pull/16815#issuecomment-898382012
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "194397942a2539e9bc507c57aa58e66270097e93",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22099",
"triggerID" : "194397942a2539e9bc507c57aa58e66270097e93",
"triggerType" : "PUSH"
}, {
"hash" : "a8d74f7ecabc69b6281ae86a449302461a7e1496",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22391",
"triggerID" : "a8d74f7ecabc69b6281ae86a449302461a7e1496",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 194397942a2539e9bc507c57aa58e66270097e93 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22099)
* a8d74f7ecabc69b6281ae86a449302461a7e1496 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22391)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dannycranmer edited a comment on pull request #16815: [FLINK-23705][connectors/kinesis] Unregistering metric reporting for closed shards
Posted by GitBox <gi...@apache.org>.
dannycranmer edited a comment on pull request #16815:
URL: https://github.com/apache/flink/pull/16815#issuecomment-898556384
LGTM, thanks @elphastori. Will merge once e2e tests pass
✅ 1. The [description] looks good.
✅ 2. There is [consensus] that the contribution should go into to Flink.
✅ 3. Needs [attention] from. N/A
✅ 4. The change fits into the overall [architecture].
✅ 5. Overall code [quality] is good.
✅ 6. License check N/A
✅ 7. E2e tests pass
✅ 8. Commit contains the Jira ID
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16815: [FLINK-23705][connectors/kinesis] Unregistering metric reporting for closed shards
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16815:
URL: https://github.com/apache/flink/pull/16815#issuecomment-898382012
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "194397942a2539e9bc507c57aa58e66270097e93",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22099",
"triggerID" : "194397942a2539e9bc507c57aa58e66270097e93",
"triggerType" : "PUSH"
}, {
"hash" : "a8d74f7ecabc69b6281ae86a449302461a7e1496",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22391",
"triggerID" : "a8d74f7ecabc69b6281ae86a449302461a7e1496",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a8d74f7ecabc69b6281ae86a449302461a7e1496 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22391)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dannycranmer commented on pull request #16815: [FLINK-23705][connectors/kinesis] Unregistering metric reporting for closed shards
Posted by GitBox <gi...@apache.org>.
dannycranmer commented on pull request #16815:
URL: https://github.com/apache/flink/pull/16815#issuecomment-900234878
@elphastori looks like the e2e test failed. Can you please rebase and try again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16815: [FLINK-23705][connectors/kinesis] Unregistering metric reporting for closed shards
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16815:
URL: https://github.com/apache/flink/pull/16815#issuecomment-898369190
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 194397942a2539e9bc507c57aa58e66270097e93 (Fri Aug 13 10:47:37 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dannycranmer edited a comment on pull request #16815: [FLINK-23705][connectors/kinesis] Unregistering metric reporting for closed shards
Posted by GitBox <gi...@apache.org>.
dannycranmer edited a comment on pull request #16815:
URL: https://github.com/apache/flink/pull/16815#issuecomment-898556384
LGTM, thanks @elphastori. Will merge once e2e tests pass
✅ 1. The [description] looks good.
✅ 2. There is [consensus] that the contribution should go into to Flink.
✅ 3. Needs [attention] from. N/A
✅ 4. The change fits into the overall [architecture].
✅ 5. Overall code [quality] is good.
✅ 6. License check N/A
✅ 7. E2e tests pass
✅ 8. Commit contains the Jira ID
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16815: [FLINK-23705][connectors/kinesis] Unregistering metric reporting for closed shards
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16815:
URL: https://github.com/apache/flink/pull/16815#issuecomment-898382012
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "194397942a2539e9bc507c57aa58e66270097e93",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "194397942a2539e9bc507c57aa58e66270097e93",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 194397942a2539e9bc507c57aa58e66270097e93 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16815: [FLINK-23705][connectors/kinesis] Unregistering metric reporting for closed shards
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16815:
URL: https://github.com/apache/flink/pull/16815#issuecomment-898382012
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "194397942a2539e9bc507c57aa58e66270097e93",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22099",
"triggerID" : "194397942a2539e9bc507c57aa58e66270097e93",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 194397942a2539e9bc507c57aa58e66270097e93 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22099)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16815: [FLINK-23705][connectors/kinesis] Unregistering metric reporting for closed shards
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16815:
URL: https://github.com/apache/flink/pull/16815#issuecomment-898382012
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "194397942a2539e9bc507c57aa58e66270097e93",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22099",
"triggerID" : "194397942a2539e9bc507c57aa58e66270097e93",
"triggerType" : "PUSH"
}, {
"hash" : "a8d74f7ecabc69b6281ae86a449302461a7e1496",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22391",
"triggerID" : "a8d74f7ecabc69b6281ae86a449302461a7e1496",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a8d74f7ecabc69b6281ae86a449302461a7e1496 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22391)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org