[GitHub] [rocketmq] duhenglucky commented on a change in pull request #1788: [ISSUE #1787] Fix the issue that queryCq command of mqadmin returned incorrect data

[GitBox <gi...@apache.org>]

duhenglucky commented on a change in pull request #1788: [ISSUE #1787] Fix the issue that queryCq command of mqadmin returned incorrect data
URL: https://github.com/apache/rocketmq/pull/1788#discussion_r384554868
 
 

 ##########
 File path: broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java
 ##########
 @@ -1556,7 +1553,8 @@ private RemotingCommand queryConsumeQueue(ChannelHandlerContext ctx,
         } finally {
             result.release();
         }
-
+        response.setCode(ResponseCode.SUCCESS);
 
 Review comment:
   It would be better not to move response.setcode (ResponseCode.SUCCESS);  because when the result is null, this method will return a Response without a status code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services