You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Camille Fournier (JIRA)" <ji...@apache.org> on 2011/06/13 22:06:51 UTC

[jira] [Created] (ZOOKEEPER-1093) ZooKeeper quotas will always trigger if set on one criteria but not the other

ZooKeeper quotas will always trigger if set on one criteria but not the other 
------------------------------------------------------------------------------

                 Key: ZOOKEEPER-1093
                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1093
             Project: ZooKeeper
          Issue Type: Bug
          Components: server
    Affects Versions: 3.3.3, 3.4.0
            Reporter: Camille Fournier


/testing has quota on bytes but not node count. Count quota will always fire because it is set to -1 and will always fail comparison.

2011-06-13 16:01:53,492 - WARN  [CommitProcessor:3:DataTree@373] - Quota exceeded: /testing count=4 limit=-1



--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (ZOOKEEPER-1093) ZooKeeper quotas will always trigger if set on one criteria but not the other

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13050054#comment-13050054 ] 

Hadoop QA commented on ZOOKEEPER-1093:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12482708/ZOOKEEPER-1093.patch
  against trunk revision 1135515.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/321//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/321//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/321//console

This message is automatically generated.

> ZooKeeper quotas will always trigger if set on one criteria but not the other 
> ------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1093
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1093
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 3.3.3, 3.4.0
>            Reporter: Camille Fournier
>            Assignee: Camille Fournier
>         Attachments: ZOOKEEPER-1093.patch
>
>
> /testing has quota on bytes but not node count. Count quota will always fire because it is set to -1 and will always fail comparison.
> 2011-06-13 16:01:53,492 - WARN  [CommitProcessor:3:DataTree@373] - Quota exceeded: /testing count=4 limit=-1

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (ZOOKEEPER-1093) ZooKeeper quotas will always trigger if set on one criteria but not the other

Posted by "Camille Fournier (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13068072#comment-13068072 ] 

Camille Fournier commented on ZOOKEEPER-1093:
---------------------------------------------

Actually, this got fixed in ZOOKEEPER-1097, so I will close this up.

> ZooKeeper quotas will always trigger if set on one criteria but not the other 
> ------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1093
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1093
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 3.3.3, 3.4.0
>            Reporter: Camille Fournier
>            Assignee: Camille Fournier
>         Attachments: ZOOKEEPER-1093.patch
>
>
> /testing has quota on bytes but not node count. Count quota will always fire because it is set to -1 and will always fail comparison.
> 2011-06-13 16:01:53,492 - WARN  [CommitProcessor:3:DataTree@373] - Quota exceeded: /testing count=4 limit=-1

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (ZOOKEEPER-1093) ZooKeeper quotas will always trigger if set on one criteria but not the other

Posted by "Camille Fournier (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Camille Fournier updated ZOOKEEPER-1093:
----------------------------------------

    Attachment: ZOOKEEPER-1093.patch

> ZooKeeper quotas will always trigger if set on one criteria but not the other 
> ------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1093
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1093
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 3.3.3, 3.4.0
>            Reporter: Camille Fournier
>            Assignee: Camille Fournier
>         Attachments: ZOOKEEPER-1093.patch
>
>
> /testing has quota on bytes but not node count. Count quota will always fire because it is set to -1 and will always fail comparison.
> 2011-06-13 16:01:53,492 - WARN  [CommitProcessor:3:DataTree@373] - Quota exceeded: /testing count=4 limit=-1

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (ZOOKEEPER-1093) ZooKeeper quotas will always trigger if set on one criteria but not the other

Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13068056#comment-13068056 ] 

Patrick Hunt commented on ZOOKEEPER-1093:
-----------------------------------------

I'd like to see this go into 3.4.0, I'm assuming that it's not possible to test (easily -- see testBadPeerAddressInQuorum if you want to try). Is the code exercised, what could we look at in the console output to verify?

> ZooKeeper quotas will always trigger if set on one criteria but not the other 
> ------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1093
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1093
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 3.3.3, 3.4.0
>            Reporter: Camille Fournier
>            Assignee: Camille Fournier
>         Attachments: ZOOKEEPER-1093.patch
>
>
> /testing has quota on bytes but not node count. Count quota will always fire because it is set to -1 and will always fail comparison.
> 2011-06-13 16:01:53,492 - WARN  [CommitProcessor:3:DataTree@373] - Quota exceeded: /testing count=4 limit=-1

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira