You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/10 22:30:01 UTC
[GitHub] [arrow-datafusion] alamb opened a new pull request #315: Update PR template by commenting out instructions
alamb opened a new pull request #315:
URL: https://github.com/apache/arrow-datafusion/pull/315
Inspired by (well, copied from) @nevi-me 's PR https://github.com/apache/arrow-rs/pull/278
# Rationale for this change
Some contributors don't remove the guidelines when creating PRs, so it might be more convenient if we hide them behind comments.
The comments are still visible when editing, but are not displayed when the markdown is rendered
# What changes are included in this PR?
Comments out the text, but not the headings of this PR template.
# Are there any user-facing changes?
no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a change in pull request #315: Update PR template by commenting out instructions
Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #315:
URL: https://github.com/apache/arrow-datafusion/pull/315#discussion_r630021884
##########
File path: .github/pull_request_template.md
##########
@@ -1,19 +1,25 @@
# Which issue does this PR close?
+<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
+-->
Closes #.
# Rationale for this change
+<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
+-->
# What changes are included in this PR?
-
+<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
+-->
# Are there any user-facing changes?
-
+<--
Review comment:
Sorry @nevi-me -- that is what I get from trying to rush this in. Thank you for the help
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] nevi-me commented on a change in pull request #315: Update PR template by commenting out instructions
Posted by GitBox <gi...@apache.org>.
nevi-me commented on a change in pull request #315:
URL: https://github.com/apache/arrow-datafusion/pull/315#discussion_r629807261
##########
File path: .github/pull_request_template.md
##########
@@ -1,19 +1,25 @@
# Which issue does this PR close?
+<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
+-->
Closes #.
# Rationale for this change
+<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
+-->
# What changes are included in this PR?
-
+<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
+-->
# Are there any user-facing changes?
-
+<--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
If there are any breaking changes to public APIs, please add the `breaking change` label.
Review comment:
```suggestion
<!--
If there are any breaking changes to public APIs, please add the `breaking change` label.
```
##########
File path: .github/pull_request_template.md
##########
@@ -1,19 +1,25 @@
# Which issue does this PR close?
+<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
+-->
Closes #.
# Rationale for this change
+<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
+-->
# What changes are included in this PR?
-
+<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
+-->
# Are there any user-facing changes?
-
+<--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
Review comment:
```suggestion
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
```
##########
File path: .github/pull_request_template.md
##########
@@ -1,19 +1,25 @@
# Which issue does this PR close?
+<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
+-->
Closes #.
# Rationale for this change
+<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
+-->
# What changes are included in this PR?
-
+<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
+-->
# Are there any user-facing changes?
-
+<--
Review comment:
```suggestion
<!--
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #315: Update PR template by commenting out instructions
Posted by GitBox <gi...@apache.org>.
alamb merged pull request #315:
URL: https://github.com/apache/arrow-datafusion/pull/315
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] codecov-commenter edited a comment on pull request #315: Update PR template by commenting out instructions
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #315:
URL: https://github.com/apache/arrow-datafusion/pull/315#issuecomment-837451251
# [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/315?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#315](https://codecov.io/gh/apache/arrow-datafusion/pull/315?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b975258) into [master](https://codecov.io/gh/apache/arrow-datafusion/commit/ee69ac85785e940cf48f3780460c6f103ce0cf4a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ee69ac8) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/arrow-datafusion/pull/315?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #315 +/- ##
=======================================
Coverage 76.08% 76.08%
=======================================
Files 141 141
Lines 23734 23734
=======================================
Hits 18057 18057
Misses 5677 5677
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/315?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/315?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ee69ac8...b975258](https://codecov.io/gh/apache/arrow-datafusion/pull/315?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] nevi-me commented on a change in pull request #315: Update PR template by commenting out instructions
Posted by GitBox <gi...@apache.org>.
nevi-me commented on a change in pull request #315:
URL: https://github.com/apache/arrow-datafusion/pull/315#discussion_r629807104
##########
File path: .github/pull_request_template.md
##########
@@ -1,19 +1,25 @@
# Which issue does this PR close?
+<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
+-->
Closes #.
# Rationale for this change
+<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
+-->
# What changes are included in this PR?
-
+<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
+-->
# Are there any user-facing changes?
-
+<--
Review comment:
@alamb these lines need to be commented out separately
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #315: Update PR template by commenting out instructions
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #315:
URL: https://github.com/apache/arrow-datafusion/pull/315#issuecomment-837451251
# [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/315?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#315](https://codecov.io/gh/apache/arrow-datafusion/pull/315?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b975258) into [master](https://codecov.io/gh/apache/arrow-datafusion/commit/ee69ac85785e940cf48f3780460c6f103ce0cf4a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ee69ac8) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/arrow-datafusion/pull/315?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #315 +/- ##
=======================================
Coverage 76.08% 76.08%
=======================================
Files 141 141
Lines 23734 23734
=======================================
Hits 18057 18057
Misses 5677 5677
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/315?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/315?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ee69ac8...b975258](https://codecov.io/gh/apache/arrow-datafusion/pull/315?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org