You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@perl.apache.org by Randy Kobes <ra...@theoryx5.uwinnipeg.ca> on 2003/12/15 16:41:06 UTC

[mp2] src/modules/perl/modperl_mgv.c

With the current mp2 sources, a couple of variables in
modperl_mgv.c need to be declared earlier for Win32:
========================================
Index: src/modules/perl/modperl_mgv.c
===================================================================
RCS file: /home/cvs/modperl-2.0/src/modules/perl/modperl_mgv.c,v
retrieving revision 1.28
diff -u -r1.28 modperl_mgv.c
--- src/modules/perl/modperl_mgv.c	15 Dec 2003 03:13:36 -0000	1.28
+++ src/modules/perl/modperl_mgv.c	15 Dec 2003 15:41:29 -0000
@@ -185,9 +185,9 @@
 static void package2filename(apr_pool_t *p, const char *package,
                              char **filename, int *len)
 {
-    *filename = apr_palloc(p, (strlen(package)+4)*sizeof(char));
     const char *s;
     char *d;
+    *filename = apr_palloc(p, (strlen(package)+4)*sizeof(char));

     for (s = package, d = *filename; *s; s++, d++) {
         if (*s == ':' && s[1] == ':') {
====================================================================

-- 
best regards,
randy

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Re: [mp2] src/modules/perl/modperl_mgv.c

Posted by Stas Bekman <st...@stason.org>.
Randy Kobes wrote:
> With the current mp2 sources, a couple of variables in
> modperl_mgv.c need to be declared earlier for Win32:
> ========================================
> Index: src/modules/perl/modperl_mgv.c
> ===================================================================
> RCS file: /home/cvs/modperl-2.0/src/modules/perl/modperl_mgv.c,v
> retrieving revision 1.28
> diff -u -r1.28 modperl_mgv.c
> --- src/modules/perl/modperl_mgv.c	15 Dec 2003 03:13:36 -0000	1.28
> +++ src/modules/perl/modperl_mgv.c	15 Dec 2003 15:41:29 -0000
> @@ -185,9 +185,9 @@
>  static void package2filename(apr_pool_t *p, const char *package,
>                               char **filename, int *len)
>  {
> -    *filename = apr_palloc(p, (strlen(package)+4)*sizeof(char));
>      const char *s;
>      char *d;
> +    *filename = apr_palloc(p, (strlen(package)+4)*sizeof(char));
> 
>      for (s = package, d = *filename; *s; s++, d++) {
>          if (*s == ':' && s[1] == ':') {
> ====================================================================

Thanks Randy, Philippe has committed this one already. In the future just go 
ahead and commit this kind of things.

__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org