You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/04/04 15:48:05 UTC
[GitHub] [superset] hughhhh opened a new pull request #13946: fix: SQL -> Explore Overwrite flow
hughhhh opened a new pull request #13946:
URL: https://github.com/apache/superset/pull/13946
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
In prod overwrite flow causes an error when landing in explore view. We've fixed this by doing a quick refresh before returning the payload on update.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
1. Goto SQLLab
2. Write and run query
3. Click Explore
4. Save as new query
5. Edit query in SQLLab
6. Save as overwrite
7. Verify explore view doesn't throw an error
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13946: fix: SQL -> Explore Overwrite flow
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13946:
URL: https://github.com/apache/superset/pull/13946#issuecomment-813059916
# [Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=h1) Report
> Merging [#13946](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=desc) (9ff89af) into [master](https://codecov.io/gh/apache/superset/commit/9d0bb3a3ba38c2289d77e87dfe572c57c51ef7c7?el=desc) (9d0bb3a) will **decrease** coverage by `1.82%`.
> The diff coverage is `73.39%`.
> :exclamation: Current head 9ff89af differs from pull request most recent head 06ec82b. Consider uploading reports for the commit 06ec82b to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13946 +/- ##
==========================================
- Coverage 76.78% 74.95% -1.83%
==========================================
Files 935 951 +16
Lines 47292 48314 +1022
Branches 5895 6207 +312
==========================================
- Hits 36311 36216 -95
- Misses 10824 11936 +1112
- Partials 157 162 +5
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `51.03% <55.26%> (-1.27%)` | :arrow_down: |
| hive | `?` | |
| mysql | `80.56% <76.78%> (-0.04%)` | :arrow_down: |
| postgres | `80.60% <76.78%> (-0.04%)` | :arrow_down: |
| presto | `?` | |
| python | `80.68% <76.78%> (-0.46%)` | :arrow_down: |
| sqlite | `80.16% <76.78%> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/SqlLab/components/ScheduleQueryButton.tsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NjaGVkdWxlUXVlcnlCdXR0b24udHN4) | `28.12% <ø> (ø)` | |
| [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `88.37% <0.00%> (ø)` | |
| [...frontend/src/components/Checkbox/CheckboxIcons.tsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hlY2tib3gvQ2hlY2tib3hJY29ucy50c3g=) | `83.33% <ø> (ø)` | |
| [...frontend/src/components/DatabaseSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YWJhc2VTZWxlY3Rvci9pbmRleC50c3g=) | `91.66% <ø> (ø)` | |
| [superset-frontend/src/components/Select/index.ts](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L2luZGV4LnRz) | `100.00% <ø> (ø)` | |
| [...ontend/src/components/URLShortLinkButton/index.jsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVVJMU2hvcnRMaW5rQnV0dG9uL2luZGV4LmpzeA==) | `100.00% <ø> (ø)` | |
| [.../components/CrossFilterScopingModal/utils/index.ts](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nyb3NzRmlsdGVyU2NvcGluZ01vZGFsL3V0aWxzL2luZGV4LnRz) | `33.33% <ø> (ø)` | |
| [...src/dashboard/components/PublishedStatus/index.jsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1B1Ymxpc2hlZFN0YXR1cy9pbmRleC5qc3g=) | `52.38% <ø> (ø)` | |
| [...src/dashboard/components/dnd/handleScroll/index.ts](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVTY3JvbGwvaW5kZXgudHM=) | `38.46% <ø> (ø)` | |
| [...src/dashboard/components/filterscope/treeIcons.jsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL3RyZWVJY29ucy5qc3g=) | `100.00% <ø> (ø)` | |
| ... and [224 more](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=footer). Last update [f81b746...06ec82b](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13946: fix: SQL -> Explore Overwrite flow
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13946:
URL: https://github.com/apache/superset/pull/13946#issuecomment-813059916
# [Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=h1) Report
> Merging [#13946](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=desc) (756436a) into [master](https://codecov.io/gh/apache/superset/commit/9d0bb3a3ba38c2289d77e87dfe572c57c51ef7c7?el=desc) (9d0bb3a) will **increase** coverage by `0.31%`.
> The diff coverage is `71.42%`.
[](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13946 +/- ##
==========================================
+ Coverage 76.78% 77.09% +0.31%
==========================================
Files 935 952 +17
Lines 47292 48444 +1152
Branches 5895 6280 +385
==========================================
+ Hits 36311 37347 +1036
- Misses 10824 10953 +129
+ Partials 157 144 -13
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.20% <100.00%> (+3.90%)` | :arrow_up: |
| javascript | `63.71% <100.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/views/CRUD/alert/types.ts](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
| [superset/models/reports.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3JlcG9ydHMucHk=) | `100.00% <ø> (ø)` | |
| [superset/tasks/scheduler.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVyLnB5) | `0.00% <0.00%> (ø)` | |
| [.../src/explore/components/controls/SelectControl.jsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9TZWxlY3RDb250cm9sLmpzeA==) | `94.30% <100.00%> (+5.02%)` | :arrow_up: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `100.00% <100.00%> (ø)` | |
| [superset/datasets/api.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `91.44% <100.00%> (ø)` | |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `93.44% <100.00%> (ø)` | |
| [superset/reports/logs/api.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9sb2dzL2FwaS5weQ==) | `95.45% <100.00%> (ø)` | |
| [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `61.11% <0.00%> (-27.27%)` | :arrow_down: |
| [...rset-frontend/src/components/ProgressBar/index.tsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUHJvZ3Jlc3NCYXIvaW5kZXgudHN4) | `76.92% <0.00%> (-23.08%)` | :arrow_down: |
| ... and [92 more](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=footer). Last update [f81b746...756436a](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13946: fix: SQL -> Explore Overwrite flow
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13946:
URL: https://github.com/apache/superset/pull/13946#issuecomment-813059916
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #13946: fix: SQL -> Explore Overwrite flow
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13946:
URL: https://github.com/apache/superset/pull/13946#issuecomment-813612755
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on a change in pull request #13946: fix: SQL -> Explore Overwrite flow
Posted by GitBox <gi...@apache.org>.
eschutho commented on a change in pull request #13946:
URL: https://github.com/apache/superset/pull/13946#discussion_r607214397
##########
File path: tests/datasets/api_tests.py
##########
@@ -598,12 +598,7 @@ def test_update_dataset_item_w_override_columns(self):
rv = self.put_assert_metric(uri, dataset_data, "put")
assert rv.status_code == 200
- columns = (
- db.session.query(TableColumn)
- .filter_by(table_id=dataset.id)
- .order_by("column_name")
- .all()
- )
+ columns = db.session.query(TableColumn).filter_by(table_id=dataset.id).all()
Review comment:
we're removing the ordering in the tests? Was it failing with the order/
##########
File path: tests/datasets/api_tests.py
##########
@@ -598,12 +598,7 @@ def test_update_dataset_item_w_override_columns(self):
rv = self.put_assert_metric(uri, dataset_data, "put")
assert rv.status_code == 200
- columns = (
- db.session.query(TableColumn)
- .filter_by(table_id=dataset.id)
- .order_by("column_name")
- .all()
- )
+ columns = db.session.query(TableColumn).filter_by(table_id=dataset.id).all()
Review comment:
we're removing the ordering in the tests? Was it failing with the order?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13946: fix: SQL -> Explore Overwrite flow
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13946:
URL: https://github.com/apache/superset/pull/13946#issuecomment-813059916
# [Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=h1) Report
> Merging [#13946](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=desc) (61e7196) into [master](https://codecov.io/gh/apache/superset/commit/9d0bb3a3ba38c2289d77e87dfe572c57c51ef7c7?el=desc) (9d0bb3a) will **increase** coverage by `1.30%`.
> The diff coverage is `82.60%`.
> :exclamation: Current head 61e7196 differs from pull request most recent head e93f887. Consider uploading reports for the commit e93f887 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13946 +/- ##
==========================================
+ Coverage 76.78% 78.08% +1.30%
==========================================
Files 935 934 -1
Lines 47292 47354 +62
Branches 5895 5952 +57
==========================================
+ Hits 36311 36978 +667
+ Misses 10824 10232 -592
+ Partials 157 144 -13
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `80.60% <76.78%> (-0.04%)` | :arrow_down: |
| presto | `?` | |
| python | `80.64% <76.78%> (-0.50%)` | :arrow_down: |
| sqlite | `80.16% <76.78%> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/SqlLab/components/ScheduleQueryButton.tsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NjaGVkdWxlUXVlcnlCdXR0b24udHN4) | `28.12% <ø> (ø)` | |
| [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `88.60% <ø> (+0.23%)` | :arrow_up: |
| [...frontend/src/components/Checkbox/CheckboxIcons.tsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hlY2tib3gvQ2hlY2tib3hJY29ucy50c3g=) | `85.71% <ø> (ø)` | |
| [...frontend/src/components/DatabaseSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YWJhc2VTZWxlY3Rvci9pbmRleC50c3g=) | `92.70% <ø> (+1.04%)` | :arrow_up: |
| [superset-frontend/src/components/Icon/index.tsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbi9pbmRleC50c3g=) | `100.00% <ø> (ø)` | |
| [...rset-frontend/src/components/ProgressBar/index.tsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUHJvZ3Jlc3NCYXIvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [...ontend/src/components/URLShortLinkButton/index.jsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVVJMU2hvcnRMaW5rQnV0dG9uL2luZGV4LmpzeA==) | `100.00% <ø> (ø)` | |
| [.../components/CrossFilterScopingModal/utils/index.ts](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nyb3NzRmlsdGVyU2NvcGluZ01vZGFsL3V0aWxzL2luZGV4LnRz) | `100.00% <ø> (ø)` | |
| [...src/dashboard/components/PublishedStatus/index.jsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1B1Ymxpc2hlZFN0YXR1cy9pbmRleC5qc3g=) | `100.00% <ø> (ø)` | |
| [...src/dashboard/components/dnd/handleScroll/index.ts](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVTY3JvbGwvaW5kZXgudHM=) | `73.33% <ø> (ø)` | |
| ... and [164 more](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=footer). Last update [f81b746...e93f887](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13946: fix: SQL -> Explore Overwrite flow
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13946:
URL: https://github.com/apache/superset/pull/13946#issuecomment-813059916
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13946: fix: SQL -> Explore Overwrite flow
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13946:
URL: https://github.com/apache/superset/pull/13946#issuecomment-813059916
# [Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=h1) Report
> Merging [#13946](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=desc) (e93f887) into [master](https://codecov.io/gh/apache/superset/commit/9d0bb3a3ba38c2289d77e87dfe572c57c51ef7c7?el=desc) (9d0bb3a) will **increase** coverage by `1.18%`.
> The diff coverage is `88.88%`.
[](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13946 +/- ##
==========================================
+ Coverage 76.78% 77.96% +1.18%
==========================================
Files 935 935
Lines 47292 49218 +1926
Branches 5895 5942 +47
==========================================
+ Hits 36311 38375 +2064
+ Misses 10824 10699 -125
+ Partials 157 144 -13
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.03% <100.00%> (+3.73%)` | :arrow_up: |
| hive | `80.81% <87.50%> (+0.52%)` | :arrow_up: |
| mysql | `80.60% <81.81%> (+<0.01%)` | :arrow_up: |
| postgres | `80.63% <81.81%> (+<0.01%)` | :arrow_up: |
| presto | `80.28% <85.71%> (-0.02%)` | :arrow_down: |
| python | `81.65% <87.50%> (+0.51%)` | :arrow_up: |
| sqlite | `80.20% <81.81%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/views/CRUD/alert/types.ts](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
| [superset/reports/logs/api.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9sb2dzL2FwaS5weQ==) | `95.45% <ø> (ø)` | |
| [superset/tasks/scheduler.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVyLnB5) | `0.00% <0.00%> (ø)` | |
| [.../src/explore/components/controls/SelectControl.jsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9TZWxlY3RDb250cm9sLmpzeA==) | `93.75% <100.00%> (+4.46%)` | :arrow_up: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `100.00% <100.00%> (ø)` | |
| [superset/datasets/api.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `91.51% <100.00%> (+0.07%)` | :arrow_up: |
| [superset/models/reports.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3JlcG9ydHMucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `95.40% <100.00%> (+1.96%)` | :arrow_up: |
| [superset/examples/big\_data.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlnX2RhdGEucHk=) | `29.62% <0.00%> (-3.71%)` | :arrow_down: |
| [superset/reports/notifications/base.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `94.11% <0.00%> (-1.54%)` | :arrow_down: |
| ... and [72 more](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=footer). Last update [f81b746...e93f887](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13946: fix: SQL -> Explore Overwrite flow
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13946:
URL: https://github.com/apache/superset/pull/13946#issuecomment-813059916
# [Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=h1) Report
> Merging [#13946](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=desc) (06ec82b) into [master](https://codecov.io/gh/apache/superset/commit/9d0bb3a3ba38c2289d77e87dfe572c57c51ef7c7?el=desc) (9d0bb3a) will **increase** coverage by `0.26%`.
> The diff coverage is `84.61%`.
[](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13946 +/- ##
==========================================
+ Coverage 76.78% 77.04% +0.26%
==========================================
Files 935 935
Lines 47292 47274 -18
Branches 5895 5942 +47
==========================================
+ Hits 36311 36422 +111
+ Misses 10824 10708 -116
+ Partials 157 144 -13
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `80.20% <81.81%> (-0.94%)` | :arrow_down: |
| sqlite | `80.20% <81.81%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/views/CRUD/alert/types.ts](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
| [superset/reports/logs/api.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9sb2dzL2FwaS5weQ==) | `95.45% <ø> (ø)` | |
| [superset/tasks/scheduler.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVyLnB5) | `0.00% <0.00%> (ø)` | |
| [.../src/explore/components/controls/SelectControl.jsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9TZWxlY3RDb250cm9sLmpzeA==) | `93.75% <100.00%> (+4.46%)` | :arrow_up: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `100.00% <100.00%> (ø)` | |
| [superset/datasets/api.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `91.51% <100.00%> (+0.07%)` | :arrow_up: |
| [superset/models/reports.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3JlcG9ydHMucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `93.58% <100.00%> (+0.14%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `31.37% <0.00%> (-60.79%)` | :arrow_down: |
| ... and [90 more](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=footer). Last update [f81b746...06ec82b](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13946: fix: SQL -> Explore Overwrite flow
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13946:
URL: https://github.com/apache/superset/pull/13946#issuecomment-813059916
# [Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=h1) Report
> Merging [#13946](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=desc) (e93f887) into [master](https://codecov.io/gh/apache/superset/commit/9d0bb3a3ba38c2289d77e87dfe572c57c51ef7c7?el=desc) (9d0bb3a) will **increase** coverage by `0.70%`.
> The diff coverage is `84.61%`.
[](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13946 +/- ##
==========================================
+ Coverage 76.78% 77.48% +0.70%
==========================================
Files 935 935
Lines 47292 47302 +10
Branches 5895 5942 +47
==========================================
+ Hits 36311 36650 +339
+ Misses 10824 10508 -316
+ Partials 157 144 -13
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.03% <100.00%> (+3.73%)` | :arrow_up: |
| hive | `80.29% <81.81%> (+<0.01%)` | :arrow_up: |
| mysql | `80.60% <81.81%> (+<0.01%)` | :arrow_up: |
| postgres | `80.63% <81.81%> (+<0.01%)` | :arrow_up: |
| presto | `?` | |
| python | `81.01% <81.81%> (-0.13%)` | :arrow_down: |
| sqlite | `80.20% <81.81%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/views/CRUD/alert/types.ts](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
| [superset/reports/logs/api.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9sb2dzL2FwaS5weQ==) | `95.45% <ø> (ø)` | |
| [superset/tasks/scheduler.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVyLnB5) | `0.00% <0.00%> (ø)` | |
| [.../src/explore/components/controls/SelectControl.jsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9TZWxlY3RDb250cm9sLmpzeA==) | `93.75% <100.00%> (+4.46%)` | :arrow_up: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `100.00% <100.00%> (ø)` | |
| [superset/datasets/api.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `91.51% <100.00%> (+0.07%)` | :arrow_up: |
| [superset/models/reports.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3JlcG9ydHMucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `93.58% <100.00%> (+0.14%)` | :arrow_up: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.84% <0.00%> (-5.44%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.87% <0.00%> (-0.61%)` | :arrow_down: |
| ... and [62 more](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=footer). Last update [f81b746...e93f887](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13946: fix: SQL -> Explore Overwrite flow
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13946:
URL: https://github.com/apache/superset/pull/13946#issuecomment-813059916
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13946: fix: SQL -> Explore Overwrite flow
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13946:
URL: https://github.com/apache/superset/pull/13946#issuecomment-813059916
# [Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=h1) Report
> Merging [#13946](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=desc) (9ff89af) into [master](https://codecov.io/gh/apache/superset/commit/9d0bb3a3ba38c2289d77e87dfe572c57c51ef7c7?el=desc) (9d0bb3a) will **decrease** coverage by `2.87%`.
> The diff coverage is `72.90%`.
> :exclamation: Current head 9ff89af differs from pull request most recent head 06ec82b. Consider uploading reports for the commit 06ec82b to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13946 +/- ##
==========================================
- Coverage 76.78% 73.91% -2.88%
==========================================
Files 935 951 +16
Lines 47292 48314 +1022
Branches 5895 6207 +312
==========================================
- Hits 36311 35709 -602
- Misses 10824 12428 +1604
- Partials 157 177 +20
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `43.57% <52.63%> (-8.73%)` | :arrow_down: |
| hive | `?` | |
| mysql | `80.56% <76.78%> (-0.04%)` | :arrow_down: |
| postgres | `80.60% <76.78%> (-0.04%)` | :arrow_down: |
| presto | `?` | |
| python | `80.68% <76.78%> (-0.46%)` | :arrow_down: |
| sqlite | `80.16% <76.78%> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/SqlLab/components/ScheduleQueryButton.tsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NjaGVkdWxlUXVlcnlCdXR0b24udHN4) | `28.12% <ø> (ø)` | |
| [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `88.37% <0.00%> (ø)` | |
| [...frontend/src/components/Checkbox/CheckboxIcons.tsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hlY2tib3gvQ2hlY2tib3hJY29ucy50c3g=) | `83.33% <ø> (ø)` | |
| [...frontend/src/components/DatabaseSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YWJhc2VTZWxlY3Rvci9pbmRleC50c3g=) | `91.66% <ø> (ø)` | |
| [superset-frontend/src/components/Select/index.ts](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L2luZGV4LnRz) | `100.00% <ø> (ø)` | |
| [...ontend/src/components/URLShortLinkButton/index.jsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVVJMU2hvcnRMaW5rQnV0dG9uL2luZGV4LmpzeA==) | `100.00% <ø> (ø)` | |
| [.../components/CrossFilterScopingModal/utils/index.ts](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nyb3NzRmlsdGVyU2NvcGluZ01vZGFsL3V0aWxzL2luZGV4LnRz) | `33.33% <ø> (ø)` | |
| [...src/dashboard/components/PublishedStatus/index.jsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1B1Ymxpc2hlZFN0YXR1cy9pbmRleC5qc3g=) | `52.38% <ø> (ø)` | |
| [...src/dashboard/components/dnd/handleScroll/index.ts](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVTY3JvbGwvaW5kZXgudHM=) | `38.46% <ø> (ø)` | |
| [...src/dashboard/components/filterscope/treeIcons.jsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL3RyZWVJY29ucy5qc3g=) | `100.00% <ø> (ø)` | |
| ... and [215 more](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=footer). Last update [f81b746...06ec82b](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] hughhhh commented on pull request #13946: fix: SQL -> Explore Overwrite flow
Posted by GitBox <gi...@apache.org>.
hughhhh commented on pull request #13946:
URL: https://github.com/apache/superset/pull/13946#issuecomment-813087050
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13946: fix: SQL -> Explore Overwrite flow
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13946:
URL: https://github.com/apache/superset/pull/13946#issuecomment-813059916
# [Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=h1) Report
> Merging [#13946](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=desc) (756436a) into [master](https://codecov.io/gh/apache/superset/commit/9d0bb3a3ba38c2289d77e87dfe572c57c51ef7c7?el=desc) (9d0bb3a) will **increase** coverage by `0.31%`.
> The diff coverage is `71.42%`.
> :exclamation: Current head 756436a differs from pull request most recent head e93f887. Consider uploading reports for the commit e93f887 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13946 +/- ##
==========================================
+ Coverage 76.78% 77.09% +0.31%
==========================================
Files 935 952 +17
Lines 47292 48444 +1152
Branches 5895 6280 +385
==========================================
+ Hits 36311 37347 +1036
- Misses 10824 10953 +129
+ Partials 157 144 -13
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.20% <100.00%> (+3.90%)` | :arrow_up: |
| javascript | `63.71% <100.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/views/CRUD/alert/types.ts](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
| [superset/models/reports.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3JlcG9ydHMucHk=) | `100.00% <ø> (ø)` | |
| [superset/tasks/scheduler.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVyLnB5) | `0.00% <0.00%> (ø)` | |
| [.../src/explore/components/controls/SelectControl.jsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9TZWxlY3RDb250cm9sLmpzeA==) | `94.30% <100.00%> (+5.02%)` | :arrow_up: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `100.00% <100.00%> (ø)` | |
| [superset/datasets/api.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `91.44% <100.00%> (ø)` | |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `93.44% <100.00%> (ø)` | |
| [superset/reports/logs/api.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9sb2dzL2FwaS5weQ==) | `95.45% <100.00%> (ø)` | |
| [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `61.11% <0.00%> (-27.27%)` | :arrow_down: |
| [...rset-frontend/src/components/ProgressBar/index.tsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUHJvZ3Jlc3NCYXIvaW5kZXgudHN4) | `76.92% <0.00%> (-23.08%)` | :arrow_down: |
| ... and [92 more](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=footer). Last update [f81b746...e93f887](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13946: fix: SQL -> Explore Overwrite flow
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13946:
URL: https://github.com/apache/superset/pull/13946#issuecomment-813059916
# [Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=h1) Report
> Merging [#13946](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=desc) (756436a) into [master](https://codecov.io/gh/apache/superset/commit/9d0bb3a3ba38c2289d77e87dfe572c57c51ef7c7?el=desc) (9d0bb3a) will **increase** coverage by `0.76%`.
> The diff coverage is `71.42%`.
[](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13946 +/- ##
==========================================
+ Coverage 76.78% 77.54% +0.76%
==========================================
Files 935 935
Lines 47292 47292
Branches 5895 5896 +1
==========================================
+ Hits 36311 36673 +362
+ Misses 10824 10475 -349
+ Partials 157 144 -13
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.04% <100.00%> (+3.73%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/views/CRUD/alert/types.ts](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
| [superset/models/reports.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3JlcG9ydHMucHk=) | `100.00% <ø> (ø)` | |
| [superset/tasks/scheduler.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVyLnB5) | `0.00% <0.00%> (ø)` | |
| [.../src/explore/components/controls/SelectControl.jsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9TZWxlY3RDb250cm9sLmpzeA==) | `93.75% <100.00%> (+4.46%)` | :arrow_up: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `100.00% <100.00%> (ø)` | |
| [superset/datasets/api.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `91.44% <100.00%> (ø)` | |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `93.44% <100.00%> (ø)` | |
| [superset/reports/logs/api.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9sb2dzL2FwaS5weQ==) | `95.45% <100.00%> (ø)` | |
| ... and [66 more](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=footer). Last update [f81b746...756436a](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13946: fix: SQL -> Explore Overwrite flow
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13946:
URL: https://github.com/apache/superset/pull/13946#issuecomment-813059916
# [Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=h1) Report
> Merging [#13946](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=desc) (9ff89af) into [master](https://codecov.io/gh/apache/superset/commit/9d0bb3a3ba38c2289d77e87dfe572c57c51ef7c7?el=desc) (9d0bb3a) will **increase** coverage by `0.49%`.
> The diff coverage is `78.08%`.
> :exclamation: Current head 9ff89af differs from pull request most recent head 06ec82b. Consider uploading reports for the commit 06ec82b to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13946 +/- ##
==========================================
+ Coverage 76.78% 77.27% +0.49%
==========================================
Files 935 935
Lines 47292 47318 +26
Branches 5895 5942 +47
==========================================
+ Hits 36311 36565 +254
+ Misses 10824 10609 -215
+ Partials 157 144 -13
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `80.58% <76.78%> (-0.06%)` | :arrow_down: |
| presto | `?` | |
| python | `80.62% <76.78%> (-0.52%)` | :arrow_down: |
| sqlite | `80.16% <76.78%> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/SqlLab/components/ScheduleQueryButton.tsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NjaGVkdWxlUXVlcnlCdXR0b24udHN4) | `28.12% <ø> (ø)` | |
| [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `88.37% <0.00%> (ø)` | |
| [...frontend/src/components/DatabaseSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YWJhc2VTZWxlY3Rvci9pbmRleC50c3g=) | `91.66% <ø> (ø)` | |
| [superset-frontend/src/components/Select/index.ts](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L2luZGV4LnRz) | `100.00% <ø> (ø)` | |
| [...ontend/src/components/URLShortLinkButton/index.jsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVVJMU2hvcnRMaW5rQnV0dG9uL2luZGV4LmpzeA==) | `100.00% <ø> (ø)` | |
| [...src/dashboard/components/filterscope/treeIcons.jsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL3RyZWVJY29ucy5qc3g=) | `100.00% <ø> (ø)` | |
| [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | `65.82% <0.00%> (ø)` | |
| [...rontend/src/explore/components/EmbedCodeButton.jsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FbWJlZENvZGVCdXR0b24uanN4) | `80.76% <ø> (ø)` | |
| [...explore/components/controls/ColorPickerControl.jsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db2xvclBpY2tlckNvbnRyb2wuanN4) | `85.00% <ø> (ø)` | |
| [...controls/DndColumnSelectControl/DndSelectLabel.tsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZFNlbGVjdExhYmVsLnRzeA==) | `35.00% <ø> (ø)` | |
| ... and [147 more](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=footer). Last update [f81b746...06ec82b](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13946: fix: SQL -> Explore Overwrite flow
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13946:
URL: https://github.com/apache/superset/pull/13946#issuecomment-813059916
# [Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=h1) Report
> Merging [#13946](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=desc) (9ff89af) into [master](https://codecov.io/gh/apache/superset/commit/9d0bb3a3ba38c2289d77e87dfe572c57c51ef7c7?el=desc) (9d0bb3a) will **increase** coverage by `0.50%`.
> The diff coverage is `78.08%`.
> :exclamation: Current head 9ff89af differs from pull request most recent head 06ec82b. Consider uploading reports for the commit 06ec82b to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13946 +/- ##
==========================================
+ Coverage 76.78% 77.28% +0.50%
==========================================
Files 935 935
Lines 47292 47345 +53
Branches 5895 5942 +47
==========================================
+ Hits 36311 36591 +280
+ Misses 10824 10610 -214
+ Partials 157 144 -13
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `80.60% <76.78%> (-0.04%)` | :arrow_down: |
| presto | `?` | |
| python | `80.64% <76.78%> (-0.50%)` | :arrow_down: |
| sqlite | `80.16% <76.78%> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/SqlLab/components/ScheduleQueryButton.tsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NjaGVkdWxlUXVlcnlCdXR0b24udHN4) | `28.12% <ø> (ø)` | |
| [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `88.37% <0.00%> (ø)` | |
| [...frontend/src/components/DatabaseSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YWJhc2VTZWxlY3Rvci9pbmRleC50c3g=) | `91.66% <ø> (ø)` | |
| [superset-frontend/src/components/Select/index.ts](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L2luZGV4LnRz) | `100.00% <ø> (ø)` | |
| [...ontend/src/components/URLShortLinkButton/index.jsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVVJMU2hvcnRMaW5rQnV0dG9uL2luZGV4LmpzeA==) | `100.00% <ø> (ø)` | |
| [...src/dashboard/components/filterscope/treeIcons.jsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL3RyZWVJY29ucy5qc3g=) | `100.00% <ø> (ø)` | |
| [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | `65.82% <0.00%> (ø)` | |
| [...rontend/src/explore/components/EmbedCodeButton.jsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FbWJlZENvZGVCdXR0b24uanN4) | `80.76% <ø> (ø)` | |
| [...explore/components/controls/ColorPickerControl.jsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db2xvclBpY2tlckNvbnRyb2wuanN4) | `85.00% <ø> (ø)` | |
| [...controls/DndColumnSelectControl/DndSelectLabel.tsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZFNlbGVjdExhYmVsLnRzeA==) | `35.00% <ø> (ø)` | |
| ... and [141 more](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=footer). Last update [f81b746...06ec82b](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13946: fix: SQL -> Explore Overwrite flow
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13946:
URL: https://github.com/apache/superset/pull/13946#issuecomment-813059916
# [Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=h1) Report
> Merging [#13946](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=desc) (61e7196) into [master](https://codecov.io/gh/apache/superset/commit/9d0bb3a3ba38c2289d77e87dfe572c57c51ef7c7?el=desc) (9d0bb3a) will **increase** coverage by `1.28%`.
> The diff coverage is `82.60%`.
> :exclamation: Current head 61e7196 differs from pull request most recent head e93f887. Consider uploading reports for the commit e93f887 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13946 +/- ##
==========================================
+ Coverage 76.78% 78.06% +1.28%
==========================================
Files 935 934 -1
Lines 47292 47354 +62
Branches 5895 5952 +57
==========================================
+ Hits 36311 36967 +656
+ Misses 10824 10243 -581
+ Partials 157 144 -13
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `80.60% <76.78%> (-0.04%)` | :arrow_down: |
| presto | `?` | |
| python | `80.60% <76.78%> (-0.54%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/SqlLab/components/ScheduleQueryButton.tsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NjaGVkdWxlUXVlcnlCdXR0b24udHN4) | `28.12% <ø> (ø)` | |
| [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `88.60% <ø> (+0.23%)` | :arrow_up: |
| [...frontend/src/components/Checkbox/CheckboxIcons.tsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hlY2tib3gvQ2hlY2tib3hJY29ucy50c3g=) | `85.71% <ø> (ø)` | |
| [...frontend/src/components/DatabaseSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YWJhc2VTZWxlY3Rvci9pbmRleC50c3g=) | `92.70% <ø> (+1.04%)` | :arrow_up: |
| [superset-frontend/src/components/Icon/index.tsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbi9pbmRleC50c3g=) | `100.00% <ø> (ø)` | |
| [...rset-frontend/src/components/ProgressBar/index.tsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUHJvZ3Jlc3NCYXIvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [...ontend/src/components/URLShortLinkButton/index.jsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVVJMU2hvcnRMaW5rQnV0dG9uL2luZGV4LmpzeA==) | `100.00% <ø> (ø)` | |
| [.../components/CrossFilterScopingModal/utils/index.ts](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nyb3NzRmlsdGVyU2NvcGluZ01vZGFsL3V0aWxzL2luZGV4LnRz) | `100.00% <ø> (ø)` | |
| [...src/dashboard/components/PublishedStatus/index.jsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1B1Ymxpc2hlZFN0YXR1cy9pbmRleC5qc3g=) | `100.00% <ø> (ø)` | |
| [...src/dashboard/components/dnd/handleScroll/index.ts](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVTY3JvbGwvaW5kZXgudHM=) | `73.33% <ø> (ø)` | |
| ... and [167 more](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=footer). Last update [f81b746...e93f887](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #13946: fix: SQL -> Explore Overwrite flow
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #13946:
URL: https://github.com/apache/superset/pull/13946#issuecomment-813059916
# [Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=h1) Report
> Merging [#13946](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=desc) (756436a) into [master](https://codecov.io/gh/apache/superset/commit/9d0bb3a3ba38c2289d77e87dfe572c57c51ef7c7?el=desc) (9d0bb3a) will **increase** coverage by `0.51%`.
> The diff coverage is `71.42%`.
[](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13946 +/- ##
==========================================
+ Coverage 76.78% 77.29% +0.51%
==========================================
Files 935 935
Lines 47292 47292
Branches 5895 5896 +1
==========================================
+ Hits 36311 36554 +243
+ Misses 10824 10589 -235
+ Partials 157 149 -8
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `54.83% <100.00%> (+2.53%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/views/CRUD/alert/types.ts](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
| [superset/models/reports.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3JlcG9ydHMucHk=) | `100.00% <ø> (ø)` | |
| [superset/tasks/scheduler.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVyLnB5) | `0.00% <0.00%> (ø)` | |
| [.../src/explore/components/controls/SelectControl.jsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9TZWxlY3RDb250cm9sLmpzeA==) | `93.75% <100.00%> (+4.46%)` | :arrow_up: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `100.00% <100.00%> (ø)` | |
| [superset/datasets/api.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `91.44% <100.00%> (ø)` | |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `93.44% <100.00%> (ø)` | |
| [superset/reports/logs/api.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9sb2dzL2FwaS5weQ==) | `95.45% <100.00%> (ø)` | |
| [...rontend/src/views/CRUD/dashboard/DashboardList.tsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZExpc3QudHN4) | `75.22% <0.00%> (-5.31%)` | :arrow_down: |
| ... and [52 more](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=footer). Last update [f81b746...756436a](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13946: fix: SQL -> Explore Overwrite flow
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13946:
URL: https://github.com/apache/superset/pull/13946#issuecomment-813059916
# [Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=h1) Report
> Merging [#13946](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=desc) (e93f887) into [master](https://codecov.io/gh/apache/superset/commit/9d0bb3a3ba38c2289d77e87dfe572c57c51ef7c7?el=desc) (9d0bb3a) will **increase** coverage by `1.21%`.
> The diff coverage is `88.88%`.
[](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13946 +/- ##
==========================================
+ Coverage 76.78% 77.99% +1.21%
==========================================
Files 935 935
Lines 47292 49218 +1926
Branches 5895 5942 +47
==========================================
+ Hits 36311 38390 +2079
+ Misses 10824 10684 -140
+ Partials 157 144 -13
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.03% <100.00%> (+3.73%)` | :arrow_up: |
| hive | `80.81% <87.50%> (+0.52%)` | :arrow_up: |
| mysql | `80.60% <81.81%> (+<0.01%)` | :arrow_up: |
| postgres | `80.63% <81.81%> (+<0.01%)` | :arrow_up: |
| presto | `80.80% <87.50%> (+0.50%)` | :arrow_up: |
| python | `81.70% <87.50%> (+0.56%)` | :arrow_up: |
| sqlite | `80.20% <81.81%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/views/CRUD/alert/types.ts](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
| [superset/reports/logs/api.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9sb2dzL2FwaS5weQ==) | `95.45% <ø> (ø)` | |
| [superset/tasks/scheduler.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVyLnB5) | `0.00% <0.00%> (ø)` | |
| [.../src/explore/components/controls/SelectControl.jsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9TZWxlY3RDb250cm9sLmpzeA==) | `93.75% <100.00%> (+4.46%)` | :arrow_up: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `100.00% <100.00%> (ø)` | |
| [superset/datasets/api.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `91.51% <100.00%> (+0.07%)` | :arrow_up: |
| [superset/models/reports.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3JlcG9ydHMucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `95.40% <100.00%> (+1.96%)` | :arrow_up: |
| [superset/examples/big\_data.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlnX2RhdGEucHk=) | `29.62% <0.00%> (-3.71%)` | :arrow_down: |
| [superset/reports/notifications/base.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `94.11% <0.00%> (-1.54%)` | :arrow_down: |
| ... and [72 more](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=footer). Last update [f81b746...e93f887](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13946: fix: SQL -> Explore Overwrite flow
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13946:
URL: https://github.com/apache/superset/pull/13946#issuecomment-813059916
# [Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=h1) Report
> Merging [#13946](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=desc) (9ff89af) into [master](https://codecov.io/gh/apache/superset/commit/9d0bb3a3ba38c2289d77e87dfe572c57c51ef7c7?el=desc) (9d0bb3a) will **decrease** coverage by `0.34%`.
> The diff coverage is `79.04%`.
> :exclamation: Current head 9ff89af differs from pull request most recent head 06ec82b. Consider uploading reports for the commit 06ec82b to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13946 +/- ##
==========================================
- Coverage 76.78% 76.43% -0.35%
==========================================
Files 935 952 +17
Lines 47292 48494 +1202
Branches 5895 6280 +385
==========================================
+ Hits 36311 37068 +757
- Misses 10824 11282 +458
+ Partials 157 144 -13
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.03% <67.27%> (+3.72%)` | :arrow_up: |
| hive | `?` | |
| mysql | `80.56% <76.78%> (-0.04%)` | :arrow_down: |
| postgres | `80.60% <76.78%> (-0.04%)` | :arrow_down: |
| presto | `80.28% <82.14%> (-0.02%)` | :arrow_down: |
| python | `80.86% <83.03%> (-0.28%)` | :arrow_down: |
| sqlite | `80.16% <76.78%> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/SqlLab/components/ScheduleQueryButton.tsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NjaGVkdWxlUXVlcnlCdXR0b24udHN4) | `28.12% <ø> (ø)` | |
| [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `61.11% <0.00%> (-27.27%)` | :arrow_down: |
| [...et-frontend/src/components/CertifiedIcon/index.tsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbi9pbmRleC50c3g=) | `0.00% <0.00%> (ø)` | |
| [...frontend/src/components/Checkbox/CheckboxIcons.tsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hlY2tib3gvQ2hlY2tib3hJY29ucy50c3g=) | `83.33% <ø> (ø)` | |
| [...frontend/src/components/DatabaseSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YWJhc2VTZWxlY3Rvci9pbmRleC50c3g=) | `90.29% <ø> (-1.38%)` | :arrow_down: |
| [superset-frontend/src/components/Select/index.ts](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L2luZGV4LnRz) | `100.00% <ø> (ø)` | |
| [...ontend/src/components/URLShortLinkButton/index.jsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVVJMU2hvcnRMaW5rQnV0dG9uL2luZGV4LmpzeA==) | `100.00% <ø> (ø)` | |
| [.../components/CrossFilterScopingModal/utils/index.ts](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nyb3NzRmlsdGVyU2NvcGluZ01vZGFsL3V0aWxzL2luZGV4LnRz) | `33.33% <ø> (ø)` | |
| [...src/dashboard/components/PublishedStatus/index.jsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1B1Ymxpc2hlZFN0YXR1cy9pbmRleC5qc3g=) | `61.90% <ø> (ø)` | |
| [...src/dashboard/components/dnd/handleScroll/index.ts](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVTY3JvbGwvaW5kZXgudHM=) | `38.46% <ø> (ø)` | |
| ... and [169 more](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=footer). Last update [f81b746...06ec82b](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13946: fix: SQL -> Explore Overwrite flow
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13946:
URL: https://github.com/apache/superset/pull/13946#issuecomment-813059916
# [Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=h1) Report
> Merging [#13946](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=desc) (e93f887) into [master](https://codecov.io/gh/apache/superset/commit/9d0bb3a3ba38c2289d77e87dfe572c57c51ef7c7?el=desc) (9d0bb3a) will **increase** coverage by `0.09%`.
> The diff coverage is `84.61%`.
[](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13946 +/- ##
==========================================
+ Coverage 76.78% 76.87% +0.09%
==========================================
Files 935 952 +17
Lines 47292 48453 +1161
Branches 5895 6280 +385
==========================================
+ Hits 36311 37249 +938
- Misses 10824 11060 +236
+ Partials 157 144 -13
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `80.60% <81.81%> (+<0.01%)` | :arrow_up: |
| postgres | `80.63% <81.81%> (+<0.01%)` | :arrow_up: |
| presto | `?` | |
| python | `80.72% <81.81%> (-0.42%)` | :arrow_down: |
| sqlite | `80.20% <81.81%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/views/CRUD/alert/types.ts](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
| [superset/reports/logs/api.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9sb2dzL2FwaS5weQ==) | `95.45% <ø> (ø)` | |
| [superset/tasks/scheduler.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVyLnB5) | `0.00% <0.00%> (ø)` | |
| [.../src/explore/components/controls/SelectControl.jsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9TZWxlY3RDb250cm9sLmpzeA==) | `94.30% <100.00%> (+5.02%)` | :arrow_up: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `100.00% <100.00%> (ø)` | |
| [superset/datasets/api.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `91.51% <100.00%> (+0.07%)` | :arrow_up: |
| [superset/models/reports.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3JlcG9ydHMucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `93.58% <100.00%> (+0.14%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `61.11% <0.00%> (-27.27%)` | :arrow_down: |
| ... and [94 more](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=footer). Last update [f81b746...e93f887](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13946: fix: SQL -> Explore Overwrite flow
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13946:
URL: https://github.com/apache/superset/pull/13946#issuecomment-813059916
# [Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=h1) Report
> Merging [#13946](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=desc) (9ff89af) into [master](https://codecov.io/gh/apache/superset/commit/9d0bb3a3ba38c2289d77e87dfe572c57c51ef7c7?el=desc) (9d0bb3a) will **decrease** coverage by `0.43%`.
> The diff coverage is `75.71%`.
> :exclamation: Current head 9ff89af differs from pull request most recent head 06ec82b. Consider uploading reports for the commit 06ec82b to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13946 +/- ##
==========================================
- Coverage 76.78% 76.34% -0.44%
==========================================
Files 935 952 +17
Lines 47292 48494 +1202
Branches 5895 6280 +385
==========================================
+ Hits 36311 37021 +710
- Misses 10824 11329 +505
+ Partials 157 144 -13
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.03% <67.27%> (+3.72%)` | :arrow_up: |
| hive | `?` | |
| mysql | `80.56% <76.78%> (-0.04%)` | :arrow_down: |
| postgres | `80.60% <76.78%> (-0.04%)` | :arrow_down: |
| presto | `?` | |
| python | `80.68% <76.78%> (-0.46%)` | :arrow_down: |
| sqlite | `80.16% <76.78%> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/SqlLab/components/ScheduleQueryButton.tsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NjaGVkdWxlUXVlcnlCdXR0b24udHN4) | `28.12% <ø> (ø)` | |
| [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `61.11% <0.00%> (-27.27%)` | :arrow_down: |
| [...et-frontend/src/components/CertifiedIcon/index.tsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbi9pbmRleC50c3g=) | `0.00% <0.00%> (ø)` | |
| [...frontend/src/components/Checkbox/CheckboxIcons.tsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hlY2tib3gvQ2hlY2tib3hJY29ucy50c3g=) | `83.33% <ø> (ø)` | |
| [...frontend/src/components/DatabaseSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YWJhc2VTZWxlY3Rvci9pbmRleC50c3g=) | `90.29% <ø> (-1.38%)` | :arrow_down: |
| [superset-frontend/src/components/Select/index.ts](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L2luZGV4LnRz) | `100.00% <ø> (ø)` | |
| [...ontend/src/components/URLShortLinkButton/index.jsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVVJMU2hvcnRMaW5rQnV0dG9uL2luZGV4LmpzeA==) | `100.00% <ø> (ø)` | |
| [.../components/CrossFilterScopingModal/utils/index.ts](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nyb3NzRmlsdGVyU2NvcGluZ01vZGFsL3V0aWxzL2luZGV4LnRz) | `33.33% <ø> (ø)` | |
| [...src/dashboard/components/PublishedStatus/index.jsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1B1Ymxpc2hlZFN0YXR1cy9pbmRleC5qc3g=) | `61.90% <ø> (ø)` | |
| [...src/dashboard/components/dnd/handleScroll/index.ts](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVTY3JvbGwvaW5kZXgudHM=) | `38.46% <ø> (ø)` | |
| ... and [174 more](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=footer). Last update [f81b746...06ec82b](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13946: fix: SQL -> Explore Overwrite flow
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13946:
URL: https://github.com/apache/superset/pull/13946#issuecomment-813059916
# [Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=h1) Report
> Merging [#13946](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=desc) (756436a) into [master](https://codecov.io/gh/apache/superset/commit/9d0bb3a3ba38c2289d77e87dfe572c57c51ef7c7?el=desc) (9d0bb3a) will **increase** coverage by `0.22%`.
> The diff coverage is `71.42%`.
[](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13946 +/- ##
==========================================
+ Coverage 76.78% 77.00% +0.22%
==========================================
Files 935 952 +17
Lines 47292 48443 +1151
Branches 5895 6270 +375
==========================================
+ Hits 36311 37304 +993
- Misses 10824 10995 +171
+ Partials 157 144 -13
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `55.97% <100.00%> (+3.67%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/views/CRUD/alert/types.ts](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
| [superset/models/reports.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3JlcG9ydHMucHk=) | `100.00% <ø> (ø)` | |
| [superset/tasks/scheduler.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVyLnB5) | `0.00% <0.00%> (ø)` | |
| [.../src/explore/components/controls/SelectControl.jsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9TZWxlY3RDb250cm9sLmpzeA==) | `94.30% <100.00%> (+5.02%)` | :arrow_up: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `100.00% <100.00%> (ø)` | |
| [superset/datasets/api.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `91.44% <100.00%> (ø)` | |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `93.44% <100.00%> (ø)` | |
| [superset/reports/logs/api.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9sb2dzL2FwaS5weQ==) | `95.45% <100.00%> (ø)` | |
| [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `61.11% <0.00%> (-27.27%)` | :arrow_down: |
| [...rset-frontend/src/components/ProgressBar/index.tsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUHJvZ3Jlc3NCYXIvaW5kZXgudHN4) | `76.92% <0.00%> (-23.08%)` | :arrow_down: |
| ... and [94 more](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=footer). Last update [f81b746...756436a](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13946: fix: SQL -> Explore Overwrite flow
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13946:
URL: https://github.com/apache/superset/pull/13946#issuecomment-813059916
# [Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=h1) Report
> Merging [#13946](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=desc) (e93f887) into [master](https://codecov.io/gh/apache/superset/commit/9d0bb3a3ba38c2289d77e87dfe572c57c51ef7c7?el=desc) (9d0bb3a) will **increase** coverage by `0.54%`.
> The diff coverage is `84.61%`.
[](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13946 +/- ##
==========================================
+ Coverage 76.78% 77.32% +0.54%
==========================================
Files 935 935
Lines 47292 47302 +10
Branches 5895 5942 +47
==========================================
+ Hits 36311 36575 +264
+ Misses 10824 10583 -241
+ Partials 157 144 -13
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.03% <100.00%> (+3.72%)` | :arrow_up: |
| hive | `?` | |
| mysql | `80.60% <81.81%> (+<0.01%)` | :arrow_up: |
| postgres | `80.63% <81.81%> (+<0.01%)` | :arrow_up: |
| presto | `?` | |
| python | `80.72% <81.81%> (-0.42%)` | :arrow_down: |
| sqlite | `80.20% <81.81%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/views/CRUD/alert/types.ts](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
| [superset/reports/logs/api.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9sb2dzL2FwaS5weQ==) | `95.45% <ø> (ø)` | |
| [superset/tasks/scheduler.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVyLnB5) | `0.00% <0.00%> (ø)` | |
| [.../src/explore/components/controls/SelectControl.jsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9TZWxlY3RDb250cm9sLmpzeA==) | `93.75% <100.00%> (+4.46%)` | :arrow_up: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `100.00% <100.00%> (ø)` | |
| [superset/datasets/api.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `91.51% <100.00%> (+0.07%)` | :arrow_up: |
| [superset/models/reports.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3JlcG9ydHMucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `93.58% <100.00%> (+0.14%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.23% <0.00%> (-16.54%)` | :arrow_down: |
| ... and [66 more](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=footer). Last update [f81b746...e93f887](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13946: fix: SQL -> Explore Overwrite flow
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13946:
URL: https://github.com/apache/superset/pull/13946#issuecomment-813059916
# [Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=h1) Report
> Merging [#13946](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=desc) (e93f887) into [master](https://codecov.io/gh/apache/superset/commit/9d0bb3a3ba38c2289d77e87dfe572c57c51ef7c7?el=desc) (9d0bb3a) will **decrease** coverage by `0.89%`.
> The diff coverage is `84.61%`.
[](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13946 +/- ##
==========================================
- Coverage 76.78% 75.88% -0.90%
==========================================
Files 935 935
Lines 47292 47300 +8
Branches 5895 5942 +47
==========================================
- Hits 36311 35893 -418
- Misses 10824 11245 +421
- Partials 157 162 +5
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `51.63% <100.00%> (-0.67%)` | :arrow_down: |
| hive | `?` | |
| mysql | `80.60% <81.81%> (+<0.01%)` | :arrow_up: |
| postgres | `80.63% <81.81%> (+<0.01%)` | :arrow_up: |
| presto | `?` | |
| python | `80.72% <81.81%> (-0.42%)` | :arrow_down: |
| sqlite | `80.20% <81.81%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/views/CRUD/alert/types.ts](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
| [superset/reports/logs/api.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9sb2dzL2FwaS5weQ==) | `95.45% <ø> (ø)` | |
| [superset/tasks/scheduler.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVyLnB5) | `0.00% <0.00%> (ø)` | |
| [.../src/explore/components/controls/SelectControl.jsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9TZWxlY3RDb250cm9sLmpzeA==) | `93.75% <100.00%> (+4.46%)` | :arrow_up: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `100.00% <100.00%> (ø)` | |
| [superset/datasets/api.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `91.51% <100.00%> (+0.07%)` | :arrow_up: |
| [superset/models/reports.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3JlcG9ydHMucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `93.58% <100.00%> (+0.14%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ponents/Select/WindowedSelect/WindowedMenuList.tsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1dpbmRvd2VkU2VsZWN0L1dpbmRvd2VkTWVudUxpc3QudHN4) | `10.71% <0.00%> (-85.72%)` | :arrow_down: |
| ... and [104 more](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=footer). Last update [f81b746...e93f887](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #13946: fix: SQL -> Explore Overwrite flow
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13946:
URL: https://github.com/apache/superset/pull/13946#issuecomment-813087378
@hughhhh Ephemeral environment spinning up at http://54.244.15.59:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] hughhhh merged pull request #13946: fix: SQL -> Explore Overwrite flow
Posted by GitBox <gi...@apache.org>.
hughhhh merged pull request #13946:
URL: https://github.com/apache/superset/pull/13946
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13946: fix: SQL -> Explore Overwrite flow
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13946:
URL: https://github.com/apache/superset/pull/13946#issuecomment-813059916
# [Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=h1) Report
> Merging [#13946](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=desc) (e93f887) into [master](https://codecov.io/gh/apache/superset/commit/9d0bb3a3ba38c2289d77e87dfe572c57c51ef7c7?el=desc) (9d0bb3a) will **increase** coverage by `1.21%`.
> The diff coverage is `88.88%`.
> :exclamation: Current head e93f887 differs from pull request most recent head 06ec82b. Consider uploading reports for the commit 06ec82b to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13946 +/- ##
==========================================
+ Coverage 76.78% 77.99% +1.21%
==========================================
Files 935 935
Lines 47292 49218 +1926
Branches 5895 5942 +47
==========================================
+ Hits 36311 38390 +2079
+ Misses 10824 10684 -140
+ Partials 157 144 -13
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.03% <100.00%> (+3.73%)` | :arrow_up: |
| hive | `80.81% <87.50%> (+0.52%)` | :arrow_up: |
| mysql | `80.60% <81.81%> (+<0.01%)` | :arrow_up: |
| postgres | `80.63% <81.81%> (+<0.01%)` | :arrow_up: |
| presto | `80.80% <87.50%> (+0.50%)` | :arrow_up: |
| python | `81.70% <87.50%> (+0.56%)` | :arrow_up: |
| sqlite | `80.20% <81.81%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/views/CRUD/alert/types.ts](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
| [superset/reports/logs/api.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9sb2dzL2FwaS5weQ==) | `95.45% <ø> (ø)` | |
| [superset/tasks/scheduler.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVyLnB5) | `0.00% <0.00%> (ø)` | |
| [.../src/explore/components/controls/SelectControl.jsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9TZWxlY3RDb250cm9sLmpzeA==) | `93.75% <100.00%> (+4.46%)` | :arrow_up: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `100.00% <100.00%> (ø)` | |
| [superset/datasets/api.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `91.51% <100.00%> (+0.07%)` | :arrow_up: |
| [superset/models/reports.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3JlcG9ydHMucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `95.40% <100.00%> (+1.96%)` | :arrow_up: |
| [superset/examples/big\_data.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlnX2RhdGEucHk=) | `29.62% <0.00%> (-3.71%)` | :arrow_down: |
| [superset/reports/notifications/base.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `94.11% <0.00%> (-1.54%)` | :arrow_down: |
| ... and [72 more](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=footer). Last update [f81b746...06ec82b](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13946: fix: SQL -> Explore Overwrite flow
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13946:
URL: https://github.com/apache/superset/pull/13946#issuecomment-813059916
# [Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=h1) Report
> Merging [#13946](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=desc) (9ff89af) into [master](https://codecov.io/gh/apache/superset/commit/9d0bb3a3ba38c2289d77e87dfe572c57c51ef7c7?el=desc) (9d0bb3a) will **increase** coverage by `0.24%`.
> The diff coverage is `78.08%`.
> :exclamation: Current head 9ff89af differs from pull request most recent head 06ec82b. Consider uploading reports for the commit 06ec82b to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13946 +/- ##
==========================================
+ Coverage 76.78% 77.02% +0.24%
==========================================
Files 935 935
Lines 47292 47318 +26
Branches 5895 5942 +47
==========================================
+ Hits 36311 36448 +137
+ Misses 10824 10726 -98
+ Partials 157 144 -13
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `80.16% <76.78%> (-0.98%)` | :arrow_down: |
| sqlite | `80.16% <76.78%> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/SqlLab/components/ScheduleQueryButton.tsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NjaGVkdWxlUXVlcnlCdXR0b24udHN4) | `28.12% <ø> (ø)` | |
| [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `88.37% <0.00%> (ø)` | |
| [...frontend/src/components/DatabaseSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YWJhc2VTZWxlY3Rvci9pbmRleC50c3g=) | `91.66% <ø> (ø)` | |
| [superset-frontend/src/components/Select/index.ts](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L2luZGV4LnRz) | `100.00% <ø> (ø)` | |
| [...ontend/src/components/URLShortLinkButton/index.jsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVVJMU2hvcnRMaW5rQnV0dG9uL2luZGV4LmpzeA==) | `100.00% <ø> (ø)` | |
| [...src/dashboard/components/filterscope/treeIcons.jsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL3RyZWVJY29ucy5qc3g=) | `100.00% <ø> (ø)` | |
| [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | `65.82% <0.00%> (ø)` | |
| [...rontend/src/explore/components/EmbedCodeButton.jsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FbWJlZENvZGVCdXR0b24uanN4) | `80.76% <ø> (ø)` | |
| [...explore/components/controls/ColorPickerControl.jsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db2xvclBpY2tlckNvbnRyb2wuanN4) | `85.00% <ø> (ø)` | |
| [...controls/DndColumnSelectControl/DndSelectLabel.tsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZFNlbGVjdExhYmVsLnRzeA==) | `35.00% <ø> (ø)` | |
| ... and [162 more](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=footer). Last update [f81b746...06ec82b](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] hughhhh commented on a change in pull request #13946: fix: SQL -> Explore Overwrite flow
Posted by GitBox <gi...@apache.org>.
hughhhh commented on a change in pull request #13946:
URL: https://github.com/apache/superset/pull/13946#discussion_r607263290
##########
File path: tests/datasets/api_tests.py
##########
@@ -598,12 +598,7 @@ def test_update_dataset_item_w_override_columns(self):
rv = self.put_assert_metric(uri, dataset_data, "put")
assert rv.status_code == 200
- columns = (
- db.session.query(TableColumn)
- .filter_by(table_id=dataset.id)
- .order_by("column_name")
- .all()
- )
+ columns = db.session.query(TableColumn).filter_by(table_id=dataset.id).all()
Review comment:
yea, now with the refresh the new column appears in the front of the array. So that is why I removed the order by
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13946: fix: SQL -> Explore Overwrite flow
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13946:
URL: https://github.com/apache/superset/pull/13946#issuecomment-813059916
# [Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=h1) Report
> Merging [#13946](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=desc) (9ff89af) into [master](https://codecov.io/gh/apache/superset/commit/9d0bb3a3ba38c2289d77e87dfe572c57c51ef7c7?el=desc) (9d0bb3a) will **increase** coverage by `0.52%`.
> The diff coverage is `78.08%`.
> :exclamation: Current head 9ff89af differs from pull request most recent head 06ec82b. Consider uploading reports for the commit 06ec82b to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13946 +/- ##
==========================================
+ Coverage 76.78% 77.30% +0.52%
==========================================
Files 935 935
Lines 47292 47345 +53
Branches 5895 5942 +47
==========================================
+ Hits 36311 36601 +290
+ Misses 10824 10600 -224
+ Partials 157 144 -13
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `80.56% <76.78%> (-0.04%)` | :arrow_down: |
| postgres | `80.60% <76.78%> (-0.04%)` | :arrow_down: |
| presto | `?` | |
| python | `80.68% <76.78%> (-0.46%)` | :arrow_down: |
| sqlite | `80.16% <76.78%> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/SqlLab/components/ScheduleQueryButton.tsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NjaGVkdWxlUXVlcnlCdXR0b24udHN4) | `28.12% <ø> (ø)` | |
| [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `88.37% <0.00%> (ø)` | |
| [...frontend/src/components/DatabaseSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YWJhc2VTZWxlY3Rvci9pbmRleC50c3g=) | `91.66% <ø> (ø)` | |
| [superset-frontend/src/components/Select/index.ts](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L2luZGV4LnRz) | `100.00% <ø> (ø)` | |
| [...ontend/src/components/URLShortLinkButton/index.jsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVVJMU2hvcnRMaW5rQnV0dG9uL2luZGV4LmpzeA==) | `100.00% <ø> (ø)` | |
| [...src/dashboard/components/filterscope/treeIcons.jsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL3RyZWVJY29ucy5qc3g=) | `100.00% <ø> (ø)` | |
| [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | `65.82% <0.00%> (ø)` | |
| [...rontend/src/explore/components/EmbedCodeButton.jsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FbWJlZENvZGVCdXR0b24uanN4) | `80.76% <ø> (ø)` | |
| [...explore/components/controls/ColorPickerControl.jsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db2xvclBpY2tlckNvbnRyb2wuanN4) | `85.00% <ø> (ø)` | |
| [...controls/DndColumnSelectControl/DndSelectLabel.tsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZFNlbGVjdExhYmVsLnRzeA==) | `35.00% <ø> (ø)` | |
| ... and [139 more](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=footer). Last update [f81b746...06ec82b](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13946: fix: SQL -> Explore Overwrite flow
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13946:
URL: https://github.com/apache/superset/pull/13946#issuecomment-813059916
# [Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=h1) Report
> Merging [#13946](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=desc) (61e7196) into [master](https://codecov.io/gh/apache/superset/commit/9d0bb3a3ba38c2289d77e87dfe572c57c51ef7c7?el=desc) (9d0bb3a) will **increase** coverage by `1.28%`.
> The diff coverage is `82.60%`.
> :exclamation: Current head 61e7196 differs from pull request most recent head e93f887. Consider uploading reports for the commit e93f887 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13946 +/- ##
==========================================
+ Coverage 76.78% 78.06% +1.28%
==========================================
Files 935 934 -1
Lines 47292 47352 +60
Branches 5895 5952 +57
==========================================
+ Hits 36311 36966 +655
+ Misses 10824 10242 -582
+ Partials 157 144 -13
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `80.60% <76.78%> (-0.04%)` | :arrow_down: |
| presto | `?` | |
| python | `80.60% <76.78%> (-0.54%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/SqlLab/components/ScheduleQueryButton.tsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NjaGVkdWxlUXVlcnlCdXR0b24udHN4) | `28.12% <ø> (ø)` | |
| [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `88.60% <ø> (+0.23%)` | :arrow_up: |
| [...frontend/src/components/Checkbox/CheckboxIcons.tsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hlY2tib3gvQ2hlY2tib3hJY29ucy50c3g=) | `85.71% <ø> (ø)` | |
| [...frontend/src/components/DatabaseSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YWJhc2VTZWxlY3Rvci9pbmRleC50c3g=) | `92.70% <ø> (+1.04%)` | :arrow_up: |
| [superset-frontend/src/components/Icon/index.tsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbi9pbmRleC50c3g=) | `100.00% <ø> (ø)` | |
| [...rset-frontend/src/components/ProgressBar/index.tsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUHJvZ3Jlc3NCYXIvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [...ontend/src/components/URLShortLinkButton/index.jsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVVJMU2hvcnRMaW5rQnV0dG9uL2luZGV4LmpzeA==) | `100.00% <ø> (ø)` | |
| [.../components/CrossFilterScopingModal/utils/index.ts](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nyb3NzRmlsdGVyU2NvcGluZ01vZGFsL3V0aWxzL2luZGV4LnRz) | `100.00% <ø> (ø)` | |
| [...src/dashboard/components/PublishedStatus/index.jsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1B1Ymxpc2hlZFN0YXR1cy9pbmRleC5qc3g=) | `100.00% <ø> (ø)` | |
| [...src/dashboard/components/dnd/handleScroll/index.ts](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVTY3JvbGwvaW5kZXgudHM=) | `73.33% <ø> (ø)` | |
| ... and [168 more](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=footer). Last update [f81b746...e93f887](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13946: fix: SQL -> Explore Overwrite flow
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13946:
URL: https://github.com/apache/superset/pull/13946#issuecomment-813059916
# [Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=h1) Report
> Merging [#13946](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=desc) (e93f887) into [master](https://codecov.io/gh/apache/superset/commit/9d0bb3a3ba38c2289d77e87dfe572c57c51ef7c7?el=desc) (9d0bb3a) will **increase** coverage by `0.54%`.
> The diff coverage is `84.61%`.
[](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13946 +/- ##
==========================================
+ Coverage 76.78% 77.32% +0.54%
==========================================
Files 935 935
Lines 47292 47302 +10
Branches 5895 5942 +47
==========================================
+ Hits 36311 36576 +265
+ Misses 10824 10582 -242
+ Partials 157 144 -13
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.03% <100.00%> (+3.73%)` | :arrow_up: |
| hive | `?` | |
| mysql | `80.60% <81.81%> (+<0.01%)` | :arrow_up: |
| postgres | `80.63% <81.81%> (+<0.01%)` | :arrow_up: |
| presto | `?` | |
| python | `80.72% <81.81%> (-0.42%)` | :arrow_down: |
| sqlite | `80.20% <81.81%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/views/CRUD/alert/types.ts](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
| [superset/reports/logs/api.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9sb2dzL2FwaS5weQ==) | `95.45% <ø> (ø)` | |
| [superset/tasks/scheduler.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVyLnB5) | `0.00% <0.00%> (ø)` | |
| [.../src/explore/components/controls/SelectControl.jsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9TZWxlY3RDb250cm9sLmpzeA==) | `93.75% <100.00%> (+4.46%)` | :arrow_up: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `100.00% <100.00%> (ø)` | |
| [superset/datasets/api.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `91.51% <100.00%> (+0.07%)` | :arrow_up: |
| [superset/models/reports.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3JlcG9ydHMucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `93.58% <100.00%> (+0.14%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.23% <0.00%> (-16.54%)` | :arrow_down: |
| ... and [66 more](https://codecov.io/gh/apache/superset/pull/13946/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=footer). Last update [f81b746...e93f887](https://codecov.io/gh/apache/superset/pull/13946?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org