You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bloodhound.apache.org by Apache Bloodhound <bl...@incubator.apache.org> on 2013/03/11 04:01:32 UTC

[Apache Bloodhound] #456: Toggling the 'Edit side-by-side' checkbox doesn't instantly update the edit mode

#456: Toggling the 'Edit side-by-side' checkbox doesn't instantly update the edit
mode
-----------------------+-----------------------
 Reporter:  rjollos    |      Owner:  rjollos
     Type:  defect     |     Status:  new
 Priority:  major      |  Milestone:  Release 5
Component:  ui design  |    Version:
 Keywords:             |
-----------------------+-----------------------
 In Trac, toggling the ''Edit side-by-side'' checkbox on the Wiki Edit page
 instantly updates the edit mode, but in Bloodhound, the ''Preview'' button
 must be pressed.

 I'm setting this as a ''defect'' since it seems to be a regression against
 the functionality available in Trac.

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/456>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #456: Toggling the 'Edit side-by-side' checkbox doesn't instantly update the edit mode

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#456: Toggling the 'Edit side-by-side' checkbox doesn't instantly update the edit
mode
------------------------+------------------------
  Reporter:  rjollos    |      Owner:  rjollos
      Type:  defect     |     Status:  new
  Priority:  major      |  Milestone:  Release 5
 Component:  ui design  |    Version:
Resolution:             |   Keywords:  trac-1.0.0
------------------------+------------------------
Changes (by rjollos):

 * keywords:   => trac-1.0.0


Comment:

 There was some work done to fix side-by-side edit mode in r1335445/#41
 (2012-05-08). It looks like the `bh_wiki_edit.html` template was committed
 in that revision, and it hasn't been changed much since. Importantly, none
 of the !JavaScript has been updated to account for changes in Trac (see
 [http://trac.edgewall.org/browser/trunk/trac/wiki/templates/wiki_edit.html?rev=11277&annotate=blame
 blame] for `wiki_edit.html`). So this amounts to more work towards #453.
 The specific feature of toggling between ''side-by-side'' edit mode was
 implemented in [trac 11010].

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/456#comment:1>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #456: Toggling the 'Edit side-by-side' checkbox doesn't instantly update the edit mode

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#456: Toggling the 'Edit side-by-side' checkbox doesn't instantly update the edit
mode
------------------------+------------------------
  Reporter:  rjollos    |      Owner:  rjollos
      Type:  defect     |     Status:  closed
  Priority:  major      |  Milestone:  Release 5
 Component:  ui design  |    Version:
Resolution:  fixed      |   Keywords:  trac-1.0.0
------------------------+------------------------
Changes (by rjollos):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 (In [1455006])

 Fixes #456:
  * Copied JS code contained within the `script` elements of the
 `wiki_edit` template to `bh_wiki_edit` (​[trac 11109], ​[trac 11110]),
 providing the functionality to automatically refresh the page when
 toggling the ''Edit side-by-side'' checkbox and resize the text area
 relative to the preview.
  * Hide the navigation controls when in side-by-side edit mode. Removed
 some navigation controls that had also been removed in Trac.
  * Adjusted the size of the ''Adjust edit area height'' select box.

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/456#comment:2>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker