[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #5289: GEODE-8295: refactor GeodeRedisServer

[GitBox <gi...@apache.org>]

jdeppe-pivotal commented on a change in pull request #5289:
URL: https://github.com/apache/geode/pull/5289#discussion_r445582180



##########
File path: geode-redis/src/main/java/org/apache/geode/redis/internal/GeodeRedisService.java
##########
@@ -77,7 +78,7 @@ private void startRedisServer(InternalCache cache) {
           String.format("Starting GeodeRedisServer on bind address %s on port %s",

Review comment:
       Since you're working on this, could you move the log message after the start so that we log the actual port used in the event that it is started on an ephemeral port. (Otherwise it just says `Starting... on port 0`).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org