You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "GreatEugenius (via GitHub)" <gi...@apache.org> on 2025/11/27 07:07:20 UTC
[PR] [hotfix] Fix the type loss issue in agent plan deserialization [flink-agents]
GreatEugenius opened a new pull request, #343:
URL: https://github.com/apache/flink-agents/pull/343
### Purpose of change
Fix the type loss issue in agent plan deserialization and correct the improper use of the descriptor.
<!-- What is the purpose of this change? -->
### Tests
ut
<!-- How is this change verified? -->
### API
<!-- Does this change touches any public APIs? -->
### Documentation
The commit already includes the changes to the Docs.
<!-- Do not remove this section. Check the proper box only. -->
- [ ] `doc-needed` <!-- Your PR changes impact docs -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] Fix the type loss issue in the deserialization of ResourceProvider [flink-agents]
Posted by "wenjin272 (via GitHub)" <gi...@apache.org>.
wenjin272 commented on PR #343:
URL: https://github.com/apache/flink-agents/pull/343#issuecomment-3588092848
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] Fix the type loss issue in agent plan deserialization [flink-agents]
Posted by "GreatEugenius (via GitHub)" <gi...@apache.org>.
GreatEugenius commented on PR #343:
URL: https://github.com/apache/flink-agents/pull/343#issuecomment-3584473679
Hi, @Sxnan and @wenjin272, please take a look at this PR. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] Fix the type loss issue in the deserialization of ResourceProvider [flink-agents]
Posted by "Sxnan (via GitHub)" <gi...@apache.org>.
Sxnan commented on code in PR #343:
URL: https://github.com/apache/flink-agents/pull/343#discussion_r2597441665
##########
plan/src/main/java/org/apache/flink/agents/plan/serializer/ResourceProviderJsonDeserializer.java:
##########
@@ -82,7 +82,7 @@ private PythonResourceProvider deserializePythonResourceProvider(JsonNode node)
JsonNode kwargsNode = node.get("kwargs");
Map<String, Object> kwargs = new HashMap<>();
if (kwargsNode != null && kwargsNode.isObject()) {
- kwargs = (Map<String, Object>) parseJsonNode(kwargsNode);
Review Comment:
Can we remove the `parseJsonNode` method, as it is not used anymore?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] Fix the type loss issue in the deserialization of ResourceProvider [flink-agents]
Posted by "GreatEugenius (via GitHub)" <gi...@apache.org>.
GreatEugenius commented on PR #343:
URL: https://github.com/apache/flink-agents/pull/343#issuecomment-3625933422
Hi @Sxnan, thank you for the review! I have updated this PR; please review it again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] Fix the type loss issue in the deserialization of ResourceProvider [flink-agents]
Posted by "wenjin272 (via GitHub)" <gi...@apache.org>.
wenjin272 commented on PR #343:
URL: https://github.com/apache/flink-agents/pull/343#issuecomment-3585225374
What result will the type loss cause?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] Fix the type loss issue in the deserialization of ResourceProvider [flink-agents]
Posted by "Sxnan (via GitHub)" <gi...@apache.org>.
Sxnan merged PR #343:
URL: https://github.com/apache/flink-agents/pull/343
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] Fix the type loss issue in the deserialization of ResourceProvider [flink-agents]
Posted by "GreatEugenius (via GitHub)" <gi...@apache.org>.
GreatEugenius commented on PR #343:
URL: https://github.com/apache/flink-agents/pull/343#issuecomment-3585273177
> What result will the type loss cause?
Currently, it does not affect user usage because a forced type conversion has been performed on the Python side through the Base model. However, to support cross-language features, we need to address this issue first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org