[GitHub] [commons-collections] garydgregory commented on a change in pull request #126: Improve MapUtils with the null checks, add JUnit for it and add Javadoc for the parameter indent.

[GitBox <gi...@apache.org>]

garydgregory commented on a change in pull request #126: Improve MapUtils with the null checks, add JUnit for it and add Javadoc for the parameter indent.
URL: https://github.com/apache/commons-collections/pull/126#discussion_r356082643
 
 

 ##########
 File path: src/test/java/org/apache/commons/collections4/MapUtilsTest.java
 ##########
 @@ -159,6 +159,17 @@ public void testInvertMap() {
         assertEquals( "3", out.get("C"));
         assertEquals( "4", out.get("D"));
         assertEquals( "5", out.get("E"));
+
 
 Review comment:
   I would put this in a new method `testInvertMapNull` or something like that, this will give us better granularity in test code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services