You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by GitBox <gi...@apache.org> on 2021/11/13 06:01:37 UTC
[GitHub] [datasketches-memory] leerho opened a new pull request #155: Jdk17 panama
leerho opened a new pull request #155:
URL: https://github.com/apache/datasketches-memory/pull/155
This PR makes Memory compatible with JDK8 through JDK17. Some cleanup still needs to be done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-memory] leerho commented on a change in pull request #155: Jdk17 panama
Posted by GitBox <gi...@apache.org>.
leerho commented on a change in pull request #155:
URL: https://github.com/apache/datasketches-memory/pull/155#discussion_r750595453
##########
File path: datasketches-memory-java9/src/main/java/module-info.java
##########
@@ -22,5 +22,5 @@
requires java.logging;
requires jdk.unsupported;
- exports org.apache.datasketches.memory;
+ exports org.apache.datasketches.memory.internal;
Review comment:
The problem is that exporting org.apache.datasketches.memory throws an error because that package under java9 is empty. We would have to insert either a dummy class or duplicate some class from java8 just so that it is not empty.
I changed it to -.internal to eliminate the error. Perhaps the answer is to eliminate the export entirely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-memory] leerho commented on a change in pull request #155: Jdk17 panama
Posted by GitBox <gi...@apache.org>.
leerho commented on a change in pull request #155:
URL: https://github.com/apache/datasketches-memory/pull/155#discussion_r750807513
##########
File path: datasketches-memory-java9/src/main/java/module-info.java
##########
@@ -22,5 +22,5 @@
requires java.logging;
requires jdk.unsupported;
- exports org.apache.datasketches.memory;
+ exports org.apache.datasketches.memory.internal;
Review comment:
That sounds fine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-memory] leerho commented on pull request #155: Jdk17 panama
Posted by GitBox <gi...@apache.org>.
leerho commented on pull request #155:
URL: https://github.com/apache/datasketches-memory/pull/155#issuecomment-967791585
This job fails with a weird error:
Hello, Does anyone understand what is causing this error message:
> Non-resolvable parent POM for org.apache.datasketches:datasketches-memory-root:2.1.0-SNAPSHOT: Could not transfer artifact org.apache:apache:pom:23 from/to central (https://repo.maven.apache.org/maven2): transfer failed for https://repo.maven.apache.org/maven2/org/apache/apache/23/apache-23.pom and ‘parent.relativePath’ points at wrong local POM @ line 27, column 11: sun.security.validator.ValidatorException: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target -> [Help 2]
I have posted this to `asfinfra`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-memory] davecromberge commented on a change in pull request #155: Jdk17 panama
Posted by GitBox <gi...@apache.org>.
davecromberge commented on a change in pull request #155:
URL: https://github.com/apache/datasketches-memory/pull/155#discussion_r750463181
##########
File path: datasketches-memory-java9/src/main/java/module-info.java
##########
@@ -22,5 +22,5 @@
requires java.logging;
requires jdk.unsupported;
- exports org.apache.datasketches.memory;
+ exports org.apache.datasketches.memory.internal;
Review comment:
I think this should stay as it was, since we do not wish to expose internals to users but rather the public facing api package instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-memory] davecromberge commented on a change in pull request #155: Jdk17 panama
Posted by GitBox <gi...@apache.org>.
davecromberge commented on a change in pull request #155:
URL: https://github.com/apache/datasketches-memory/pull/155#discussion_r750601691
##########
File path: datasketches-memory-java9/src/main/java/module-info.java
##########
@@ -22,5 +22,5 @@
requires java.logging;
requires jdk.unsupported;
- exports org.apache.datasketches.memory;
+ exports org.apache.datasketches.memory.internal;
Review comment:
The approach that is in the master branch uses the `Map` implementation which is identical for the reasons that you describe. Do you know how a JPMS module with no export behaves? Is everything visible by default?
I think we should retain the dummy `Map` implementation to preserve the structure. I used Map originally because there are not many LoC being duplicated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org