You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by "corentin-soriano (via GitHub)" <gi...@apache.org> on 2025/01/26 15:23:50 UTC
[PR] GUACAMOLE-2025: Add a button to close the recording video player. [guacamole-client]
corentin-soriano opened a new pull request, #1055:
URL: https://github.com/apache/guacamole-client/pull/1055
Currently the only way to close the recording video player is to use the browser's "back" button.
Add a button that automatically hides with the control bar:

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-2025: Add a button to close the recording video player. [guacamole-client]
Posted by "corentin-soriano (via GitHub)" <gi...@apache.org>.
corentin-soriano commented on code in PR #1055:
URL: https://github.com/apache/guacamole-client/pull/1055#discussion_r2035835846
##########
guacamole/src/main/frontend/src/app/player/styles/player.css:
##########
@@ -113,6 +114,31 @@ guac-player .guac-player-controls {
align-items: center;
}
+.guac-player-controls .guac-player-close {
+ background: transparent;
+ border: 0;
+ box-shadow: none;
+ margin: 0;
+ min-width: 0;
+ padding: 0;
+ position: fixed;
+ right: 0;
+ top: 0;
+}
Review Comment:
z-index needs to be fixed so that it does not go over the fullscreen button:

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-2025: Add a button to close the recording video player. [guacamole-client]
Posted by "necouchman (via GitHub)" <gi...@apache.org>.
necouchman merged PR #1055:
URL: https://github.com/apache/guacamole-client/pull/1055
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-2025: Add a button to close the recording video player. [guacamole-client]
Posted by "corentin-soriano (via GitHub)" <gi...@apache.org>.
corentin-soriano commented on code in PR #1055:
URL: https://github.com/apache/guacamole-client/pull/1055#discussion_r2132042474
##########
guacamole/src/main/frontend/src/app/player/styles/player.css:
##########
@@ -113,6 +114,31 @@ guac-player .guac-player-controls {
align-items: center;
}
+.guac-player-controls .guac-player-close {
+ background: transparent;
+ border: 0;
+ box-shadow: none;
+ margin: 0;
+ min-width: 0;
+ padding: 0;
+ position: fixed;
+ right: 0;
+ top: 0;
+}
Review Comment:
Size adjusted so that the close button is always visible:

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org