You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Ralf Hauser (JIRA)" <ji...@apache.org> on 2007/10/10 05:32:37 UTC
[jira] Created: (STR-3105) add an optional tag
add an optional <logic:else> tag
--------------------------------
Key: STR-3105
URL: https://issues.apache.org/struts/browse/STR-3105
Project: Struts 1
Issue Type: New Feature
Components: Taglibs
Affects Versions: 1.3.8
Environment: any
Reporter: Ralf Hauser
Very often, I find myself having a
<logic:equal .... true
.... positive
</logic:equal
followed by a
<logic:notEqual .... true
.... negative
</logic:notEqual
These are maintenance imponderables because in nested settings, you risk to loose oversight if you change one of the statements to also change the other one.
If there were a <logic:else>
the above statement could be reduced to
<logic:equal .... true>
.... positive ...
</logic:else>
.... negative ...
</logic:equal>
and only ONE condition is to be maintained
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (STR-3105) Document how to migrate tags to
JSTL
Posted by "Paul Benedict (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/STR-3105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Benedict updated STR-3105:
-------------------------------
Fix Version/s: Future
Ralph, please submit a patch. It will be very welcomed.
> Document how to migrate <logic> tags to JSTL
> --------------------------------------------
>
> Key: STR-3105
> URL: https://issues.apache.org/struts/browse/STR-3105
> Project: Struts 1
> Issue Type: Improvement
> Components: Website
> Affects Versions: 1.3.8
> Environment: any
> Reporter: Ralf Hauser
> Priority: Minor
> Fix For: Future
>
>
> Very often, I find myself having a
> <logic:equal .... true
> .... positive
> </logic:equal
> followed by a
> <logic:notEqual .... true
> .... negative
> </logic:notEqual
> These are maintenance imponderables because in nested settings, you risk to loose oversight if you change one of the statements to also change the other one.
> If there were a <logic:else>
> the above statement could be reduced to
> <logic:equal .... true>
> .... positive ...
> </logic:else>
> .... negative ...
> </logic:equal>
> and only ONE condition is to be maintained
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (STR-3105) Document how to migrate tags to
JSTL
Posted by "Paul Benedict (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/STR-3105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Benedict updated STR-3105:
-------------------------------
Component/s: (was: Taglibs)
Website
Priority: Minor (was: Major)
Issue Type: Improvement (was: New Feature)
Summary: Document how to migrate <logic> tags to JSTL (was: add an optional <logic:else> tag)
> Document how to migrate <logic> tags to JSTL
> --------------------------------------------
>
> Key: STR-3105
> URL: https://issues.apache.org/struts/browse/STR-3105
> Project: Struts 1
> Issue Type: Improvement
> Components: Website
> Affects Versions: 1.3.8
> Environment: any
> Reporter: Ralf Hauser
> Priority: Minor
>
> Very often, I find myself having a
> <logic:equal .... true
> .... positive
> </logic:equal
> followed by a
> <logic:notEqual .... true
> .... negative
> </logic:notEqual
> These are maintenance imponderables because in nested settings, you risk to loose oversight if you change one of the statements to also change the other one.
> If there were a <logic:else>
> the above statement could be reduced to
> <logic:equal .... true>
> .... positive ...
> </logic:else>
> .... negative ...
> </logic:equal>
> and only ONE condition is to be maintained
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (STR-3105) add an optional tag
Posted by "Paul Benedict (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/STR-3105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Benedict closed STR-3105.
------------------------------
Resolution: Won't Fix
The idea is worth implementing a couple years ago, but not today. JSTL/JSP-EL is more powerful and more supported than the logic tags. There's no major benefit to add new enhancements to the logic tag library.
> add an optional <logic:else> tag
> --------------------------------
>
> Key: STR-3105
> URL: https://issues.apache.org/struts/browse/STR-3105
> Project: Struts 1
> Issue Type: New Feature
> Components: Website
> Affects Versions: 1.3.8
> Environment: any
> Reporter: Ralf Hauser
>
> Very often, I find myself having a
> <logic:equal .... true
> .... positive
> </logic:equal
> followed by a
> <logic:notEqual .... true
> .... negative
> </logic:notEqual
> These are maintenance imponderables because in nested settings, you risk to loose oversight if you change one of the statements to also change the other one.
> If there were a <logic:else>
> the above statement could be reduced to
> <logic:equal .... true>
> .... positive ...
> </logic:else>
> .... negative ...
> </logic:equal>
> and only ONE condition is to be maintained
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (STR-3105) add an optional tag
Posted by "Niall Pemberton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/STR-3105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_42371 ]
Niall Pemberton commented on STR-3105:
--------------------------------------
I wrote if/then/else and switch/case tags (based on the Struts logic tags) back in 2001 [1] - but the opinion[2] then was that we should encourage users to use the JSTL and not continue to add logic tags to Struts. IMO there was possibly a case to add this kind of stuff back in 2001 since JSTL was only on the horizon - but having lost that argument then, then theres less reason to reverse it now where I doubt anyone uses a servlet container that doesn't support JSTL.
[1] http://husted.com/struts/resources/logic-niallp.htm
[2] http://tinyurl.com/2x99gd
> add an optional <logic:else> tag
> --------------------------------
>
> Key: STR-3105
> URL: https://issues.apache.org/struts/browse/STR-3105
> Project: Struts 1
> Issue Type: New Feature
> Components: Taglibs
> Affects Versions: 1.3.8
> Environment: any
> Reporter: Ralf Hauser
>
> Very often, I find myself having a
> <logic:equal .... true
> .... positive
> </logic:equal
> followed by a
> <logic:notEqual .... true
> .... negative
> </logic:notEqual
> These are maintenance imponderables because in nested settings, you risk to loose oversight if you change one of the statements to also change the other one.
> If there were a <logic:else>
> the above statement could be reduced to
> <logic:equal .... true>
> .... positive ...
> </logic:else>
> .... negative ...
> </logic:equal>
> and only ONE condition is to be maintained
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (STR-3105) Document how to migrate tags
to JSTL
Posted by "Ralf Hauser (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/STR-3105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_42385 ]
Ralf Hauser commented on STR-3105:
----------------------------------
Thanks for all the comments, if I understand what I find on your site correctly. the suggested minimum is to use Struts-EL since it appears to give the flexibility to gradually move towards JSTL.
in the menu on the left side on the web-page http://struts.apache.org/1.3.9/, I'd still add a style element as such:
<li class="none">
<a href="http://struts.apache.org/1.3.9/struts-taglib/index.html"
style="font-style:italic;text-decoration: line-through;" >Struts Taglib</a>
</li>
> Document how to migrate <logic> tags to JSTL
> --------------------------------------------
>
> Key: STR-3105
> URL: https://issues.apache.org/struts/browse/STR-3105
> Project: Struts 1
> Issue Type: Improvement
> Components: Website
> Affects Versions: 1.3.8
> Environment: any
> Reporter: Ralf Hauser
> Priority: Minor
>
> Very often, I find myself having a
> <logic:equal .... true
> .... positive
> </logic:equal
> followed by a
> <logic:notEqual .... true
> .... negative
> </logic:notEqual
> These are maintenance imponderables because in nested settings, you risk to loose oversight if you change one of the statements to also change the other one.
> If there were a <logic:else>
> the above statement could be reduced to
> <logic:equal .... true>
> .... positive ...
> </logic:else>
> .... negative ...
> </logic:equal>
> and only ONE condition is to be maintained
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (STR-3105) add an optional tag
Posted by "Ralf Hauser (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/STR-3105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_42373 ]
Ralf Hauser commented on STR-3105:
----------------------------------
Niall, Thanks for the insight.
If that is true what you are saying, it is very misleading that
http://struts.apache.org/1.3.9/struts-taglib/index.html
doesn't have a large "D E P R E C A T E D" sign and a pointer to the recommended JSTL
> add an optional <logic:else> tag
> --------------------------------
>
> Key: STR-3105
> URL: https://issues.apache.org/struts/browse/STR-3105
> Project: Struts 1
> Issue Type: New Feature
> Components: Taglibs
> Affects Versions: 1.3.8
> Environment: any
> Reporter: Ralf Hauser
>
> Very often, I find myself having a
> <logic:equal .... true
> .... positive
> </logic:equal
> followed by a
> <logic:notEqual .... true
> .... negative
> </logic:notEqual
> These are maintenance imponderables because in nested settings, you risk to loose oversight if you change one of the statements to also change the other one.
> If there were a <logic:else>
> the above statement could be reduced to
> <logic:equal .... true>
> .... positive ...
> </logic:else>
> .... negative ...
> </logic:equal>
> and only ONE condition is to be maintained
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (STR-3105) Document how to migrate tags
to JSTL
Posted by "Paul Benedict (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/STR-3105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_42386 ]
Paul Benedict commented on STR-3105:
------------------------------------
Ralph, we have a lot of documentation issues opened. If you think your editorial skills are good, you are more than free to help!! Just create patches for these tickets and I will apply them.
> Document how to migrate <logic> tags to JSTL
> --------------------------------------------
>
> Key: STR-3105
> URL: https://issues.apache.org/struts/browse/STR-3105
> Project: Struts 1
> Issue Type: Improvement
> Components: Website
> Affects Versions: 1.3.8
> Environment: any
> Reporter: Ralf Hauser
> Priority: Minor
>
> Very often, I find myself having a
> <logic:equal .... true
> .... positive
> </logic:equal
> followed by a
> <logic:notEqual .... true
> .... negative
> </logic:notEqual
> These are maintenance imponderables because in nested settings, you risk to loose oversight if you change one of the statements to also change the other one.
> If there were a <logic:else>
> the above statement could be reduced to
> <logic:equal .... true>
> .... positive ...
> </logic:else>
> .... negative ...
> </logic:equal>
> and only ONE condition is to be maintained
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (STR-3105) add an optional tag
Posted by "Ralf Hauser (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/STR-3105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_42375 ]
Ralf Hauser commented on STR-3105:
----------------------------------
Dave, thanks for your note - I also see it for the "bean" tags.
Does that mean (despite "html" tags apparently fully being ported to the Struts EL variant of JSTL) that one should still use them.
If not, I would stil be interested in a "wiki" page that reports about recommended migration stratetgies away from the "old" tags...
(how well can they co-habit?)
> add an optional <logic:else> tag
> --------------------------------
>
> Key: STR-3105
> URL: https://issues.apache.org/struts/browse/STR-3105
> Project: Struts 1
> Issue Type: New Feature
> Components: Taglibs
> Affects Versions: 1.3.8
> Environment: any
> Reporter: Ralf Hauser
>
> Very often, I find myself having a
> <logic:equal .... true
> .... positive
> </logic:equal
> followed by a
> <logic:notEqual .... true
> .... negative
> </logic:notEqual
> These are maintenance imponderables because in nested settings, you risk to loose oversight if you change one of the statements to also change the other one.
> If there were a <logic:else>
> the above statement could be reduced to
> <logic:equal .... true>
> .... positive ...
> </logic:else>
> .... negative ...
> </logic:equal>
> and only ONE condition is to be maintained
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (STR-3105) add an optional tag
Posted by "Dave Newton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/STR-3105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_42374 ]
Dave Newton commented on STR-3105:
----------------------------------
http://struts.apache.org/1.3.9/struts-taglib/dev_logic.html
> add an optional <logic:else> tag
> --------------------------------
>
> Key: STR-3105
> URL: https://issues.apache.org/struts/browse/STR-3105
> Project: Struts 1
> Issue Type: New Feature
> Components: Taglibs
> Affects Versions: 1.3.8
> Environment: any
> Reporter: Ralf Hauser
>
> Very often, I find myself having a
> <logic:equal .... true
> .... positive
> </logic:equal
> followed by a
> <logic:notEqual .... true
> .... negative
> </logic:notEqual
> These are maintenance imponderables because in nested settings, you risk to loose oversight if you change one of the statements to also change the other one.
> If there were a <logic:else>
> the above statement could be reduced to
> <logic:equal .... true>
> .... positive ...
> </logic:else>
> .... negative ...
> </logic:equal>
> and only ONE condition is to be maintained
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (STR-3105) add an optional tag
Posted by "Dave Newton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/STR-3105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_42376 ]
Dave Newton commented on STR-3105:
----------------------------------
I believe the current thought is that the HTML tags, since they perform functionality specfic to S2, can still be used; where functionality is provided by JSTL the JSTL tags are preferred, if for no other reason than the tag libs haven't gotten much love lately.
> add an optional <logic:else> tag
> --------------------------------
>
> Key: STR-3105
> URL: https://issues.apache.org/struts/browse/STR-3105
> Project: Struts 1
> Issue Type: New Feature
> Components: Taglibs
> Affects Versions: 1.3.8
> Environment: any
> Reporter: Ralf Hauser
>
> Very often, I find myself having a
> <logic:equal .... true
> .... positive
> </logic:equal
> followed by a
> <logic:notEqual .... true
> .... negative
> </logic:notEqual
> These are maintenance imponderables because in nested settings, you risk to loose oversight if you change one of the statements to also change the other one.
> If there were a <logic:else>
> the above statement could be reduced to
> <logic:equal .... true>
> .... positive ...
> </logic:else>
> .... negative ...
> </logic:equal>
> and only ONE condition is to be maintained
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (STR-3105) add an optional tag
Posted by "Paul Benedict (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/STR-3105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Benedict reopened STR-3105:
--------------------------------
Actually, re-opening this as a documentation issue.
> add an optional <logic:else> tag
> --------------------------------
>
> Key: STR-3105
> URL: https://issues.apache.org/struts/browse/STR-3105
> Project: Struts 1
> Issue Type: New Feature
> Components: Website
> Affects Versions: 1.3.8
> Environment: any
> Reporter: Ralf Hauser
>
> Very often, I find myself having a
> <logic:equal .... true
> .... positive
> </logic:equal
> followed by a
> <logic:notEqual .... true
> .... negative
> </logic:notEqual
> These are maintenance imponderables because in nested settings, you risk to loose oversight if you change one of the statements to also change the other one.
> If there were a <logic:else>
> the above statement could be reduced to
> <logic:equal .... true>
> .... positive ...
> </logic:else>
> .... negative ...
> </logic:equal>
> and only ONE condition is to be maintained
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.