You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by "tkhurana (via GitHub)" <gi...@apache.org> on 2025/09/18 19:20:43 UTC
[PR] PHOENIX-7701 UngroupedAggregateRegionScanner doesn't release rpc handler on page timeouts [phoenix]
tkhurana opened a new pull request, #2289:
URL: https://github.com/apache/phoenix/pull/2289
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-7701 UngroupedAggregateRegionScanner doesn't release rpc handler on page timeouts [phoenix]
Posted by "kadirozde (via GitHub)" <gi...@apache.org>.
kadirozde commented on code in PR #2289:
URL: https://github.com/apache/phoenix/pull/2289#discussion_r2361550702
##########
phoenix-core-server/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionScanner.java:
##########
@@ -702,6 +708,10 @@ public boolean next(List<Cell> resultsToReturn, ScannerContext scannerContext)
} while (
hasMore && (EnvironmentEdgeManager.currentTimeMillis() - startTime) < pageSizeMs
Review Comment:
We need to add here and to every other loop ScannerContextUtil.checkTimeLimit(scannerContext). This is to make sure that when a lower Phoenix region scanner requests to return immediately, the all the region scanners above that break their loop.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-7701 UngroupedAggregateRegionScanner doesn't release rpc handler on page timeouts [phoenix]
Posted by "tkhurana (via GitHub)" <gi...@apache.org>.
tkhurana commented on code in PR #2289:
URL: https://github.com/apache/phoenix/pull/2289#discussion_r2363925407
##########
phoenix-core-server/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionScanner.java:
##########
@@ -702,6 +708,10 @@ public boolean next(List<Cell> resultsToReturn, ScannerContext scannerContext)
} while (
hasMore && (EnvironmentEdgeManager.currentTimeMillis() - startTime) < pageSizeMs
Review Comment:
@kadirozde That was something I was planning to address in a separate PR which ensures that we page out across multiple `next()` calls.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-7701 UngroupedAggregateRegionScanner doesn't release rpc handler on page timeouts [phoenix]
Posted by "kadirozde (via GitHub)" <gi...@apache.org>.
kadirozde commented on code in PR #2289:
URL: https://github.com/apache/phoenix/pull/2289#discussion_r2361550702
##########
phoenix-core-server/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionScanner.java:
##########
@@ -702,6 +708,10 @@ public boolean next(List<Cell> resultsToReturn, ScannerContext scannerContext)
} while (
hasMore && (EnvironmentEdgeManager.currentTimeMillis() - startTime) < pageSizeMs
Review Comment:
We need to add here and to every other loop ScannerContextUtil.checkTimeLimit(scannerContext). This is to make sure that when a lower Phoenix region scanner requests to return immediately, all the region scanners above that break their loop.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-7701 UngroupedAggregateRegionScanner doesn't release rpc handler on page timeouts [phoenix]
Posted by "tkhurana (via GitHub)" <gi...@apache.org>.
tkhurana merged PR #2289:
URL: https://github.com/apache/phoenix/pull/2289
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-7701 UngroupedAggregateRegionScanner doesn't release rpc handler on page timeouts [phoenix]
Posted by "virajjasani (via GitHub)" <gi...@apache.org>.
virajjasani commented on PR #2289:
URL: https://github.com/apache/phoenix/pull/2289#issuecomment-3314292433
Let's cherry-pick the commit in 5.3 branch also
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org