You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/07 16:54:41 UTC

[GitHub] [pulsar] lgxbslgx opened a new pull request, #15964: [fix][client] Fix JDK17 compatibility issue

lgxbslgx opened a new pull request, #15964:
URL: https://github.com/apache/pulsar/pull/15964

   
   Fixes #15349
   
   
   ### Motivation
   
   When using the JDK17, pulsar-client throws exception `module java.base does not export sun.net to unnamed module`, it is good to fix it.
   
   ### Modifications
   
   Add `--add-opens java.base/sun.net=ALL-UNNAMED` to java option when using JDK17.
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   ### Documentation
   
   Check the box below or label this PR directly.
   
   Need to update docs? 
   
   - [x] `doc-not-needed` 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] michaeljmarshall commented on pull request #15964: [fix][client] Fix JDK17 compatibility issue

Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on PR #15964:
URL: https://github.com/apache/pulsar/pull/15964#issuecomment-1151534427

   @lgxbslgx - thanks for your contribution!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] michaeljmarshall merged pull request #15964: [fix][client] Fix JDK17 compatibility issue

Posted by GitBox <gi...@apache.org>.
michaeljmarshall merged PR #15964:
URL: https://github.com/apache/pulsar/pull/15964


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] yulin20010422 commented on pull request #15964: [fix][client] Fix JDK17 compatibility issue

Posted by "yulin20010422 (via GitHub)" <gi...@apache.org>.
yulin20010422 commented on PR #15964:
URL: https://github.com/apache/pulsar/pull/15964#issuecomment-1678655234

   @BewareMyPower Thankyou,I submitted a new issue.[https://github.com/apache/pulsar/issues/20994](https://github.com/apache/pulsar/pull/url)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] yulin20010422 commented on pull request #15964: [fix][client] Fix JDK17 compatibility issue

Posted by "yulin20010422 (via GitHub)" <gi...@apache.org>.
yulin20010422 commented on PR #15964:
URL: https://github.com/apache/pulsar/pull/15964#issuecomment-1678396559

   After configuration, a warning will be reported: `Can not find org.apache.pulsar.shade.io.netty.resolver.dns.macos.MacOSDnsServerAddressStreamProvider in the classpath, fallback to system defaults. This may result in incorrect DNS resolutions on MacOS. Check whether you have a dependency on 'io.netty:netty-resolver-dns-native-macos'`, do I need to introduce 'io.netty:netty-resolver-dns-native-macos', in other words, do not add this dependency? will affect.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lgxbslgx commented on pull request #15964: [fix][client] Fix JDK17 compatibility issue

Posted by GitBox <gi...@apache.org>.
lgxbslgx commented on PR #15964:
URL: https://github.com/apache/pulsar/pull/15964#issuecomment-1151855232

   @michaeljmarshall Thanks for the review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lgxbslgx commented on pull request #15964: [fix][client] Fix JDK17 compatibility issue

Posted by GitBox <gi...@apache.org>.
lgxbslgx commented on PR #15964:
URL: https://github.com/apache/pulsar/pull/15964#issuecomment-1149879674

   @merlimat Thanks for the review. Still waiting for another committer to review this patch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] yulin20010422 commented on pull request #15964: [fix][client] Fix JDK17 compatibility issue

Posted by "yulin20010422 (via GitHub)" <gi...@apache.org>.
yulin20010422 commented on PR #15964:
URL: https://github.com/apache/pulsar/pull/15964#issuecomment-1678654587

   > @yulin20010422 You can open an issue to record the details steps to reproduce this issue here: https://github.com/apache/pulsar/issues
   
   Thankyou,I submitted a new issue.[https://github.com/apache/pulsar/issues/20994](url)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] yulin20010422 commented on pull request #15964: [fix][client] Fix JDK17 compatibility issue

Posted by "yulin20010422 (via GitHub)" <gi...@apache.org>.
yulin20010422 commented on PR #15964:
URL: https://github.com/apache/pulsar/pull/15964#issuecomment-1678514225

   @michaeljmarshall -Thank you for your timely reply, my computer system is macOS13.4 version M1 chip. I will not have this warning when I use Win11 system. In addition, I will still report this warning when I add `'io.netty:netty-resolver-dns-native-macos' `on macOS.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] BewareMyPower commented on pull request #15964: [fix][client] Fix JDK17 compatibility issue

Posted by "BewareMyPower (via GitHub)" <gi...@apache.org>.
BewareMyPower commented on PR #15964:
URL: https://github.com/apache/pulsar/pull/15964#issuecomment-1678630934

   @yulin20010422 You can open an issue to record the details steps to reproduce this issue here: https://github.com/apache/pulsar/issues


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] michaeljmarshall commented on pull request #15964: [fix][client] Fix JDK17 compatibility issue

Posted by "michaeljmarshall (via GitHub)" <gi...@apache.org>.
michaeljmarshall commented on PR #15964:
URL: https://github.com/apache/pulsar/pull/15964#issuecomment-1678415271

   @yulin20010422 - it'd help if you provided more information about the system you're running. Would you mind opening a new ticket to discuss this further? Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org