You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "XiangpengHao (via GitHub)" <gi...@apache.org> on 2024/06/15 23:04:05 UTC
[I] Implement `compare_op` for view types [arrow-rs]
XiangpengHao opened a new issue, #5897:
URL: https://github.com/apache/arrow-rs/issues/5897
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
<!--
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
(This section helps Arrow developers understand the context and *why* for this feature, in addition to the *what*)
-->
Currently the following test case(s) will fail:
```rust
#[test]
fn test_utf8_view_eq() {
let values = vec![Some("small"), None, Some("larger than 12 bytes string")];
let left = StringViewArray::from_iter(values.iter());
let right = StringViewArray::from_iter(values.iter());
crate::cmp::eq(&left, &right).unwrap();
}
```
Because we haven't implemented the code to compare two view types in `compare_op` https://github.com/XiangpengHao/arrow-rs/blob/master/arrow-ord/src/cmp.rs#L227
I believe this is required to unblock https://github.com/apache/datafusion/issues/10919
**Describe the solution you'd like**
<!--
A clear and concise description of what you want to happen.
-->
The solution should be fairly simple.
**Describe alternatives you've considered**
<!--
A clear and concise description of any alternative solutions or features you've considered.
-->
**Additional context**
<!--
Add any other context or screenshots about the feature request here.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Implement `compare_op` for view types [arrow-rs]
Posted by "XiangpengHao (via GitHub)" <gi...@apache.org>.
XiangpengHao commented on issue #5897:
URL: https://github.com/apache/arrow-rs/issues/5897#issuecomment-2170963529
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Implement `compare_op` for view types [arrow-rs]
Posted by "XiangpengHao (via GitHub)" <gi...@apache.org>.
XiangpengHao commented on issue #5897:
URL: https://github.com/apache/arrow-rs/issues/5897#issuecomment-2170964484
> take
Seems arrow don't have the fancy `take` command as DataFusion's https://datafusion.apache.org/contributor-guide/index.html#finding-and-creating-issues-to-work-on
Can you assign me @alamb ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Implement `compare_op` for `GenericBinaryView` [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb closed issue #5897: Implement `compare_op` for `GenericBinaryView`
URL: https://github.com/apache/arrow-rs/issues/5897
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Implement `compare_op` for `GenericBinaryView` [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #5897:
URL: https://github.com/apache/arrow-rs/issues/5897#issuecomment-2204015578
`label_issue.py` automatically added labels {'arrow'} from #5900
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org