You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/11 20:20:37 UTC

[GitHub] [incubator-superset] robdiciuccio opened a new pull request #10848: Update FOSSA configuration for new requirements layout

robdiciuccio opened a new pull request #10848:
URL: https://github.com/apache/incubator-superset/pull/10848


   ### SUMMARY
   FOSSA is not accurately checking or failing on license issues with modules in the base requirements. This PR updates the FOSSA config to test `base` and `docker` requirements for license issues, and fails the build if any are found.
   
   I've also made the FOSSA report public, so anyone should be able to view.
   
   NOTE: there are currently dependencies in `base.txt` that do not meet Apache licensing requirements (e.g. `mysqlclient` and `psycopg2-binary`), so the check is expected to fail. 
   
   ### TEST PLAN
   - FOSSA should run in CI and should fail on incompatible licenses
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10848: Update FOSSA configuration for new requirements layout

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10848:
URL: https://github.com/apache/incubator-superset/pull/10848#issuecomment-692441725


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10848?src=pr&el=h1) Report
   > Merging [#10848](https://codecov.io/gh/apache/incubator-superset/pull/10848?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/4502690ef9d02fb2922f2f53d6bbd778e3fe24a1?el=desc) will **decrease** coverage by `0.25%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10848/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10848?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10848      +/-   ##
   ==========================================
   - Coverage   61.34%   61.09%   -0.26%     
   ==========================================
     Files         380      380              
     Lines       24068    24072       +4     
   ==========================================
   - Hits        14765    14706      -59     
   - Misses       9303     9366      +63     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #python | `61.09% <ø> (-0.26%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10848?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/10848/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.16% <0.00%> (-12.50%)` | :arrow_down: |
   | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/10848/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/10848/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.54% <0.00%> (-8.75%)` | :arrow_down: |
   | [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/10848/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/10848/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/10848/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
   | [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/10848/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10848/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.29% <0.00%> (-1.05%)` | :arrow_down: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10848/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.05% <0.00%> (-0.70%)` | :arrow_down: |
   | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10848/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `86.99% <0.00%> (-0.69%)` | :arrow_down: |
   | ... and [6 more](https://codecov.io/gh/apache/incubator-superset/pull/10848/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10848?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10848?src=pr&el=footer). Last update [4502690...d1a95ca](https://codecov.io/gh/apache/incubator-superset/pull/10848?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] robdiciuccio commented on a change in pull request #10848: Update FOSSA configuration for new requirements layout

Posted by GitBox <gi...@apache.org>.
robdiciuccio commented on a change in pull request #10848:
URL: https://github.com/apache/incubator-superset/pull/10848#discussion_r489103102



##########
File path: .fossa.yml
##########
@@ -28,13 +28,15 @@ analyze:
     type: npm
     target: superset-frontend
     path: superset-frontend
-  - name: docs
+  - name: base
     type: pip
-    target: docs
-    path: docs
-  - name: .
+    target: .
+    path: .
+    options:
+      requirements: ./requirements/base.txt
+  - name: docker

Review comment:
       Ok, removed it for now. May need some reworking after https://github.com/apache/incubator-superset/pull/10875 settles.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] rusackas merged pull request #10848: Update FOSSA configuration for new requirements layout

Posted by GitBox <gi...@apache.org>.
rusackas merged pull request #10848:
URL: https://github.com/apache/incubator-superset/pull/10848


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] craig-rueda commented on a change in pull request #10848: Update FOSSA configuration for new requirements layout

Posted by GitBox <gi...@apache.org>.
craig-rueda commented on a change in pull request #10848:
URL: https://github.com/apache/incubator-superset/pull/10848#discussion_r488766832



##########
File path: .fossa.yml
##########
@@ -28,13 +28,15 @@ analyze:
     type: npm
     target: superset-frontend
     path: superset-frontend
-  - name: docs
+  - name: base
     type: pip
-    target: docs
-    path: docs
-  - name: .
+    target: .
+    path: .
+    options:
+      requirements: ./requirements/base.txt
+  - name: docker

Review comment:
       Yep, lean gets "local" and dev gets "docker". When I did this, "local" already existed, so I reused it. I added "docker.txt" in order to append a few more deps for docker-compose.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter commented on pull request #10848: Update FOSSA configuration for new requirements layout

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10848:
URL: https://github.com/apache/incubator-superset/pull/10848#issuecomment-692441725


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10848?src=pr&el=h1) Report
   > Merging [#10848](https://codecov.io/gh/apache/incubator-superset/pull/10848?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/4502690ef9d02fb2922f2f53d6bbd778e3fe24a1?el=desc) will **decrease** coverage by `0.09%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10848/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10848?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10848      +/-   ##
   ==========================================
   - Coverage   61.34%   61.24%   -0.10%     
   ==========================================
     Files         380      380              
     Lines       24068    24068              
   ==========================================
   - Hits        14765    14741      -24     
   - Misses       9303     9327      +24     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #python | `61.24% <ø> (-0.10%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10848?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/10848/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `56.25% <0.00%> (-35.42%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10848/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.22% <0.00%> (-1.12%)` | :arrow_down: |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10848/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.22% <0.00%> (-0.25%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10848?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10848?src=pr&el=footer). Last update [4502690...a97213d](https://codecov.io/gh/apache/incubator-superset/pull/10848?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] robdiciuccio commented on a change in pull request #10848: Update FOSSA configuration for new requirements layout

Posted by GitBox <gi...@apache.org>.
robdiciuccio commented on a change in pull request #10848:
URL: https://github.com/apache/incubator-superset/pull/10848#discussion_r488764039



##########
File path: .fossa.yml
##########
@@ -28,13 +28,15 @@ analyze:
     type: npm
     target: superset-frontend
     path: superset-frontend
-  - name: docs
+  - name: base
     type: pip
-    target: docs
-    path: docs
-  - name: .
+    target: .
+    path: .
+    options:
+      requirements: ./requirements/base.txt
+  - name: docker

Review comment:
       So, it looks like the "lean" Docker image is using `requirements/local.txt`? This is confusing.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10848: Update FOSSA configuration for new requirements layout

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10848:
URL: https://github.com/apache/incubator-superset/pull/10848#issuecomment-692441725


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10848?src=pr&el=h1) Report
   > Merging [#10848](https://codecov.io/gh/apache/incubator-superset/pull/10848?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/4502690ef9d02fb2922f2f53d6bbd778e3fe24a1?el=desc) will **decrease** coverage by `0.27%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10848/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10848?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10848      +/-   ##
   ==========================================
   - Coverage   61.34%   61.07%   -0.28%     
   ==========================================
     Files         380      380              
     Lines       24068    24083      +15     
   ==========================================
   - Hits        14765    14709      -56     
   - Misses       9303     9374      +71     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #python | `61.07% <ø> (-0.28%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10848?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/10848/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.16% <0.00%> (-12.50%)` | :arrow_down: |
   | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/10848/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/10848/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.54% <0.00%> (-8.75%)` | :arrow_down: |
   | [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/10848/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/10848/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/10848/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
   | [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/10848/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10848/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.29% <0.00%> (-1.05%)` | :arrow_down: |
   | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10848/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `86.99% <0.00%> (-0.69%)` | :arrow_down: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10848/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.07% <0.00%> (-0.69%)` | :arrow_down: |
   | ... and [2 more](https://codecov.io/gh/apache/incubator-superset/pull/10848/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10848?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10848?src=pr&el=footer). Last update [4502690...d1a95ca](https://codecov.io/gh/apache/incubator-superset/pull/10848?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10848: Update FOSSA configuration for new requirements layout

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10848:
URL: https://github.com/apache/incubator-superset/pull/10848#issuecomment-692441725


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10848?src=pr&el=h1) Report
   > Merging [#10848](https://codecov.io/gh/apache/incubator-superset/pull/10848?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/4502690ef9d02fb2922f2f53d6bbd778e3fe24a1?el=desc) will **decrease** coverage by `0.74%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10848/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10848?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10848      +/-   ##
   ==========================================
   - Coverage   61.34%   60.59%   -0.75%     
   ==========================================
     Files         380      380              
     Lines       24068    24072       +4     
   ==========================================
   - Hits        14765    14587     -178     
   - Misses       9303     9485     +182     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #python | `60.59% <ø> (-0.75%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10848?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/10848/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/10848/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/10848/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.16% <0.00%> (-12.50%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/10848/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.85% <0.00%> (-11.44%)` | :arrow_down: |
   | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/10848/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
   | [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/10848/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/10848/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/10848/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/10848/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
   | [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/10848/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
   | ... and [9 more](https://codecov.io/gh/apache/incubator-superset/pull/10848/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10848?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10848?src=pr&el=footer). Last update [4502690...d1a95ca](https://codecov.io/gh/apache/incubator-superset/pull/10848?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] robdiciuccio commented on pull request #10848: Update FOSSA configuration for new requirements layout

Posted by GitBox <gi...@apache.org>.
robdiciuccio commented on pull request #10848:
URL: https://github.com/apache/incubator-superset/pull/10848#issuecomment-693546226


   We should probably run the license check each time code is merged to master, as well as when the requirements files change.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10848: Update FOSSA configuration for new requirements layout

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10848:
URL: https://github.com/apache/incubator-superset/pull/10848#issuecomment-692441725


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10848?src=pr&el=h1) Report
   > Merging [#10848](https://codecov.io/gh/apache/incubator-superset/pull/10848?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/4502690ef9d02fb2922f2f53d6bbd778e3fe24a1?el=desc) will **decrease** coverage by `0.22%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10848/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10848?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10848      +/-   ##
   ==========================================
   - Coverage   61.34%   61.12%   -0.23%     
   ==========================================
     Files         380      380              
     Lines       24068    24083      +15     
   ==========================================
   - Hits        14765    14720      -45     
   - Misses       9303     9363      +60     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #python | `61.12% <ø> (-0.23%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10848?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/10848/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.16% <0.00%> (-12.50%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/10848/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.54% <0.00%> (-8.75%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/10848/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/10848/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10848/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.29% <0.00%> (-1.05%)` | :arrow_down: |
   | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10848/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `87.26% <0.00%> (-0.42%)` | :arrow_down: |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10848/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.22% <0.00%> (-0.25%)` | :arrow_down: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10848/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.61% <0.00%> (-0.14%)` | :arrow_down: |
   | [superset/databases/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/10848/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL3V0aWxzLnB5) | `78.94% <0.00%> (+0.56%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10848?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10848?src=pr&el=footer). Last update [4502690...d1a95ca](https://codecov.io/gh/apache/incubator-superset/pull/10848?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] robdiciuccio commented on pull request #10848: Update FOSSA configuration for new requirements layout

Posted by GitBox <gi...@apache.org>.
robdiciuccio commented on pull request #10848:
URL: https://github.com/apache/incubator-superset/pull/10848#issuecomment-692447563


   Example public FOSSA report:
   https://app.fossa.com/projects/custom+11342%2Fgithub.com%2Fapache%2Fincubator-superset/refs/branch/HEAD/c1b5d64859540a08ba74a41bfc3c9a54d506b2e4


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] craig-rueda commented on a change in pull request #10848: Update FOSSA configuration for new requirements layout

Posted by GitBox <gi...@apache.org>.
craig-rueda commented on a change in pull request #10848:
URL: https://github.com/apache/incubator-superset/pull/10848#discussion_r488369282



##########
File path: .fossa.yml
##########
@@ -28,13 +28,15 @@ analyze:
     type: npm
     target: superset-frontend
     path: superset-frontend
-  - name: docs
+  - name: base
     type: pip
-    target: docs
-    path: docs
-  - name: .
+    target: .
+    path: .
+    options:
+      requirements: ./requirements/base.txt
+  - name: docker

Review comment:
       We don't need this check, as the Docker requirements are only used for the "dev" image (which is used in docker-compose)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org