You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2015/03/02 07:21:30 UTC

Review Request 31614: Added a comment about uses of FetcherProcess::cache withotu 'defer'.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31614/
-----------------------------------------------------------

Review request for mesos and Bernd Mathiske.


Repository: mesos


Description
-------

There are race conditions where if a FetcherProcess is being shutdown but there are still outstanding asynchronous calls that use things like FetcherProcess::cache that memory will actually get deleted and we'll segfault. This patch addresses one of those cases.


Diffs
-----

  src/slave/containerizer/fetcher.cpp 9e9e9d0eb6b0801d53dec3baea32a4cd4acdd5e2 

Diff: https://reviews.apache.org/r/31614/diff/


Testing
-------

make check


Thanks,

Benjamin Hindman