[GitHub] [incubator-openwhisk] dgrove-oss commented on issue #4570: KCF: propagate cf_ca_extraArgs_env_i into user containers

[GitBox <gi...@apache.org>]

dgrove-oss commented on issue #4570: KCF: propagate cf_ca_extraArgs_env_i into user containers
URL: https://github.com/apache/incubator-openwhisk/pull/4570#issuecomment-515431527
 
 
   I like @sven-lange-last 's proposal:
   
   > Would it make sense to introduce a general concept for injecting static environment variables into action containers. I'm not talking about env variables from the user side but to be injected from the system side. We could introduce a config parameter whisk.container-factory.extra-env-vars that holds a list of env vars. It's up to the container factory implementations to inject the variables.
   
   I wasn't that happy about shoving it through the extra args and looking for the `env` key, but that was the minimal change.  Doing a more general thing makes sense.
   
   For DCF, I would plan to merge `whisk.container-factory.extra-env-vars`  and any additional values provided in the `extra-args` with an `env` key.  Sound plausible?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services