You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "hong dongdong (Jira)" <ji...@apache.org> on 2020/01/17 01:43:00 UTC

[jira] [Commented] (HUDI-540) Incorrect archive directory path in show archived commits cli

    [ https://issues.apache.org/jira/browse/HUDI-540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17017639#comment-17017639 ] 

hong dongdong commented on HUDI-540:
------------------------------------

[~venkee14] It‘s need 
{code:java}
@CliOption(key = {"archiveFolderPattern"}, help = "Archive Folder", unspecifiedDefaultValue = "") String folder
{code}
Command 'show archived commit stats' always work correctly with this cliOption.

HoodieSparkSqlWriter.scala set archiveLogfolder as 'archived' when create a new table, otherwise the default is "".

I will try to address this later.

> Incorrect archive directory path in show archived commits cli
> -------------------------------------------------------------
>
>                 Key: HUDI-540
>                 URL: https://issues.apache.org/jira/browse/HUDI-540
>             Project: Apache Hudi (incubating)
>          Issue Type: Bug
>          Components: CLI
>         Environment: EMR, S3 
>            Reporter: Venkatesh
>            Priority: Major
>
> Archive path is specified as - new Path(basePath + "/.hoodie/.commits_.archive*"); , but should be -new Path(basePath + "/.hoodie/archived/.commits_.archive*");
> We are using S3 to store hudi dataset if that matters.
>  
> [https://github.com/apache/incubator-hudi/blob/a733f4ef723865738d8541282c0c7234d64668db/hudi-cli/src/main/java/org/apache/hudi/cli/commands/ArchivedCommitsCommand.java#L143]
>  
> [https://github.com/apache/incubator-hudi/blob/a733f4ef723865738d8541282c0c7234d64668db/hudi-cli/src/main/java/org/apache/hudi/cli/commands/ArchivedCommitsCommand.java#L66]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)