You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/08/21 01:53:56 UTC

[GitHub] [incubator-druid] jon-wei opened a new pull request #8349: Fix ClassCastException for TopN with long-type dimension

jon-wei opened a new pull request #8349: Fix ClassCastException for TopN with long-type dimension
URL: https://github.com/apache/incubator-druid/pull/8349
 
 
   This PR fixes #8348 by ensuring that `DimValHolder` converts dimension values to the output type specified in the dimension spec of the TopN query.
   
   This PR has:
   - [x] been self-reviewed.
   - [x] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
   - [x] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
   - [x] been tested in a test Druid cluster.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org