[GitHub] [airflow] uranusjr commented on pull request #25511: Limit Flask to <2.3 in the wake of 2.2 breaking our tests

[GitBox <gi...@apache.org>]

uranusjr commented on PR #25511:
URL: https://github.com/apache/airflow/pull/25511#issuecomment-1204574479

   Patch in this PR looks good to me.
   
   > Seems that this one change from datetime.utcnow() to datetime.now(timezone.utc) connected with FreezeGun and FakeDateTime apparently causes it to produce different results that either real datetime or pendulum datettime.
   
   Pendulum tries to be clever and returns a string form with a `T` separator (instead of a space used by datetime) to make the output. But it misses implementing `now(timezone.utc)` and returns a bare `datetime` (instead of a Pendulum `DateTime`) and clever abstraction crumbles down. This kind of little things caused me a lot of pain when I worked on the test case speedup a while ago.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org