You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/09 14:55:31 UTC
[GitHub] [spark] cloud-fan commented on a change in pull request #34729: [SPARK-37475][SQL] Add scale parameter to floor and ceil functions
cloud-fan commented on a change in pull request #34729:
URL: https://github.com/apache/spark/pull/34729#discussion_r802749104
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MathExpressionsSuite.scala
##########
@@ -705,6 +818,42 @@ class MathExpressionsSuite extends SparkFunSuite with ExpressionEvalHelper {
checkEvaluation(BRound(-3.5, 0), -4.0)
checkEvaluation(BRound(-0.35, 1), -0.4)
checkEvaluation(BRound(-35, -1), -40)
+ checkEvaluation(checkDataTypeAndCast(
+ FloorExpressionBuilder.build(Seq(Literal(2.5), Literal(0)))), 2L)
+ checkEvaluation(checkDataTypeAndCast(
+ FloorExpressionBuilder.build(Seq(Literal(3.5), Literal(0)))), 3L)
+ checkEvaluation(checkDataTypeAndCast(
+ FloorExpressionBuilder.build(Seq(Literal(-2.5), Literal(0)))), -3L)
+ checkEvaluation(checkDataTypeAndCast(
+ FloorExpressionBuilder.build(Seq(Literal(-3.5), Literal(0)))), -4L)
+ checkEvaluation(checkDataTypeAndCast(
+ FloorExpressionBuilder.build(Seq(Literal(-0.35), Literal(1)))), -0.4)
+ checkEvaluation(checkDataTypeAndCast(
+ FloorExpressionBuilder.build(Seq(Literal(-35), Literal(-1)))), -40L)
+ checkEvaluation(checkDataTypeAndCast(
+ CeilExpressionBuilder.build(Seq(Literal(2.5), Literal(0)))), 3L)
+ checkEvaluation(checkDataTypeAndCast(
+ CeilExpressionBuilder.build(Seq(Literal(3.5), Literal(0)))), 4L)
+ checkEvaluation(checkDataTypeAndCast(
+ CeilExpressionBuilder.build(Seq(Literal(-2.5), Literal(0)))), -2L)
+ checkEvaluation(checkDataTypeAndCast(
+ CeilExpressionBuilder.build(Seq(Literal(-3.5), Literal(0)))), -3L)
+ checkEvaluation(checkDataTypeAndCast(
+ CeilExpressionBuilder.build(Seq(Literal(-0.35), Literal(1)))), -0.3)
+ checkEvaluation(checkDataTypeAndCast(
+ CeilExpressionBuilder.build(Seq(Literal(-35), Literal(-1)))), -30L)
+ checkEvaluation(checkDataTypeAndCast(
+ FloorExpressionBuilder.build(Seq(Literal(-0.1), Literal(0)))), -1L)
+ checkEvaluation(checkDataTypeAndCast(
+ FloorExpressionBuilder.build(Seq(Literal(5), Literal(0)))), 5L)
+ checkEvaluation(checkDataTypeAndCast(
+ FloorExpressionBuilder.build(Seq(Literal(3.1411), Literal(-3)))), 0L)
+ checkEvaluation(checkDataTypeAndCast(
+ CeilExpressionBuilder.build(Seq(Literal(-0.1), Literal(0)))), 0L)
+ checkEvaluation(checkDataTypeAndCast(
+ CeilExpressionBuilder.build(Seq(Literal(5), Literal(0)))), 5L)
+ checkEvaluation(checkDataTypeAndCast(
+ CeilExpressionBuilder.build(Seq(Literal(3.1411), Literal(-3)))), 1000L)
Review comment:
You are right. I tried `select round(1.2, -3)` and it fails. I believe it's an existing bug that the round function does not accept negative scale parameter if input is decimal. We should fix that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org