You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Till Toenshoff <to...@me.com> on 2014/05/20 16:06:57 UTC
Review Request 21695: Added test-containerizer cpp implementation.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21695/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos-git
Description
-------
The test-containerizer is posing as an external containerizer program (ECP) by using the MesosContainerizerProcess (MC) to handle the actual containerizing.
The MC is wrapped by a protobuf process based communication interface (thunk). Both processes are run in form of a daemon.
The daemon is controlled by invocations of this test-containerizer as a trigger executable.
Both processes are spawned implicitly whenever "launch" is invoked on a MESOS_WORK_DIRECTORY that does not have a daemon running yet.
The daemon terminates itself whenever there are no more active containers according to the MesosContainerizerProcess.
The resulting communication scheme is as follows:
EC <> trigger <> thunk <> MesosContainerizerProcess
This patch re-enables the ExternalContainerizer.Launch test.
Diffs
-----
src/Makefile.am ae576c5
src/tests/external_containerizer_test.cpp c26f3c2
src/tests/test_containerizer.cpp PRE-CREATION
src/tests/test_containerizer.proto PRE-CREATION
Diff: https://reviews.apache.org/r/21695/diff/
Testing
-------
make check (on OSX and Linux)
NOTE: Even though this patch does not strictly depend on the given dependency RRs (it applies without them), they still should get committed first to prevent test failures.
Thanks,
Till Toenshoff
Re: Review Request 21695: Added test-containerizer cpp implementation.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21695/#review44116
-----------------------------------------------------------
Bad patch!
Reviews applied: [21681]
Failed command: git apply --index 21681.patch
Error:
error: patch failed: src/slave/containerizer/external_containerizer.cpp:580
error: src/slave/containerizer/external_containerizer.cpp: patch does not apply
- Mesos ReviewBot
On May 20, 2014, 2:06 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21695/
> -----------------------------------------------------------
>
> (Updated May 20, 2014, 2:06 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> The test-containerizer is posing as an external containerizer program (ECP) by using the MesosContainerizerProcess (MC) to handle the actual containerizing.
> The MC is wrapped by a protobuf process based communication interface (thunk). Both processes are run in form of a daemon.
> The daemon is controlled by invocations of this test-containerizer as a trigger executable.
>
> Both processes are spawned implicitly whenever "launch" is invoked on a MESOS_WORK_DIRECTORY that does not have a daemon running yet.
> The daemon terminates itself whenever there are no more active containers according to the MesosContainerizerProcess.
>
> The resulting communication scheme is as follows:
> EC <> trigger <> thunk <> MesosContainerizerProcess
>
> This patch re-enables the ExternalContainerizer.Launch test.
>
>
> Diffs
> -----
>
> src/Makefile.am ae576c5
> src/tests/external_containerizer_test.cpp c26f3c2
> src/tests/test_containerizer.cpp PRE-CREATION
> src/tests/test_containerizer.proto PRE-CREATION
>
> Diff: https://reviews.apache.org/r/21695/diff/
>
>
> Testing
> -------
>
> make check (on OSX and Linux)
>
> NOTE: Even though this patch does not strictly depend on the given dependency RRs (it applies without them), they still should get committed first to prevent test failures.
>
>
> Thanks,
>
> Till Toenshoff
>
>