You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cloudstack.apache.org by David Grizzanti <da...@sungard.com> on 2013/03/13 16:04:28 UTC

Review Request: CLOUDSTACK-1157: No API Documentation on Listing Custom User Templates Using CS4 API

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9902/
-----------------------------------------------------------

Review request for cloudstack.


Description
-------

CLOUDSTACK-1157: No API Documentation on Listing Custom User Templates Using CS4 API

Updated API documentation for listTemplates command, including:
- Added missing options to description
- Updated descriptions to be in line with listISos API command


This addresses bug CLOUDSTACK-1157.


Diffs
-----

  api/src/org/apache/cloudstack/api/command/user/template/ListTemplatesCmd.java c48534e 

Diff: https://reviews.apache.org/r/9902/diff/


Testing
-------


Thanks,

David Grizzanti

Re: Review Request: CLOUDSTACK-1157: No API Documentation on Listing Custom User Templates Using CS4 API

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9902/#review17925
-----------------------------------------------------------


Commit 4d5dfb1139918fd984e6d2392cef4537c6b357eb in branch refs/heads/master from Alena Prokharchyk <al...@citrix.com>
[ https://git-wip-us.apache.org/repos/asf?p=incubator-cloudstack.git;h=4d5dfb1 ]

CLOUDSTACK-1157 updated API documentation for listTemplates command; fixed description of templateFilter parameter to all 7 options (in line with listIsos API cmd)


- ASF Subversion and Git Services


On March 13, 2013, 3:04 p.m., David Grizzanti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9902/
> -----------------------------------------------------------
> 
> (Updated March 13, 2013, 3:04 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> CLOUDSTACK-1157: No API Documentation on Listing Custom User Templates Using CS4 API
> 
> Updated API documentation for listTemplates command, including:
> - Added missing options to description
> - Updated descriptions to be in line with listISos API command
> 
> 
> This addresses bug CLOUDSTACK-1157.
> 
> 
> Diffs
> -----
> 
>   api/src/org/apache/cloudstack/api/command/user/template/ListTemplatesCmd.java c48534e 
> 
> Diff: https://reviews.apache.org/r/9902/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Grizzanti
> 
>

Re: Review Request: CLOUDSTACK-1157: No API Documentation on Listing Custom User Templates Using CS4 API

Posted by Alena Prokharchyk <al...@citrix.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9902/#review17926
-----------------------------------------------------------

Ship it!


Ship It!

- Alena Prokharchyk


On March 13, 2013, 3:04 p.m., David Grizzanti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9902/
> -----------------------------------------------------------
> 
> (Updated March 13, 2013, 3:04 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> CLOUDSTACK-1157: No API Documentation on Listing Custom User Templates Using CS4 API
> 
> Updated API documentation for listTemplates command, including:
> - Added missing options to description
> - Updated descriptions to be in line with listISos API command
> 
> 
> This addresses bug CLOUDSTACK-1157.
> 
> 
> Diffs
> -----
> 
>   api/src/org/apache/cloudstack/api/command/user/template/ListTemplatesCmd.java c48534e 
> 
> Diff: https://reviews.apache.org/r/9902/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Grizzanti
> 
>

RE: Review Request: CLOUDSTACK-1157: No API Documentation on Listing Custom User Templates Using CS4 API

Posted by Animesh Chaturvedi <an...@citrix.com>.

Alena can you review and apply the patch

Animesh

> -----Original Message-----
> From: David Grizzanti [mailto:noreply@reviews.apache.org] On Behalf Of
> David Grizzanti
> Sent: Wednesday, March 13, 2013 8:04 AM
> To: cloudstack; David Grizzanti
> Subject: Review Request: CLOUDSTACK-1157: No API Documentation on
> Listing Custom User Templates Using CS4 API
> 
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9902/
> -----------------------------------------------------------
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> CLOUDSTACK-1157: No API Documentation on Listing Custom User
> Templates Using CS4 API
> 
> Updated API documentation for listTemplates command, including:
> - Added missing options to description
> - Updated descriptions to be in line with listISos API command
> 
> 
> This addresses bug CLOUDSTACK-1157.
> 
> 
> Diffs
> -----
> 
> 
> api/src/org/apache/cloudstack/api/command/user/template/ListTemplates
> Cmd.java c48534e
> 
> Diff: https://reviews.apache.org/r/9902/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Grizzanti

Re: Review Request: CLOUDSTACK-1157: No API Documentation on Listing Custom User Templates Using CS4 API

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9902/#review17931
-----------------------------------------------------------


Commit e30c90ba74830476d0cd811807b5164bce16517f in branch refs/heads/4.1 from Chip Childers <ch...@gmail.com>
[ https://git-wip-us.apache.org/repos/asf?p=incubator-cloudstack.git;h=e30c90b ]

CLOUDSTACK-1157 updated API documentation for listTemplates command; fixed description of templateFilter parameter to all 7 options (in line with listIsos API cmd)


- ASF Subversion and Git Services


On March 13, 2013, 3:04 p.m., David Grizzanti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9902/
> -----------------------------------------------------------
> 
> (Updated March 13, 2013, 3:04 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> CLOUDSTACK-1157: No API Documentation on Listing Custom User Templates Using CS4 API
> 
> Updated API documentation for listTemplates command, including:
> - Added missing options to description
> - Updated descriptions to be in line with listISos API command
> 
> 
> This addresses bug CLOUDSTACK-1157.
> 
> 
> Diffs
> -----
> 
>   api/src/org/apache/cloudstack/api/command/user/template/ListTemplatesCmd.java c48534e 
> 
> Diff: https://reviews.apache.org/r/9902/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Grizzanti
> 
>