You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by tinkoff-dwh <gi...@git.apache.org> on 2017/06/29 06:09:16 UTC
[GitHub] zeppelin pull request #2449: [Zeppelin-2676]
GitHub user tinkoff-dwh opened a pull request:
https://github.com/apache/zeppelin/pull/2449
[Zeppelin-2676]
### What is this PR for?
Adding recent notes feature: every user now can see his recent notes on homepage. Also you can add recent list on your custom home page.
### What type of PR is it?
Feature
### Todos
### What is the Jira issue?
https://issues.apache.org/jira/projects/ZEPPELIN/issues/ZEPPELIN-2676
### How should this be tested?
Go to homepage. Open some note. Return to homepage. This note has appeared in recent list.
If you open note, which is already in recent list, this note move to the beginning of the recent list.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? Yes (for add recent list to custom homepage) (done)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tinkoff-dwh/zeppelin ZEPPELIN-2676
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2449.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2449
----
commit fe2bf162b56180aa21a8e104c3f8fde41e238217
Author: tinkoff-dwh <ti...@gmail.com>
Date: 2017-06-22T11:57:38Z
add last viewed (recent) notes feature
commit 1cb5deb4625df3961809dfbcfd30836722c166df
Author: tinkoff-dwh <ti...@gmail.com>
Date: 2017-06-26T08:03:59Z
fix bugs, refactor
commit 788e043703ed3f882b5997cebf92a10c3f3ba639
Author: tinkoff-dwh <ti...@gmail.com>
Date: 2017-06-27T06:34:45Z
fix errors, add test
commit e339b3c65bcb860cf9f43c2c93581969649a84ae
Author: tinkoff-dwh <ti...@gmail.com>
Date: 2017-06-28T07:54:15Z
add tests, fix no license
commit 6e7165c2f11a73ea049f2f978faea16cf2b58c5a
Author: tinkoff-dwh <ti...@gmail.com>
Date: 2017-06-28T11:52:44Z
add adding recent to custom page feature
commit 92a6aab2c754598fac5eabe02e7eba1ebf38a2d1
Author: tinkoff-dwh <ti...@gmail.com>
Date: 2017-06-28T12:08:43Z
add docs to adding recent notes in custom homepage
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2449: [Zeppelin-2676] recent notes list
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2449
Ready to review
---
[GitHub] zeppelin issue #2449: [Zeppelin-2676] recent notes list
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2449
@1ambda @zjffdu
Thank you for your comments. Classes have been renamed to match its functionality
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2449: [Zeppelin-2676] recent notes list
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh closed the pull request at:
https://github.com/apache/zeppelin/pull/2449
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2449: [Zeppelin-2676] recent notes list
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2449
Ready to review
---
[GitHub] zeppelin issue #2449: [Zeppelin-2676] recent notes list
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2449
Ready to review
---
[GitHub] zeppelin issue #2449: [Zeppelin-2676] recent notes list
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2449
Ready to review
---
[GitHub] zeppelin issue #2449: [Zeppelin-2676] recent notes list
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2449
I have a suggestion.
- Place `Recent` before `Notebook` (more upper side)
- Limit the maximum number of recent notebooks.
That's because users are accessing recent notebook more and
if there are lots of notebooks, the recent menu will not be seen without scrolling
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2449: [Zeppelin-2676] recent notes list
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2449
Ready to review
---
[GitHub] zeppelin issue #2449: [Zeppelin-2676] recent notes list
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2449
Ready to review (red for other tests )
---
[GitHub] zeppelin issue #2449: [Zeppelin-2676] recent notes list
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2449
Ready to review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2449: [Zeppelin-2676] recent notes list
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2449
Need rework.
---
[GitHub] zeppelin issue #2449: [Zeppelin-2676] recent notes list
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2449
Ready to review
---
[GitHub] zeppelin issue #2449: [Zeppelin-2676] recent notes list
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2449
Ready to review
---
[GitHub] zeppelin issue #2449: [Zeppelin-2676] recent notes list
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2449
Ready to review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2449: [Zeppelin-2676] recent notes list
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2449
Ready to review
---
[GitHub] zeppelin pull request #2449: [Zeppelin-2676] recent notes list
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh closed the pull request at:
https://github.com/apache/zeppelin/pull/2449
---
[GitHub] zeppelin pull request #2449: [Zeppelin-2676] recent notes list
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh closed the pull request at:
https://github.com/apache/zeppelin/pull/2449
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2449: [Zeppelin-2676] recent notes list
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2449
Ready to review
---
[GitHub] zeppelin pull request #2449: [Zeppelin-2676] recent notes list
Posted by tinkoff-dwh <gi...@git.apache.org>.
GitHub user tinkoff-dwh reopened a pull request:
https://github.com/apache/zeppelin/pull/2449
[Zeppelin-2676] recent notes list
### What is this PR for?
Adding recent notes feature: every user now can see his recent notes on homepage. Also you can add recent list on your custom home page.
### What type of PR is it?
Feature
### Todos
### What is the Jira issue?
https://issues.apache.org/jira/projects/ZEPPELIN/issues/ZEPPELIN-2676
### How should this be tested?
Go to homepage. Open some note. Return to homepage. This note has appeared in recent list.
If you open note, which is already in recent list, this note move to the beginning of the recent list.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? Yes (for add recent list to custom homepage) (done)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tinkoff-dwh/zeppelin ZEPPELIN-2676
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2449.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2449
----
commit fe2bf162b56180aa21a8e104c3f8fde41e238217
Author: tinkoff-dwh <ti...@gmail.com>
Date: 2017-06-22T11:57:38Z
add last viewed (recent) notes feature
commit 1cb5deb4625df3961809dfbcfd30836722c166df
Author: tinkoff-dwh <ti...@gmail.com>
Date: 2017-06-26T08:03:59Z
fix bugs, refactor
commit 788e043703ed3f882b5997cebf92a10c3f3ba639
Author: tinkoff-dwh <ti...@gmail.com>
Date: 2017-06-27T06:34:45Z
fix errors, add test
commit e339b3c65bcb860cf9f43c2c93581969649a84ae
Author: tinkoff-dwh <ti...@gmail.com>
Date: 2017-06-28T07:54:15Z
add tests, fix no license
commit 6e7165c2f11a73ea049f2f978faea16cf2b58c5a
Author: tinkoff-dwh <ti...@gmail.com>
Date: 2017-06-28T11:52:44Z
add adding recent to custom page feature
commit 92a6aab2c754598fac5eabe02e7eba1ebf38a2d1
Author: tinkoff-dwh <ti...@gmail.com>
Date: 2017-06-28T12:08:43Z
add docs to adding recent notes in custom homepage
commit 5bd71f3286031c748f0b7439485e59afce012e2a
Author: tinkoff-dwh <ti...@gmail.com>
Date: 2017-06-29T07:10:44Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2676
commit 2b53a67ef7b0c548b33e0b4e98eee3508c725e32
Author: tinkoff-dwh <ti...@gmail.com>
Date: 2017-07-07T06:59:33Z
place recent notes before notebook
commit 372f1b36d1f71be7a5be079e06ebe3c9c783adcd
Author: tinkoff-dwh <ti...@gmail.com>
Date: 2017-07-20T06:19:30Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2676
# Conflicts:
# zeppelin-web/src/app/home/home.controller.js
# zeppelin-web/src/app/notebook/notebook.controller.js
# zeppelin-zengine/src/main/java/org/apache/zeppelin/conf/ZeppelinConfiguration.java
commit 89c2cb0ff2cfce9c8336919310c65b3de280e036
Author: tinkoff-dwh <ti...@gmail.com>
Date: 2017-07-24T06:20:46Z
fix tests
commit 7ce74d1e7daba19a0a122d217ec7fad5393e796f
Author: tinkoff-dwh <ti...@gmail.com>
Date: 2017-07-24T06:21:18Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2676
commit 13800a927eea5ff0e6a8bc17b3d5637b318126cc
Author: tinkoff-dwh <ti...@gmail.com>
Date: 2017-08-14T12:16:33Z
fix the way to show recent notes on custom homepage
commit 9165cd7464c49cd39833557a69ebe8be357a95e1
Author: tinkoff-dwh <ti...@gmail.com>
Date: 2017-08-15T09:01:44Z
fix unused argument
commit a6d5521461f4512a29493cf7a50a409526f6afa7
Author: tinkoff-dwh <ti...@gmail.com>
Date: 2017-08-15T09:06:49Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2676
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2449: [Zeppelin-2676] recent notes list
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2449
I think we have a comment thread on this PR
https://github.com/apache/zeppelin/pull/2449#discussion_r127705438
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2449: [Zeppelin-2676] recent notes list
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2449
Ready to review
---
[GitHub] zeppelin issue #2449: [Zeppelin-2676] recent notes list
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2449
LGTM!
---
[GitHub] zeppelin issue #2449: [Zeppelin-2676] recent notes list
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2449
@1ambda
Number of recent is limited: `MAX_RECENT_SIZE = 10` (https://github.com/apache/zeppelin/pull/2449/files#diff-289945053c8adc894aa4838564528ba5)
Place `Recent` before `Notebook`: good idea, done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2449: [Zeppelin-2676] recent notes list
Posted by tinkoff-dwh <gi...@git.apache.org>.
GitHub user tinkoff-dwh reopened a pull request:
https://github.com/apache/zeppelin/pull/2449
[Zeppelin-2676] recent notes list
### What is this PR for?
Adding recent notes feature: every user now can see his recent notes on homepage. Also you can add recent list on your custom home page.
### What type of PR is it?
Feature
### Todos
### What is the Jira issue?
https://issues.apache.org/jira/projects/ZEPPELIN/issues/ZEPPELIN-2676
### How should this be tested?
Go to homepage. Open some note. Return to homepage. This note has appeared in recent list.
If you open note, which is already in recent list, this note move to the beginning of the recent list.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? Yes (for add recent list to custom homepage) (done)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tinkoff-dwh/zeppelin ZEPPELIN-2676
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2449.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2449
----
commit fe2bf162b56180aa21a8e104c3f8fde41e238217
Author: tinkoff-dwh <ti...@gmail.com>
Date: 2017-06-22T11:57:38Z
add last viewed (recent) notes feature
commit 1cb5deb4625df3961809dfbcfd30836722c166df
Author: tinkoff-dwh <ti...@gmail.com>
Date: 2017-06-26T08:03:59Z
fix bugs, refactor
commit 788e043703ed3f882b5997cebf92a10c3f3ba639
Author: tinkoff-dwh <ti...@gmail.com>
Date: 2017-06-27T06:34:45Z
fix errors, add test
commit e339b3c65bcb860cf9f43c2c93581969649a84ae
Author: tinkoff-dwh <ti...@gmail.com>
Date: 2017-06-28T07:54:15Z
add tests, fix no license
commit 6e7165c2f11a73ea049f2f978faea16cf2b58c5a
Author: tinkoff-dwh <ti...@gmail.com>
Date: 2017-06-28T11:52:44Z
add adding recent to custom page feature
commit 92a6aab2c754598fac5eabe02e7eba1ebf38a2d1
Author: tinkoff-dwh <ti...@gmail.com>
Date: 2017-06-28T12:08:43Z
add docs to adding recent notes in custom homepage
commit 5bd71f3286031c748f0b7439485e59afce012e2a
Author: tinkoff-dwh <ti...@gmail.com>
Date: 2017-06-29T07:10:44Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2676
commit 2b53a67ef7b0c548b33e0b4e98eee3508c725e32
Author: tinkoff-dwh <ti...@gmail.com>
Date: 2017-07-07T06:59:33Z
place recent notes before notebook
commit 372f1b36d1f71be7a5be079e06ebe3c9c783adcd
Author: tinkoff-dwh <ti...@gmail.com>
Date: 2017-07-20T06:19:30Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2676
# Conflicts:
# zeppelin-web/src/app/home/home.controller.js
# zeppelin-web/src/app/notebook/notebook.controller.js
# zeppelin-zengine/src/main/java/org/apache/zeppelin/conf/ZeppelinConfiguration.java
commit 89c2cb0ff2cfce9c8336919310c65b3de280e036
Author: tinkoff-dwh <ti...@gmail.com>
Date: 2017-07-24T06:20:46Z
fix tests
commit 7ce74d1e7daba19a0a122d217ec7fad5393e796f
Author: tinkoff-dwh <ti...@gmail.com>
Date: 2017-07-24T06:21:18Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2676
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2449: [Zeppelin-2676] recent notes list
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2449
Ready to review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2449: [Zeppelin-2676] recent notes list
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2449
@Leemoonsoo, @felixcheung, @zjffdu I think it's good to go.
Any concerns about backend code like persistency, ...?
---
[GitHub] zeppelin issue #2449: [Zeppelin-2676] recent notes list
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2449
Ready to review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---