You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2021/10/27 08:58:20 UTC

[GitHub] [sling-org-apache-sling-api] raducotescu opened a new pull request #37: SLING-10871 - Add builder API for request/resource objects

raducotescu opened a new pull request #37:
URL: https://github.com/apache/sling-org-apache-sling-api/pull/37


   * allow passing nulls to methods accepting only one parameter so that clients can still use fluid calls without doing null checks
   * adjusted tests to reflect the new behaviour


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-api] kwin commented on a change in pull request #37: SLING-10871 - Add builder API for request/resource objects

Posted by GitBox <gi...@apache.org>.
kwin commented on a change in pull request #37:
URL: https://github.com/apache/sling-org-apache-sling-api/pull/37#discussion_r737288078



##########
File path: src/main/java/org/apache/sling/api/request/builder/SlingHttpServletRequestBuilder.java
##########
@@ -65,13 +65,20 @@
     @NotNull SlingHttpServletRequestBuilder withSelectors(String ... selectors);
 
     /** 
-     * Sets the optional extension of the internal request, which influence
+     * Sets the optional extension of the internal request, which influences

Review comment:
       3rd person: https://github.com/apache/sling-org-apache-sling-api/pull/37/files/fd15fda2bda13c345ae60e6eaecd80d7c1c091d0#diff-e0169c70fb3053538791c0d57d20261027219fc959609cb2b8cce18152b960a4L68
   2nd person: https://github.com/apache/sling-org-apache-sling-api/pull/37/files/fd15fda2bda13c345ae60e6eaecd80d7c1c091d0#diff-e0169c70fb3053538791c0d57d20261027219fc959609cb2b8cce18152b960a4L76




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-api] sonarcloud[bot] commented on pull request #37: SLING-10871 - Add builder API for request/resource objects

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #37:
URL: https://github.com/apache/sling-org-apache-sling-api/pull/37#issuecomment-952731564


   SonarCloud Quality Gate failed.&nbsp; &nbsp; ![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate failed')
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=BUG) [![C](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/C-16px.png 'C')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=BUG) [2 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=CODE_SMELL)
   
   [![84.2%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/60-16px.png '84.2%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-api&pullRequest=37&metric=new_coverage&view=list) [84.2% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-api&pullRequest=37&metric=new_coverage&view=list)  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-api&pullRequest=37&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-api&pullRequest=37&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-api] raducotescu commented on pull request #37: SLING-10871 - Add builder API for request/resource objects

Posted by GitBox <gi...@apache.org>.
raducotescu commented on pull request #37:
URL: https://github.com/apache/sling-org-apache-sling-api/pull/37#issuecomment-952863953


   Sorry, Carsten! I didn't see your comment before pushing my latest changes. The JavaDocs have been slightly reworded too. Let me know if I should revert this last commit.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-api] kwin commented on a change in pull request #37: SLING-10871 - Add builder API for request/resource objects

Posted by GitBox <gi...@apache.org>.
kwin commented on a change in pull request #37:
URL: https://github.com/apache/sling-org-apache-sling-api/pull/37#discussion_r737289970



##########
File path: src/main/java/org/apache/sling/api/request/builder/SlingHttpServletRequestBuilder.java
##########
@@ -65,13 +65,20 @@
     @NotNull SlingHttpServletRequestBuilder withSelectors(String ... selectors);
 
     /** 
-     * Sets the optional extension of the internal request, which influence
+     * Sets the optional extension of the internal request, which influences

Review comment:
       Right, still we should IMHO consolidate this in your PR as well.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-api] kwin commented on a change in pull request #37: SLING-10871 - Add builder API for request/resource objects

Posted by GitBox <gi...@apache.org>.
kwin commented on a change in pull request #37:
URL: https://github.com/apache/sling-org-apache-sling-api/pull/37#discussion_r737285005



##########
File path: src/main/java/org/apache/sling/api/request/builder/SlingHttpServletRequestBuilder.java
##########
@@ -65,13 +65,20 @@
     @NotNull SlingHttpServletRequestBuilder withSelectors(String ... selectors);
 
     /** 
-     * Sets the optional extension of the internal request, which influence
+     * Sets the optional extension of the internal request, which influences

Review comment:
       We should use either 3rd person or 2nd person, but not both, currrently we are mixing both forms in the same class. Oracle recommends using 3rd person:
   
   > Use 3rd person (descriptive) not 2nd person (prescriptive).
   > The description is in 3rd person declarative rather than 2nd person imperative.
   > 
   > Gets the label. (preferred)
   > 
   > Get the label. (avoid)
   
   (https://www.oracle.com/technical-resources/articles/java/javadoc-tool.html#styleguide)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-api] kwin commented on a change in pull request #37: SLING-10871 - Add builder API for request/resource objects

Posted by GitBox <gi...@apache.org>.
kwin commented on a change in pull request #37:
URL: https://github.com/apache/sling-org-apache-sling-api/pull/37#discussion_r737288078



##########
File path: src/main/java/org/apache/sling/api/request/builder/SlingHttpServletRequestBuilder.java
##########
@@ -65,13 +65,20 @@
     @NotNull SlingHttpServletRequestBuilder withSelectors(String ... selectors);
 
     /** 
-     * Sets the optional extension of the internal request, which influence
+     * Sets the optional extension of the internal request, which influences

Review comment:
       3rd person: https://github.com/apache/sling-org-apache-sling-api/pull/37/files/fd15fda2bda13c345ae60e6eaecd80d7c1c091d0#diff-e0169c70fb3053538791c0d57d20261027219fc959609cb2b8cce18152b960a4L68
   1st person: https://github.com/apache/sling-org-apache-sling-api/pull/37/files/fd15fda2bda13c345ae60e6eaecd80d7c1c091d0#diff-e0169c70fb3053538791c0d57d20261027219fc959609cb2b8cce18152b960a4L76




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-api] sonarcloud[bot] edited a comment on pull request #37: SLING-10871 - Add builder API for request/resource objects

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] edited a comment on pull request #37:
URL: https://github.com/apache/sling-org-apache-sling-api/pull/37#issuecomment-952900826


   SonarCloud Quality Gate failed.&nbsp; &nbsp; ![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed.svg 'Quality Gate failed')
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.svg 'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=BUG) [![C](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/C.svg 'C')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=BUG) [1 Bug](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.svg 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.svg 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.svg 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.svg 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.svg 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.svg 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=CODE_SMELL)
   
   [![87.5%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/60.svg '87.5%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-api&pullRequest=37&metric=new_coverage&view=list) [87.5% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-api&pullRequest=37&metric=new_coverage&view=list)  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.svg '0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-api&pullRequest=37&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-api&pullRequest=37&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-api] sonarcloud[bot] commented on pull request #37: SLING-10871 - Add builder API for request/resource objects

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #37:
URL: https://github.com/apache/sling-org-apache-sling-api/pull/37#issuecomment-952710646


   SonarCloud Quality Gate failed.&nbsp; &nbsp; ![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate failed')
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=BUG) [![C](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/C-16px.png 'C')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=BUG) [2 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=CODE_SMELL)
   
   [![84.2%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/60-16px.png '84.2%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-api&pullRequest=37&metric=new_coverage&view=list) [84.2% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-api&pullRequest=37&metric=new_coverage&view=list)  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-api&pullRequest=37&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-api&pullRequest=37&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-api] sonarcloud[bot] removed a comment on pull request #37: SLING-10871 - Add builder API for request/resource objects

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] removed a comment on pull request #37:
URL: https://github.com/apache/sling-org-apache-sling-api/pull/37#issuecomment-952710646


   SonarCloud Quality Gate failed.&nbsp; &nbsp; ![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate failed')
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=BUG) [![C](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/C-16px.png 'C')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=BUG) [2 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=CODE_SMELL)
   
   [![84.2%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/60-16px.png '84.2%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-api&pullRequest=37&metric=new_coverage&view=list) [84.2% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-api&pullRequest=37&metric=new_coverage&view=list)  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-api&pullRequest=37&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-api&pullRequest=37&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-api] sonarcloud[bot] removed a comment on pull request #37: SLING-10871 - Add builder API for request/resource objects

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] removed a comment on pull request #37:
URL: https://github.com/apache/sling-org-apache-sling-api/pull/37#issuecomment-952731564


   SonarCloud Quality Gate failed.&nbsp; &nbsp; ![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate failed')
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=BUG) [![C](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/C-16px.png 'C')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=BUG) [2 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=CODE_SMELL)
   
   [![84.2%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/60-16px.png '84.2%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-api&pullRequest=37&metric=new_coverage&view=list) [84.2% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-api&pullRequest=37&metric=new_coverage&view=list)  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-api&pullRequest=37&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-api&pullRequest=37&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-api] kwin commented on a change in pull request #37: SLING-10871 - Add builder API for request/resource objects

Posted by GitBox <gi...@apache.org>.
kwin commented on a change in pull request #37:
URL: https://github.com/apache/sling-org-apache-sling-api/pull/37#discussion_r737286238



##########
File path: src/main/java/org/apache/sling/api/request/builder/SlingHttpServletRequestBuilder.java
##########
@@ -94,9 +101,8 @@
      * Add the supplied request parameters to the current ones.
      * @param parameters Additional parameters

Review comment:
       add explicit "or {@code null}" or prefix with "Optional "




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-api] sonarcloud[bot] commented on pull request #37: SLING-10871 - Add builder API for request/resource objects

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #37:
URL: https://github.com/apache/sling-org-apache-sling-api/pull/37#issuecomment-952900826


   SonarCloud Quality Gate failed.&nbsp; &nbsp; ![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate failed')
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=BUG) [![C](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/C-16px.png 'C')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=BUG) [2 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=CODE_SMELL)
   
   [![87.5%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/60-16px.png '87.5%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-api&pullRequest=37&metric=new_coverage&view=list) [87.5% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-api&pullRequest=37&metric=new_coverage&view=list)  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-api&pullRequest=37&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-api&pullRequest=37&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-api] raducotescu commented on a change in pull request #37: SLING-10871 - Add builder API for request/resource objects

Posted by GitBox <gi...@apache.org>.
raducotescu commented on a change in pull request #37:
URL: https://github.com/apache/sling-org-apache-sling-api/pull/37#discussion_r737289086



##########
File path: src/main/java/org/apache/sling/api/request/builder/SlingHttpServletRequestBuilder.java
##########
@@ -65,13 +65,20 @@
     @NotNull SlingHttpServletRequestBuilder withSelectors(String ... selectors);
 
     /** 
-     * Sets the optional extension of the internal request, which influence
+     * Sets the optional extension of the internal request, which influences

Review comment:
       Right, but that's not related to my change.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-api] raducotescu commented on a change in pull request #37: SLING-10871 - Add builder API for request/resource objects

Posted by GitBox <gi...@apache.org>.
raducotescu commented on a change in pull request #37:
URL: https://github.com/apache/sling-org-apache-sling-api/pull/37#discussion_r737327781



##########
File path: src/main/java/org/apache/sling/api/request/builder/SlingHttpServletRequestBuilder.java
##########
@@ -94,9 +101,8 @@
      * Add the supplied request parameters to the current ones.
      * @param parameters Additional parameters

Review comment:
       What about adding `@Nullable` annotations?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-api] sonarcloud[bot] edited a comment on pull request #37: SLING-10871 - Add builder API for request/resource objects

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] edited a comment on pull request #37:
URL: https://github.com/apache/sling-org-apache-sling-api/pull/37#issuecomment-952900826


   Kudos, SonarCloud Quality Gate passed!&nbsp; &nbsp; ![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed.svg 'Quality Gate passed')
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.svg 'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.svg 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.svg 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.svg 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.svg 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.svg 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.svg 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.svg 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=37&resolved=false&types=CODE_SMELL)
   
   [![87.5%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/60.svg '87.5%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-api&pullRequest=37&metric=new_coverage&view=list) [87.5% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-api&pullRequest=37&metric=new_coverage&view=list)  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.svg '0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-api&pullRequest=37&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-api&pullRequest=37&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-api] raducotescu merged pull request #37: SLING-10871 - Add builder API for request/resource objects

Posted by GitBox <gi...@apache.org>.
raducotescu merged pull request #37:
URL: https://github.com/apache/sling-org-apache-sling-api/pull/37


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-api] cziegeler commented on pull request #37: SLING-10871 - Add builder API for request/resource objects

Posted by GitBox <gi...@apache.org>.
cziegeler commented on pull request #37:
URL: https://github.com/apache/sling-org-apache-sling-api/pull/37#issuecomment-952789131


   PR looks good in general, we can fine tune javadoc etc. separately if required. Using Nullable makes sense


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-api] cziegeler commented on pull request #37: SLING-10871 - Add builder API for request/resource objects

Posted by GitBox <gi...@apache.org>.
cziegeler commented on pull request #37:
URL: https://github.com/apache/sling-org-apache-sling-api/pull/37#issuecomment-952867023


   @raducotescu no worries, thats fine; I just didn't want to block this PR by fine tuning javadocs, but if this is done now even better


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-api] raducotescu commented on a change in pull request #37: SLING-10871 - Add builder API for request/resource objects

Posted by GitBox <gi...@apache.org>.
raducotescu commented on a change in pull request #37:
URL: https://github.com/apache/sling-org-apache-sling-api/pull/37#discussion_r737286707



##########
File path: src/main/java/org/apache/sling/api/request/builder/SlingHttpServletRequestBuilder.java
##########
@@ -65,13 +65,20 @@
     @NotNull SlingHttpServletRequestBuilder withSelectors(String ... selectors);
 
     /** 
-     * Sets the optional extension of the internal request, which influence
+     * Sets the optional extension of the internal request, which influences

Review comment:
       I don't see where the person is mixed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org