You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by robertamarton <gi...@git.apache.org> on 2015/11/11 18:34:14 UTC
[GitHub] incubator-trafodion pull request: Trafodion-1612 and Trafodion-161...
GitHub user robertamarton opened a pull request:
https://github.com/apache/incubator-trafodion/pull/170
Trafodion-1612 and Trafodion-1613
1612: Stop building HBase-trx for MAPR, due to instable Maven repository
- removed mapr from the build_all step in the hbase_trx Makefile, we now create
6 jar files instead of 7
1613: build failing due to mismatched Maven downloads
When building Trafodion from source objects, Maven is required. It is not
possible to download Maven from yum, instead it needs to be installed. There
are a few problems related to how Maven is managed with Trafodion builds.
- In many environments, Maven is already installed. The check to see if Maven
is already installed is commented out in traf_tools_setup.sh. This has been
fixed.
- Today, sqenvcom.sh checks to see if mvn is installed, if not, it sets it to
version 3.0.5 but we install 3.3.3. Changed the code to return an error:
"ERROR unable to find mvn (MAVEN) in path" to inform the user that mvn needs
to be added to the path before building. An error is also returned during
the build (make) if mvn is not found in the path.
- As part of the above change, it was noted that many of the tools were being
set to the value of $TOOLSDIR when $TOOLSDIR may not be set. Checks were
added to see if the environment variable was already set. This allows
someone to specify a different location for these tools as described in the
additional build tools wiki page.
- Changed the output returned in bldenvchk.sh. BISON does not have to be in
the path but needs to be specified correctly in the environment variable.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertamarton/incubator-trafodion releaseb
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafodion/pull/170.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #170
----
commit 1ff1fa25264ea92d77950328d81a6eb9b3076ab0
Author: Roberta Marton <ro...@esgyn.com>
Date: 2015-11-11T01:40:44Z
Trafodion-1612 and Trafodion-1613
1612: Stop building HBase-trx for MAPR, due to instable Maven repository
- removed mapr from the build_all step in the hbase_trx Makefile, we now create
6 jar files instead of 7
1613: build failing due to mismatched Maven downloads
When building Trafodion from source objects, Maven is required. It is not
possible to download Maven from yum, instead it needs to be installed. There
are a few problems related to how Maven is managed with Trafodion builds.
- In many environments, Maven is already installed. The check to see if Maven
is already installed is commented out in traf_tools_setup.sh. This has been
fixed.
- Today, sqenvcom.sh checks to see if mvn is installed, if not, it sets it to
version 3.0.5 but we install 3.3.3. Changed the code to return an error:
"ERROR unable to find mvn (MAVEN) in path" to inform the user that mvn needs
to be added to the path before building. An error is also returned during
the build (make) if mvn is not found in the path.
- As part of the above change, it was noted that many of the tools were being
set to the value of $TOOLSDIR when $TOOLSDIR may not be set. Checks were
added to see if the environment variable was already set. This allows
someone to specify a different location for these tools as described in the
additional build tools wiki page.
- Changed the output returned in bldenvchk.sh. BISON does not have to be in
the path but needs to be specified correctly in the environment variable.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: Trafodion-1612 and Trafodion-161...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafodion/pull/170
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---