You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2018/04/09 18:36:49 UTC
[kudu-CR] itests: add NO FATALS in a few places
Hello Mike Percy,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/9955
to review the following change.
Change subject: itests: add NO_FATALS in a few places
......................................................................
itests: add NO_FATALS in a few places
Saw this when I was triaging the following test failure:
F0407 11:28:52.857076 17095 master_main.cc:74] Check failed: <elided>
F0407 11:28:52.873128 17085 external_mini_cluster.cc:675] Check failed: !masters_.empty()
*** Check failure stack trace: ***
@ 0x7f2cbac6e31d google::LogMessage::Fail() at ??:0
@ 0x7f2cbac701dd google::LogMessage::SendToLog() at ??:0
@ 0x7f2cbac6de59 google::LogMessage::Flush() at ??:0
@ 0x7f2cbac70c7f google::LogMessageFatal::~LogMessageFatal() at ??:0
@ 0x7f2ccf8be554 kudu::cluster::ExternalMiniCluster::CreateClient() at ??:0
@ 0x59f35f kudu::LinkedListTest::ResetClientAndTester()
@ 0x58deba kudu::LinkedListTest::BuildAndStart()
@ 0x57fbc3 kudu::LinkedListTest_TestLoadAndVerify_Test::TestBody()
The first failure should have stopped the rest of the test from running, but
it didn't due to missing NO_FATALS checks.
Change-Id: I5fe0c7dce79cdb8489a860b0b0b5f3a95cfb2cc0
---
M src/kudu/integration-tests/linked_list-test.cc
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/integration-tests/raft_consensus_election-itest.cc
3 files changed, 13 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/55/9955/1
--
To view, visit http://gerrit.cloudera.org:8080/9955
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5fe0c7dce79cdb8489a860b0b0b5f3a95cfb2cc0
Gerrit-Change-Number: 9955
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] itests: add NO FATALS in a few places
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9955 )
Change subject: itests: add NO_FATALS in a few places
......................................................................
itests: add NO_FATALS in a few places
Saw this when I was triaging the following test failure:
F0407 11:28:52.857076 17095 master_main.cc:74] Check failed: <elided>
F0407 11:28:52.873128 17085 external_mini_cluster.cc:675] Check failed: !masters_.empty()
*** Check failure stack trace: ***
@ 0x7f2cbac6e31d google::LogMessage::Fail() at ??:0
@ 0x7f2cbac701dd google::LogMessage::SendToLog() at ??:0
@ 0x7f2cbac6de59 google::LogMessage::Flush() at ??:0
@ 0x7f2cbac70c7f google::LogMessageFatal::~LogMessageFatal() at ??:0
@ 0x7f2ccf8be554 kudu::cluster::ExternalMiniCluster::CreateClient() at ??:0
@ 0x59f35f kudu::LinkedListTest::ResetClientAndTester()
@ 0x58deba kudu::LinkedListTest::BuildAndStart()
@ 0x57fbc3 kudu::LinkedListTest_TestLoadAndVerify_Test::TestBody()
The first failure should have stopped the rest of the test from running, but
it didn't due to missing NO_FATALS checks.
Change-Id: I5fe0c7dce79cdb8489a860b0b0b5f3a95cfb2cc0
Reviewed-on: http://gerrit.cloudera.org:8080/9955
Tested-by: Kudu Jenkins
Reviewed-by: Mike Percy <mp...@apache.org>
---
M src/kudu/integration-tests/linked_list-test.cc
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/integration-tests/raft_consensus_election-itest.cc
3 files changed, 13 insertions(+), 12 deletions(-)
Approvals:
Kudu Jenkins: Verified
Mike Percy: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/9955
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5fe0c7dce79cdb8489a860b0b0b5f3a95cfb2cc0
Gerrit-Change-Number: 9955
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] itests: add NO FATALS in a few places
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9955 )
Change subject: itests: add NO_FATALS in a few places
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9955
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5fe0c7dce79cdb8489a860b0b0b5f3a95cfb2cc0
Gerrit-Change-Number: 9955
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Mon, 09 Apr 2018 19:06:45 +0000
Gerrit-HasComments: No