You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kyuubi.apache.org by "ulysses-you (via GitHub)" <gi...@apache.org> on 2023/01/30 11:34:25 UTC
[GitHub] [kyuubi-docker] ulysses-you opened a new pull request, #1: Initial docker file
ulysses-you opened a new pull request, #1:
URL: https://github.com/apache/kyuubi-docker/pull/1
The process of release docker image is:
1. Make sure Kyuubi has released a new version
2. Submit a pull request to update the `release_version` file to the new version
3. After pull request merged. Push a new tag.
4. After new tag created, github action will trigger a workflow to build and push new image to dockerhub
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kyuubi-docker] ulysses-you commented on a diff in pull request #1: Initial docker file
Posted by "ulysses-you (via GitHub)" <gi...@apache.org>.
ulysses-you commented on code in PR #1:
URL: https://github.com/apache/kyuubi-docker/pull/1#discussion_r1091376063
##########
.github/workflows/docker-image.yml:
##########
@@ -0,0 +1,58 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: Publish Docker image
+
+on:
+ push:
+ tags:
+ - '*'
+
+jobs:
+ push_to_registry:
+ name: Push Docker image to Docker Hub
+ if: ${{ startsWith(github.repository, 'apache/') }}
+ runs-on: ubuntu-22.04
+ strategy:
+ matrix:
+ include:
+ - suffix-name: ''
+ opts: '--flink-provided --spark-provided --hive-provided'
+ - suffix-name: '-spark'
+ opts: '--flink-provided --hive-provided'
+ - suffix-name: '-flink'
+ opts: '--spark-provided --hive-provided'
+ - suffix-name: '-all'
+ opts: ''
+ steps:
+ - name: Checkout
+ uses: actions/checkout@v3
+ - name: Login to Docker Hub
+ uses: docker/login-action@v2
+ with:
+ username: ${{ secrets.DOCKERHUB_USER }}
+ password: ${{ secrets.DOCKERHUB_TOKEN }}
+ - name: Build Kyuubi Docker Image
+ run: |
+ wget -O kyuubi.tgz https://archive.apache.org/dist/kyuubi/kyuubi-$(cat release/release_version)/apache-kyuubi-$(cat release/release_version)-source.tgz
+ tar -xvf kyuubi.tgz --strip-components=1
+ ./build/dist ${{ matrix.opts }} -Dmaven.javadoc.skip=true -Dmaven.scaladoc.skip=true -Drat.skip=true -Dscalastyle.skip=true -Dspotless.check.skip -DskipTests
+ docker build --tag apache/kyuubi:$(cat release/release_version)${{ matrix.suffix-name }} --file $(cat release/release_version)/*/Dockerfile .
+ - name: Validate docker image
+ run: docker images
+ - name: Push Docker image
+ run: docker push apache/kyuubi:$(cat release/release_version)${{ matrix.suffix-name }}
Review Comment:
using command is easy for testing at local.. does that action contains some feautre ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kyuubi-docker] bowenliang123 commented on a diff in pull request #1: Initial docker file
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 commented on code in PR #1:
URL: https://github.com/apache/kyuubi-docker/pull/1#discussion_r1091342466
##########
.github/workflows/docker-image.yml:
##########
@@ -0,0 +1,58 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: Publish Docker image
+
+on:
+ push:
+ tags:
+ - '*'
+
+jobs:
+ push_to_registry:
+ name: Push Docker image to Docker Hub
+ if: ${{ startsWith(github.repository, 'apache/') }}
+ runs-on: ubuntu-22.04
+ strategy:
+ matrix:
+ include:
+ - suffix-name: ''
+ opts: '--flink-provided --spark-provided --hive-provided'
+ - suffix-name: '-spark'
+ opts: '--flink-provided --hive-provided'
+ - suffix-name: '-flink'
+ opts: '--spark-provided --hive-provided'
+ - suffix-name: '-all'
+ opts: ''
+ steps:
+ - name: Checkout
+ uses: actions/checkout@v3
+ - name: Login to Docker Hub
+ uses: docker/login-action@v2
+ with:
+ username: ${{ secrets.DOCKERHUB_USER }}
+ password: ${{ secrets.DOCKERHUB_TOKEN }}
+ - name: Build Kyuubi Docker Image
+ run: |
+ wget -O kyuubi.tgz https://archive.apache.org/dist/kyuubi/kyuubi-$(cat release/release_version)/apache-kyuubi-$(cat release/release_version)-source.tgz
+ tar -xvf kyuubi.tgz --strip-components=1
+ ./build/dist ${{ matrix.opts }} -Dmaven.javadoc.skip=true -Dmaven.scaladoc.skip=true -Drat.skip=true -Dscalastyle.skip=true -Dspotless.check.skip -DskipTests
+ docker build --tag apache/kyuubi:$(cat release/release_version)${{ matrix.suffix-name }} --file $(cat release/release_version)/*/Dockerfile .
+ - name: Validate docker image
+ run: docker images
+ - name: Push Docker image
+ run: docker push apache/kyuubi:$(cat release/release_version)${{ matrix.suffix-name }}
Review Comment:
Why not use `docker/build-push-action` action for pushing images?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kyuubi-docker] ulysses-you commented on a diff in pull request #1: Initial docker file
Posted by "ulysses-you (via GitHub)" <gi...@apache.org>.
ulysses-you commented on code in PR #1:
URL: https://github.com/apache/kyuubi-docker/pull/1#discussion_r1091518891
##########
.github/workflows/docker-image.yml:
##########
@@ -0,0 +1,58 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: Publish Docker image
+
+on:
+ push:
+ tags:
+ - '*'
+
+jobs:
+ push_to_registry:
+ name: Push Docker image to Docker Hub
+ if: ${{ startsWith(github.repository, 'apache/') }}
+ runs-on: ubuntu-22.04
+ strategy:
+ matrix:
+ include:
+ - suffix-name: ''
+ opts: '--flink-provided --spark-provided --hive-provided'
+ - suffix-name: '-spark'
+ opts: '--flink-provided --hive-provided'
+ - suffix-name: '-flink'
+ opts: '--spark-provided --hive-provided'
+ - suffix-name: '-all'
+ opts: ''
+ steps:
+ - name: Checkout
+ uses: actions/checkout@v3
+ - name: Login to Docker Hub
+ uses: docker/login-action@v2
+ with:
+ username: ${{ secrets.DOCKERHUB_USER }}
+ password: ${{ secrets.DOCKERHUB_TOKEN }}
+ - name: Build Kyuubi Docker Image
+ run: |
+ wget -O kyuubi.tgz https://archive.apache.org/dist/kyuubi/kyuubi-$(cat release/release_version)/apache-kyuubi-$(cat release/release_version)-source.tgz
+ tar -xvf kyuubi.tgz --strip-components=1
+ ./build/dist ${{ matrix.opts }} -Dmaven.javadoc.skip=true -Dmaven.scaladoc.skip=true -Drat.skip=true -Dscalastyle.skip=true -Dspotless.check.skip -DskipTests
+ docker build --tag apache/kyuubi:$(cat release/release_version)${{ matrix.suffix-name }} --file $(cat release/release_version)/*/Dockerfile .
Review Comment:
I changed the context to `dist` to narrow the unexpected behavior in dockerfile.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi-docker] zwangsheng commented on a diff in pull request #1: Initial docker file
Posted by "zwangsheng (via GitHub)" <gi...@apache.org>.
zwangsheng commented on code in PR #1:
URL: https://github.com/apache/kyuubi-docker/pull/1#discussion_r1091343403
##########
.github/workflows/docker-image.yml:
##########
@@ -0,0 +1,58 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: Publish Docker image
+
+on:
+ push:
+ tags:
+ - '*'
+
+jobs:
+ push_to_registry:
+ name: Push Docker image to Docker Hub
+ if: ${{ startsWith(github.repository, 'apache/') }}
+ runs-on: ubuntu-22.04
+ strategy:
+ matrix:
+ include:
+ - suffix-name: ''
+ opts: '--flink-provided --spark-provided --hive-provided'
+ - suffix-name: '-spark'
+ opts: '--flink-provided --hive-provided'
+ - suffix-name: '-flink'
+ opts: '--spark-provided --hive-provided'
+ - suffix-name: '-all'
+ opts: ''
+ steps:
+ - name: Checkout
+ uses: actions/checkout@v3
+ - name: Login to Docker Hub
+ uses: docker/login-action@v2
+ with:
+ username: ${{ secrets.DOCKERHUB_USER }}
+ password: ${{ secrets.DOCKERHUB_TOKEN }}
+ - name: Build Kyuubi Docker Image
+ run: |
+ wget -O kyuubi.tgz https://archive.apache.org/dist/kyuubi/kyuubi-$(cat release/release_version)/apache-kyuubi-$(cat release/release_version)-source.tgz
+ tar -xvf kyuubi.tgz --strip-components=1
+ ./build/dist ${{ matrix.opts }} -Dmaven.javadoc.skip=true -Dmaven.scaladoc.skip=true -Drat.skip=true -Dscalastyle.skip=true -Dspotless.check.skip -DskipTests
+ docker build --tag apache/kyuubi:$(cat release/release_version)${{ matrix.suffix-name }} --file $(cat release/release_version)/*/Dockerfile .
Review Comment:
1. We need to think about reducing the scope of the docker context coverage, because Docker Daemon loads all the current directories (due to `.`) into the context, which can cause the build image to slow down.
##########
1.6.1-incubating/scala2.12-java8-ubuntu/Dockerfile:
##########
@@ -0,0 +1,31 @@
+FROM eclipse-temurin:8-jre
+
+ARG kyuubi_uid=10009
+
+USER root
+
+ENV KYUUBI_HOME /opt/kyuubi
+ENV KYUUBI_LOG_DIR ${KYUUBI_HOME}/logs
+ENV KYUUBI_PID_DIR ${KYUUBI_HOME}/pid
+ENV KYUUBI_WORK_DIR_ROOT ${KYUUBI_HOME}/work
+
+RUN set -ex; \
+ sed -i 's/http:\/\/deb.\(.*\)/https:\/\/deb.\1/g' /etc/apt/sources.list; && \
+ apt-get update && \
+ apt install -y wget bash tini libc6 libpam-modules krb5-user libnss3 procps; && \
+ mkdir -p ${KYUUBI_HOME} ${KYUUBI_LOG_DIR} ${KYUUBI_PID_DIR} ${KYUUBI_WORK_DIR_ROOT} && \
+ rm -rf /var/cache/apt/* && rm -rf /var/lib/apt/lists/*
+
+COPY dist ${KYUUBI_HOME}
+
+# setup kyuubi
+RUN set -ex && \
+ useradd -u ${kyuubi_uid} -g root kyuubi && \
Review Comment:
We should give `kyuubi` user home dir, such as `/home/kyuubi`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kyuubi-docker] ulysses-you commented on a diff in pull request #1: Initial docker file
Posted by "ulysses-you (via GitHub)" <gi...@apache.org>.
ulysses-you commented on code in PR #1:
URL: https://github.com/apache/kyuubi-docker/pull/1#discussion_r1091374352
##########
.github/workflows/docker-image.yml:
##########
@@ -0,0 +1,58 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: Publish Docker image
+
+on:
+ push:
+ tags:
+ - '*'
+
+jobs:
+ push_to_registry:
+ name: Push Docker image to Docker Hub
+ if: ${{ startsWith(github.repository, 'apache/') }}
+ runs-on: ubuntu-22.04
+ strategy:
+ matrix:
+ include:
+ - suffix-name: ''
+ opts: '--flink-provided --spark-provided --hive-provided'
+ - suffix-name: '-spark'
+ opts: '--flink-provided --hive-provided'
+ - suffix-name: '-flink'
+ opts: '--spark-provided --hive-provided'
+ - suffix-name: '-all'
+ opts: ''
+ steps:
+ - name: Checkout
+ uses: actions/checkout@v3
+ - name: Login to Docker Hub
+ uses: docker/login-action@v2
+ with:
+ username: ${{ secrets.DOCKERHUB_USER }}
+ password: ${{ secrets.DOCKERHUB_TOKEN }}
+ - name: Build Kyuubi Docker Image
+ run: |
+ wget -O kyuubi.tgz https://archive.apache.org/dist/kyuubi/kyuubi-$(cat release/release_version)/apache-kyuubi-$(cat release/release_version)-source.tgz
+ tar -xvf kyuubi.tgz --strip-components=1
+ ./build/dist ${{ matrix.opts }} -Dmaven.javadoc.skip=true -Dmaven.scaladoc.skip=true -Drat.skip=true -Dscalastyle.skip=true -Dspotless.check.skip -DskipTests
+ docker build --tag apache/kyuubi:$(cat release/release_version)${{ matrix.suffix-name }} --file $(cat release/release_version)/*/Dockerfile .
Review Comment:
Good point ! reduce the image size is always meaningful
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kyuubi-docker] pan3793 commented on a diff in pull request #1: Initial docker file
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #1:
URL: https://github.com/apache/kyuubi-docker/pull/1#discussion_r1090522239
##########
.github/workflows/docker-image.yml:
##########
@@ -0,0 +1,58 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: Publish Docker image
+
+on:
+ push:
+ tags:
+ - '*'
+
+jobs:
+ push_to_registry:
+ name: Push Docker image to Docker Hub
+ if: ${{ startsWith(github.repository, 'apache/') }}
+ runs-on: ubuntu-22.04
+ strategy:
+ matrix:
+ include:
+ - suffix-name: ''
+ opts: '--flink-provided --spark-provided --hive-provided'
+ - suffix-name: '-spark'
+ opts: '--flink-provided --hive-provided'
+ - suffix-name: '-flink'
+ opts: '--spark-provided --hive-provided'
+ - suffix-name: '-all'
+ opts: ''
+ steps:
+ - name: Checkout
+ uses: actions/checkout@v3
+ - name: Login to Docker Hub
+ uses: docker/login-action@v2
+ with:
+ username: ${{ secrets.DOCKERHUB_USER }}
+ password: ${{ secrets.DOCKERHUB_TOKEN }}
+ - name: Build Kyuubi Docker Image
+ run: |
+ wget -O kyuubi.tgz https://archive.apache.org/dist/kyuubi/kyuubi-$(cat release/release_version)/apache-kyuubi-$(cat release/release_version)-source.tgz
+ tar -xvf kyuubi.tgz --strip-components=1
+ ./build/dist ${{ matrix.opts }} -Dmaven.javadoc.skip=true -Dmaven.scaladoc.skip=true -Drat.skip=true -Dscalastyle.skip=true -Dspotless.check.skip -DskipTests
+ docker build --tag apache/kyuubi:$(cat release/release_version)${{ matrix.suffix-name }} --file $(cat release/release_version)/*/Dockerfile .
+ - name: Validate docker image
+ run: docker images
+ - name: Push Docker image
+ run: docker push apache/kyuubi:$(cat release/release_version)${{ matrix.suffix-name }}
Review Comment:
we can export a variable to reduce code duplication
`IMAGE_TAG=$(cat release/release_version)${{ matrix.suffix-name }}`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kyuubi-docker] ulysses-you commented on a diff in pull request #1: Initial docker file
Posted by "ulysses-you (via GitHub)" <gi...@apache.org>.
ulysses-you commented on code in PR #1:
URL: https://github.com/apache/kyuubi-docker/pull/1#discussion_r1091518385
##########
.github/workflows/docker-image.yml:
##########
@@ -0,0 +1,58 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: Publish Docker image
+
+on:
+ push:
+ tags:
+ - '*'
+
+jobs:
+ push_to_registry:
+ name: Push Docker image to Docker Hub
+ if: ${{ startsWith(github.repository, 'apache/') }}
+ runs-on: ubuntu-22.04
+ strategy:
+ matrix:
+ include:
+ - suffix-name: ''
+ opts: '--flink-provided --spark-provided --hive-provided'
+ - suffix-name: '-spark'
+ opts: '--flink-provided --hive-provided'
+ - suffix-name: '-flink'
+ opts: '--spark-provided --hive-provided'
+ - suffix-name: '-all'
+ opts: ''
+ steps:
+ - name: Checkout
+ uses: actions/checkout@v3
+ - name: Login to Docker Hub
+ uses: docker/login-action@v2
+ with:
+ username: ${{ secrets.DOCKERHUB_USER }}
+ password: ${{ secrets.DOCKERHUB_TOKEN }}
+ - name: Build Kyuubi Docker Image
+ run: |
+ wget -O kyuubi.tgz https://archive.apache.org/dist/kyuubi/kyuubi-$(cat release/release_version)/apache-kyuubi-$(cat release/release_version)-source.tgz
+ tar -xvf kyuubi.tgz --strip-components=1
+ ./build/dist ${{ matrix.opts }} -Dmaven.javadoc.skip=true -Dmaven.scaladoc.skip=true -Drat.skip=true -Dscalastyle.skip=true -Dspotless.check.skip -DskipTests
+ docker build --tag apache/kyuubi:$(cat release/release_version)${{ matrix.suffix-name }} --file $(cat release/release_version)/*/Dockerfile .
+ - name: Validate docker image
+ run: docker images
+ - name: Push Docker image
+ run: docker push apache/kyuubi:$(cat release/release_version)${{ matrix.suffix-name }}
Review Comment:
not see the benefits... separate command to script and use github action just introduce complexity. We can improve the workflow in future if necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi-docker] cfmcgrady commented on a diff in pull request #1: Initial docker file
Posted by "cfmcgrady (via GitHub)" <gi...@apache.org>.
cfmcgrady commented on code in PR #1:
URL: https://github.com/apache/kyuubi-docker/pull/1#discussion_r1091360578
##########
.github/workflows/docker-image.yml:
##########
@@ -0,0 +1,58 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: Publish Docker image
+
+on:
+ push:
+ tags:
+ - '*'
+
+jobs:
+ push_to_registry:
+ name: Push Docker image to Docker Hub
+ if: ${{ startsWith(github.repository, 'apache/') }}
+ runs-on: ubuntu-22.04
+ strategy:
+ matrix:
+ include:
+ - suffix-name: ''
+ opts: '--flink-provided --spark-provided --hive-provided'
+ - suffix-name: '-spark'
+ opts: '--flink-provided --hive-provided'
+ - suffix-name: '-flink'
+ opts: '--spark-provided --hive-provided'
+ - suffix-name: '-all'
+ opts: ''
+ steps:
+ - name: Checkout
+ uses: actions/checkout@v3
+ - name: Login to Docker Hub
+ uses: docker/login-action@v2
+ with:
+ username: ${{ secrets.DOCKERHUB_USER }}
+ password: ${{ secrets.DOCKERHUB_TOKEN }}
+ - name: Build Kyuubi Docker Image
+ run: |
+ wget -O kyuubi.tgz https://archive.apache.org/dist/kyuubi/kyuubi-$(cat release/release_version)/apache-kyuubi-$(cat release/release_version)-source.tgz
+ tar -xvf kyuubi.tgz --strip-components=1
+ ./build/dist ${{ matrix.opts }} -Dmaven.javadoc.skip=true -Dmaven.scaladoc.skip=true -Drat.skip=true -Dscalastyle.skip=true -Dspotless.check.skip -DskipTests
+ docker build --tag apache/kyuubi:$(cat release/release_version)${{ matrix.suffix-name }} --file $(cat release/release_version)/*/Dockerfile .
Review Comment:
If we want to exclude some files or directories, `.dockerignore` is a good choice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kyuubi-docker] ulysses-you commented on pull request #1: Initial docker file
Posted by "ulysses-you (via GitHub)" <gi...@apache.org>.
ulysses-you commented on PR #1:
URL: https://github.com/apache/kyuubi-docker/pull/1#issuecomment-1418401194
I'm going to merge this pr. We can keep optimizing in future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi-docker] bowenliang123 commented on a diff in pull request #1: Initial docker file
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 commented on code in PR #1:
URL: https://github.com/apache/kyuubi-docker/pull/1#discussion_r1091393408
##########
.github/workflows/docker-image.yml:
##########
@@ -0,0 +1,58 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: Publish Docker image
+
+on:
+ push:
+ tags:
+ - '*'
+
+jobs:
+ push_to_registry:
+ name: Push Docker image to Docker Hub
+ if: ${{ startsWith(github.repository, 'apache/') }}
+ runs-on: ubuntu-22.04
+ strategy:
+ matrix:
+ include:
+ - suffix-name: ''
+ opts: '--flink-provided --spark-provided --hive-provided'
+ - suffix-name: '-spark'
+ opts: '--flink-provided --hive-provided'
+ - suffix-name: '-flink'
+ opts: '--spark-provided --hive-provided'
+ - suffix-name: '-all'
+ opts: ''
+ steps:
+ - name: Checkout
+ uses: actions/checkout@v3
+ - name: Login to Docker Hub
Review Comment:
OK. These actions are now used in kyuubi workflows as well, just to mention it.
And btw, where to tell the arch of image from the dockfile or comments we are releasing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kyuubi-docker] turboFei commented on a diff in pull request #1: Initial docker file
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on code in PR #1:
URL: https://github.com/apache/kyuubi-docker/pull/1#discussion_r1091377095
##########
release/release_version:
##########
@@ -0,0 +1 @@
+1.6.1-incubating
Review Comment:
nit: new line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kyuubi-docker] ulysses-you commented on a diff in pull request #1: Initial docker file
Posted by "ulysses-you (via GitHub)" <gi...@apache.org>.
ulysses-you commented on code in PR #1:
URL: https://github.com/apache/kyuubi-docker/pull/1#discussion_r1090510950
##########
release/DOI-Dockerfile.template:
##########
@@ -0,0 +1,44 @@
+FROM eclipse-temurin:8-jdk-focal
Review Comment:
this file is using source code build image which is for DOI, not used for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kyuubi-docker] ulysses-you commented on a diff in pull request #1: Initial docker file
Posted by "ulysses-you (via GitHub)" <gi...@apache.org>.
ulysses-you commented on code in PR #1:
URL: https://github.com/apache/kyuubi-docker/pull/1#discussion_r1090511140
##########
release/DOI-Dockerfile.template:
##########
@@ -0,0 +1,44 @@
+FROM eclipse-temurin:8-jdk-focal
Review Comment:
this docker file is using source code build image which is for DOI, not used for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kyuubi-docker] bowenliang123 commented on a diff in pull request #1: Initial docker file
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 commented on code in PR #1:
URL: https://github.com/apache/kyuubi-docker/pull/1#discussion_r1091386165
##########
1.6.1-incubating/scala2.12-java8-ubuntu/Dockerfile:
##########
@@ -0,0 +1,31 @@
+FROM eclipse-temurin:8-jre
Review Comment:
Well noticed. While we could still consider using the configuarble tag in this case. Or just use JDK for more general usages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kyuubi-docker] bowenliang123 commented on a diff in pull request #1: Initial docker file
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 commented on code in PR #1:
URL: https://github.com/apache/kyuubi-docker/pull/1#discussion_r1091342466
##########
.github/workflows/docker-image.yml:
##########
@@ -0,0 +1,58 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: Publish Docker image
+
+on:
+ push:
+ tags:
+ - '*'
+
+jobs:
+ push_to_registry:
+ name: Push Docker image to Docker Hub
+ if: ${{ startsWith(github.repository, 'apache/') }}
+ runs-on: ubuntu-22.04
+ strategy:
+ matrix:
+ include:
+ - suffix-name: ''
+ opts: '--flink-provided --spark-provided --hive-provided'
+ - suffix-name: '-spark'
+ opts: '--flink-provided --hive-provided'
+ - suffix-name: '-flink'
+ opts: '--spark-provided --hive-provided'
+ - suffix-name: '-all'
+ opts: ''
+ steps:
+ - name: Checkout
+ uses: actions/checkout@v3
+ - name: Login to Docker Hub
+ uses: docker/login-action@v2
+ with:
+ username: ${{ secrets.DOCKERHUB_USER }}
+ password: ${{ secrets.DOCKERHUB_TOKEN }}
+ - name: Build Kyuubi Docker Image
+ run: |
+ wget -O kyuubi.tgz https://archive.apache.org/dist/kyuubi/kyuubi-$(cat release/release_version)/apache-kyuubi-$(cat release/release_version)-source.tgz
+ tar -xvf kyuubi.tgz --strip-components=1
+ ./build/dist ${{ matrix.opts }} -Dmaven.javadoc.skip=true -Dmaven.scaladoc.skip=true -Drat.skip=true -Dscalastyle.skip=true -Dspotless.check.skip -DskipTests
+ docker build --tag apache/kyuubi:$(cat release/release_version)${{ matrix.suffix-name }} --file $(cat release/release_version)/*/Dockerfile .
+ - name: Validate docker image
+ run: docker images
+ - name: Push Docker image
+ run: docker push apache/kyuubi:$(cat release/release_version)${{ matrix.suffix-name }}
Review Comment:
Why not use `docker/build-push-action` action here for pushing images?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kyuubi-docker] ulysses-you commented on a diff in pull request #1: Initial docker file
Posted by "ulysses-you (via GitHub)" <gi...@apache.org>.
ulysses-you commented on code in PR #1:
URL: https://github.com/apache/kyuubi-docker/pull/1#discussion_r1091515987
##########
1.6.1-incubating/scala2.12-java8-ubuntu/Dockerfile:
##########
@@ -0,0 +1,31 @@
+FROM eclipse-temurin:8-jre
+
+ARG kyuubi_uid=10009
+
+USER root
+
+ENV KYUUBI_HOME /opt/kyuubi
+ENV KYUUBI_LOG_DIR ${KYUUBI_HOME}/logs
+ENV KYUUBI_PID_DIR ${KYUUBI_HOME}/pid
+ENV KYUUBI_WORK_DIR_ROOT ${KYUUBI_HOME}/work
+
+RUN set -ex; \
+ sed -i 's/http:\/\/deb.\(.*\)/https:\/\/deb.\1/g' /etc/apt/sources.list; && \
+ apt-get update && \
+ apt install -y wget bash tini libc6 libpam-modules krb5-user libnss3 procps; && \
+ mkdir -p ${KYUUBI_HOME} ${KYUUBI_LOG_DIR} ${KYUUBI_PID_DIR} ${KYUUBI_WORK_DIR_ROOT} && \
+ rm -rf /var/cache/apt/* && rm -rf /var/lib/apt/lists/*
+
+COPY dist ${KYUUBI_HOME}
+
+# setup kyuubi
+RUN set -ex && \
+ useradd -u ${kyuubi_uid} -g root kyuubi && \
Review Comment:
added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi-docker] zwangsheng commented on a diff in pull request #1: Initial docker file
Posted by "zwangsheng (via GitHub)" <gi...@apache.org>.
zwangsheng commented on code in PR #1:
URL: https://github.com/apache/kyuubi-docker/pull/1#discussion_r1091362886
##########
.github/workflows/docker-image.yml:
##########
@@ -0,0 +1,58 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: Publish Docker image
+
+on:
+ push:
+ tags:
+ - '*'
+
+jobs:
+ push_to_registry:
+ name: Push Docker image to Docker Hub
+ if: ${{ startsWith(github.repository, 'apache/') }}
+ runs-on: ubuntu-22.04
+ strategy:
+ matrix:
+ include:
+ - suffix-name: ''
+ opts: '--flink-provided --spark-provided --hive-provided'
+ - suffix-name: '-spark'
+ opts: '--flink-provided --hive-provided'
+ - suffix-name: '-flink'
+ opts: '--spark-provided --hive-provided'
+ - suffix-name: '-all'
+ opts: ''
+ steps:
+ - name: Checkout
+ uses: actions/checkout@v3
+ - name: Login to Docker Hub
+ uses: docker/login-action@v2
+ with:
+ username: ${{ secrets.DOCKERHUB_USER }}
+ password: ${{ secrets.DOCKERHUB_TOKEN }}
+ - name: Build Kyuubi Docker Image
+ run: |
+ wget -O kyuubi.tgz https://archive.apache.org/dist/kyuubi/kyuubi-$(cat release/release_version)/apache-kyuubi-$(cat release/release_version)-source.tgz
+ tar -xvf kyuubi.tgz --strip-components=1
+ ./build/dist ${{ matrix.opts }} -Dmaven.javadoc.skip=true -Dmaven.scaladoc.skip=true -Drat.skip=true -Dscalastyle.skip=true -Dspotless.check.skip -DskipTests
+ docker build --tag apache/kyuubi:$(cat release/release_version)${{ matrix.suffix-name }} --file $(cat release/release_version)/*/Dockerfile .
Review Comment:
Understand, but we can compare it side-by-side with build spark docker image in dev(source code) mode by `./bin/docker-image-tools.sh`.
> Create a smaller build context for docker in dev builds to make the build faster. Docker
> uploads all of the current directory to the daemon, and it can get pretty big with dev
> builds that contain test log files and other artifacts.
>
> Three build contexts are created, one for each image: base, pyspark, and sparkr. For them
> to have the desired effect, the docker command needs to be executed inside the appropriate
> context directory.
>
> Note: docker does not support symlinks in the build context.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kyuubi-docker] bowenliang123 commented on a diff in pull request #1: Initial docker file
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 commented on code in PR #1:
URL: https://github.com/apache/kyuubi-docker/pull/1#discussion_r1091335803
##########
1.6.1-incubating/scala2.12-java8-ubuntu/Dockerfile:
##########
@@ -0,0 +1,31 @@
+FROM eclipse-temurin:8-jre
Review Comment:
We could make it configurable as the way in Spark's official dockerfile.
1. jre by default
2. set from arg `java_image_tag`
https://github.com/apache/spark/blob/0db63df2b2829f1358fb711cd657a22b7838ece2/resource-managers/kubernetes/docker/src/main/dockerfiles/spark/Dockerfile#L17
```
ARG java_image_tag=17-jre
FROM eclipse-temurin:${java_image_tag}
```
##########
1.6.1-incubating/scala2.12-java8-ubuntu/Dockerfile:
##########
@@ -0,0 +1,31 @@
+FROM eclipse-temurin:8-jre
Review Comment:
We could make it configurable as the way in Spark's official dockerfile.
1. jre by default
2. set from arg `java_image_tag`
https://github.com/apache/spark/blob/main/resource-managers/kubernetes/docker/src/main/dockerfiles/spark/Dockerfile#L17
```
ARG java_image_tag=17-jre
FROM eclipse-temurin:${java_image_tag}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kyuubi-docker] ulysses-you commented on a diff in pull request #1: Initial docker file
Posted by "ulysses-you (via GitHub)" <gi...@apache.org>.
ulysses-you commented on code in PR #1:
URL: https://github.com/apache/kyuubi-docker/pull/1#discussion_r1091478539
##########
release/release_version:
##########
@@ -0,0 +1 @@
+1.6.1-incubating
Review Comment:
it's a config file.. no black line can safe our life
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi-docker] bowenliang123 commented on pull request #1: Initial docker file
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 commented on PR #1:
URL: https://github.com/apache/kyuubi-docker/pull/1#issuecomment-1409629470
[github/super-linter](https://github.com/github/super-linter) can be used for Dockerfile linting in future.
- it supports dockerfile linting integrating [hadolint](https://github.com/hadolint/hadolint)
- `github/*` is allowed in [Apache's GitHub action policy](https://infra.apache.org/github-actions-policy.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kyuubi-docker] ulysses-you merged pull request #1: Initial docker file
Posted by "ulysses-you (via GitHub)" <gi...@apache.org>.
ulysses-you merged PR #1:
URL: https://github.com/apache/kyuubi-docker/pull/1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi-docker] pan3793 commented on a diff in pull request #1: Initial docker file
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #1:
URL: https://github.com/apache/kyuubi-docker/pull/1#discussion_r1090513864
##########
.gitignore:
##########
@@ -0,0 +1,47 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+*#*#
+*.#*
+*.iml
+*.ipr
+*.iws
+*.pyc
+*.pyo
+*.swp
+*~
+.DS_Store
+.cache
+.classpath
+.ensime
+.ensime_cache/
+.ensime_lucene
+.generated-mima*
+.vscode/
+.idea/
+# The star is required for further !/.idea/ to work, see https://git-scm.com/docs/gitignore
+/.idea/*
+# Icon for JetBrains Toolbox
+!/.idea/icon.png
+!/.idea/vcs.xml
Review Comment:
let's remove L36-L40, it's useless
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kyuubi-docker] bowenliang123 commented on a diff in pull request #1: Initial docker file
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 commented on code in PR #1:
URL: https://github.com/apache/kyuubi-docker/pull/1#discussion_r1091382030
##########
.github/workflows/docker-image.yml:
##########
@@ -0,0 +1,58 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: Publish Docker image
+
+on:
+ push:
+ tags:
+ - '*'
+
+jobs:
+ push_to_registry:
+ name: Push Docker image to Docker Hub
+ if: ${{ startsWith(github.repository, 'apache/') }}
+ runs-on: ubuntu-22.04
+ strategy:
+ matrix:
+ include:
+ - suffix-name: ''
+ opts: '--flink-provided --spark-provided --hive-provided'
+ - suffix-name: '-spark'
+ opts: '--flink-provided --hive-provided'
+ - suffix-name: '-flink'
+ opts: '--spark-provided --hive-provided'
+ - suffix-name: '-all'
+ opts: ''
+ steps:
+ - name: Checkout
+ uses: actions/checkout@v3
+ - name: Login to Docker Hub
+ uses: docker/login-action@v2
+ with:
+ username: ${{ secrets.DOCKERHUB_USER }}
+ password: ${{ secrets.DOCKERHUB_TOKEN }}
+ - name: Build Kyuubi Docker Image
+ run: |
+ wget -O kyuubi.tgz https://archive.apache.org/dist/kyuubi/kyuubi-$(cat release/release_version)/apache-kyuubi-$(cat release/release_version)-source.tgz
+ tar -xvf kyuubi.tgz --strip-components=1
+ ./build/dist ${{ matrix.opts }} -Dmaven.javadoc.skip=true -Dmaven.scaladoc.skip=true -Drat.skip=true -Dscalastyle.skip=true -Dspotless.check.skip -DskipTests
+ docker build --tag apache/kyuubi:$(cat release/release_version)${{ matrix.suffix-name }} --file $(cat release/release_version)/*/Dockerfile .
+ - name: Validate docker image
+ run: docker images
+ - name: Push Docker image
+ run: docker push apache/kyuubi:$(cat release/release_version)${{ matrix.suffix-name }}
Review Comment:
With `docker/build-push-action`, potential benefits are,
- `kyuubi` is using this action in workflows
- use actions in config definition rather than command line code
- this action should have cover all the expected feature we want
- maybe better integration with `docker/setup-buildx-action` and `docker/setup-qemu-action`, as they are mentioned and recommended in docs of `docker/build-push-action`
For local build testing, we could provide another script for it, and it will be handy to run and modify locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kyuubi-docker] ulysses-you commented on a diff in pull request #1: Initial docker file
Posted by "ulysses-you (via GitHub)" <gi...@apache.org>.
ulysses-you commented on code in PR #1:
URL: https://github.com/apache/kyuubi-docker/pull/1#discussion_r1091519700
##########
1.6.1-incubating/scala2.12-java8-ubuntu/Dockerfile:
##########
@@ -0,0 +1,31 @@
+FROM eclipse-temurin:8-jre
Review Comment:
what do you think ? @cfmcgrady @turboFei @yaooqinn jre or jdk ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi-docker] ulysses-you commented on pull request #1: Initial docker file
Posted by "ulysses-you (via GitHub)" <gi...@apache.org>.
ulysses-you commented on PR #1:
URL: https://github.com/apache/kyuubi-docker/pull/1#issuecomment-1408471029
cc @yaooqinn @pan3793 @zwangsheng @hddong @yanghua @turboFei @cfmcgrady @cxzl25 and all. Any thought is welcome !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kyuubi-docker] bowenliang123 commented on a diff in pull request #1: Initial docker file
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 commented on code in PR #1:
URL: https://github.com/apache/kyuubi-docker/pull/1#discussion_r1091341543
##########
.github/workflows/docker-image.yml:
##########
@@ -0,0 +1,58 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: Publish Docker image
+
+on:
+ push:
+ tags:
+ - '*'
+
+jobs:
+ push_to_registry:
+ name: Push Docker image to Docker Hub
+ if: ${{ startsWith(github.repository, 'apache/') }}
+ runs-on: ubuntu-22.04
+ strategy:
+ matrix:
+ include:
+ - suffix-name: ''
+ opts: '--flink-provided --spark-provided --hive-provided'
+ - suffix-name: '-spark'
+ opts: '--flink-provided --hive-provided'
+ - suffix-name: '-flink'
+ opts: '--spark-provided --hive-provided'
+ - suffix-name: '-all'
+ opts: ''
+ steps:
+ - name: Checkout
+ uses: actions/checkout@v3
+ - name: Login to Docker Hub
Review Comment:
Set up docker buildx before login as well, as multi-platform image building is one of the important foreseeable features.
```
-
name: Set up QEMU
uses: docker/setup-qemu-action@v2
-
name: Set up Docker Buildx
uses: docker/setup-buildx-action@v2
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kyuubi-docker] bowenliang123 commented on a diff in pull request #1: Initial docker file
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 commented on code in PR #1:
URL: https://github.com/apache/kyuubi-docker/pull/1#discussion_r1091335803
##########
1.6.1-incubating/scala2.12-java8-ubuntu/Dockerfile:
##########
@@ -0,0 +1,31 @@
+FROM eclipse-temurin:8-jre
Review Comment:
We could make it configurable as the way in Spark's official dockerfile.
1. jre by default
2. set from arg `java_image_tag`
https://github.com/apache/spark/blob/master/resource-managers/kubernetes/docker/src/main/dockerfiles/spark/Dockerfile#L17
```
ARG java_image_tag=17-jre
FROM eclipse-temurin:${java_image_tag}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kyuubi-docker] ulysses-you commented on a diff in pull request #1: Initial docker file
Posted by "ulysses-you (via GitHub)" <gi...@apache.org>.
ulysses-you commented on code in PR #1:
URL: https://github.com/apache/kyuubi-docker/pull/1#discussion_r1091378604
##########
1.6.1-incubating/scala2.12-java8-ubuntu/Dockerfile:
##########
@@ -0,0 +1,31 @@
+FROM eclipse-temurin:8-jre
Review Comment:
@bowenliang123 it's not the Spark dockerfile.. see https://github.com/apache/spark-docker/blob/master/3.3.1/scala2.12-java11-ubuntu/Dockerfile
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kyuubi-docker] ulysses-you commented on a diff in pull request #1: Initial docker file
Posted by "ulysses-you (via GitHub)" <gi...@apache.org>.
ulysses-you commented on code in PR #1:
URL: https://github.com/apache/kyuubi-docker/pull/1#discussion_r1091332132
##########
.github/workflows/docker-image.yml:
##########
@@ -0,0 +1,58 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: Publish Docker image
+
+on:
+ push:
+ tags:
+ - '*'
+
+jobs:
+ push_to_registry:
+ name: Push Docker image to Docker Hub
+ if: ${{ startsWith(github.repository, 'apache/') }}
+ runs-on: ubuntu-22.04
+ strategy:
+ matrix:
+ include:
+ - suffix-name: ''
+ opts: '--flink-provided --spark-provided --hive-provided'
+ - suffix-name: '-spark'
+ opts: '--flink-provided --hive-provided'
+ - suffix-name: '-flink'
+ opts: '--spark-provided --hive-provided'
+ - suffix-name: '-all'
+ opts: ''
+ steps:
+ - name: Checkout
+ uses: actions/checkout@v3
+ - name: Login to Docker Hub
+ uses: docker/login-action@v2
+ with:
+ username: ${{ secrets.DOCKERHUB_USER }}
+ password: ${{ secrets.DOCKERHUB_TOKEN }}
+ - name: Build Kyuubi Docker Image
+ run: |
+ wget -O kyuubi.tgz https://archive.apache.org/dist/kyuubi/kyuubi-$(cat release/release_version)/apache-kyuubi-$(cat release/release_version)-source.tgz
+ tar -xvf kyuubi.tgz --strip-components=1
+ ./build/dist ${{ matrix.opts }} -Dmaven.javadoc.skip=true -Dmaven.scaladoc.skip=true -Drat.skip=true -Dscalastyle.skip=true -Dspotless.check.skip -DskipTests
+ docker build --tag apache/kyuubi:$(cat release/release_version)${{ matrix.suffix-name }} --file $(cat release/release_version)/*/Dockerfile .
+ - name: Validate docker image
+ run: docker images
+ - name: Push Docker image
+ run: docker push apache/kyuubi:$(cat release/release_version)${{ matrix.suffix-name }}
Review Comment:
seems the `export` does not support across steps and `env` does not support shell command
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kyuubi-docker] ulysses-you commented on a diff in pull request #1: Initial docker file
Posted by "ulysses-you (via GitHub)" <gi...@apache.org>.
ulysses-you commented on code in PR #1:
URL: https://github.com/apache/kyuubi-docker/pull/1#discussion_r1091375041
##########
.github/workflows/docker-image.yml:
##########
@@ -0,0 +1,58 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: Publish Docker image
+
+on:
+ push:
+ tags:
+ - '*'
+
+jobs:
+ push_to_registry:
+ name: Push Docker image to Docker Hub
+ if: ${{ startsWith(github.repository, 'apache/') }}
+ runs-on: ubuntu-22.04
+ strategy:
+ matrix:
+ include:
+ - suffix-name: ''
+ opts: '--flink-provided --spark-provided --hive-provided'
+ - suffix-name: '-spark'
+ opts: '--flink-provided --hive-provided'
+ - suffix-name: '-flink'
+ opts: '--spark-provided --hive-provided'
+ - suffix-name: '-all'
+ opts: ''
+ steps:
+ - name: Checkout
+ uses: actions/checkout@v3
+ - name: Login to Docker Hub
Review Comment:
I think we can do that in followup once we decide to release multi-platform image. WDYT ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kyuubi-docker] pan3793 commented on a diff in pull request #1: Initial docker file
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #1:
URL: https://github.com/apache/kyuubi-docker/pull/1#discussion_r1090515837
##########
1.6.1-incubating/scala2.12-java8-ubuntu/Dockerfile:
##########
@@ -0,0 +1,31 @@
+FROM eclipse-temurin:8-jre
+
+ARG kyuubi_uid=10009
+
+USER root
+
+ENV KYUUBI_HOME /opt/kyuubi
+ENV KYUUBI_LOG_DIR ${KYUUBI_HOME}/logs
+ENV KYUUBI_PID_DIR ${KYUUBI_HOME}/pid
+ENV KYUUBI_WORK_DIR_ROOT ${KYUUBI_HOME}/work
+
+RUN set -ex; \
+ sed -i 's/http:\/\/deb.\(.*\)/https:\/\/deb.\1/g' /etc/apt/sources.list; \
+ apt-get update && \
Review Comment:
could you please use `&& \` in all places?
##########
release/DOI-Dockerfile.template:
##########
@@ -0,0 +1,44 @@
+FROM eclipse-temurin:8-jdk-focal
+
+ARG kyuubi_uid=10009
+
+USER root
+
+ENV KYUUBI_SOURCE_TGZ_URL=https://archive.apache.org/dist/incubator/kyuubi/kyuubi-1.6.0-incubating/apache-kyuubi-1.6.0-incubating-source.tgz
Review Comment:
1.6.1
##########
release/DOI-Dockerfile.template:
##########
@@ -0,0 +1,44 @@
+FROM eclipse-temurin:8-jdk-focal
+
+ARG kyuubi_uid=10009
+
+USER root
+
+ENV KYUUBI_SOURCE_TGZ_URL=https://archive.apache.org/dist/incubator/kyuubi/kyuubi-1.6.0-incubating/apache-kyuubi-1.6.0-incubating-source.tgz
+
+ARG SPARK_PROVIDED="--spark-provided"
+ARG FLINK_PROVIDED="--flink-provided"
+ARG HIVE_PROVIDED="--hive-provided"
+
+ENV KYUUBI_HOME=/opt/kyuubi
+ENV KYUUBI_WORK_DIR_ROOT=${KYUUBI_HOME}/work
+
+RUN set -ex; \
+ sed -i 's/http:\/\/deb.\(.*\)/https:\/\/deb.\1/g' /etc/apt/sources.list; \
+ apt-get update && \
+ apt install -y wget bash tini libc6 libpam-modules krb5-user libnss3 procps; \
+ mkdir -p ${KYUUBI_HOME}
+
+# build binary from source
+RUN set -ex; \
+ export KYUUBI_SOURCE_HOME="$(mktemp -d)"; \
+ cd ${KYUUBI_SOURCE_HOME}; \
+ wget -O kyuubi.tgz ${KYUUBI_SOURCE_TGZ_URL}; \
Review Comment:
how about reserving the original name?
##########
.gitignore:
##########
@@ -0,0 +1,47 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+*#*#
+*.#*
+*.iml
+*.ipr
+*.iws
+*.pyc
+*.pyo
+*.swp
+*~
+.DS_Store
+.cache
+.classpath
+.ensime
+.ensime_cache/
+.ensime_lucene
+.generated-mima*
+.vscode/
+.idea/
+# The star is required for further !/.idea/ to work, see https://git-scm.com/docs/gitignore
+/.idea/*
+# Icon for JetBrains Toolbox
+!/.idea/icon.png
+!/.idea/vcs.xml
Review Comment:
let's remove them, it's useless
##########
1.6.1-incubating/scala2.12-java8-ubuntu/Dockerfile:
##########
@@ -0,0 +1,31 @@
+FROM eclipse-temurin:8-jre
Review Comment:
why not jdk? jre lacks some java command, I'm not sure if `jps` is supplied
##########
1.6.1-incubating/scala2.12-java8-ubuntu/Dockerfile:
##########
@@ -0,0 +1,31 @@
+FROM eclipse-temurin:8-jre
+
+ARG kyuubi_uid=10009
+
+USER root
+
+ENV KYUUBI_HOME /opt/kyuubi
+ENV KYUUBI_LOG_DIR ${KYUUBI_HOME}/logs
+ENV KYUUBI_PID_DIR ${KYUUBI_HOME}/pid
+ENV KYUUBI_WORK_DIR_ROOT ${KYUUBI_HOME}/work
+
+RUN set -ex; \
+ sed -i 's/http:\/\/deb.\(.*\)/https:\/\/deb.\1/g' /etc/apt/sources.list; \
+ apt-get update && \
+ apt install -y wget bash tini libc6 libpam-modules krb5-user libnss3 procps; \
+ mkdir -p ${KYUUBI_HOME} ${KYUUBI_LOG_DIR} ${KYUUBI_PID_DIR} ${KYUUBI_WORK_DIR_ROOT}
Review Comment:
please clean apt cache to reduce the image size
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kyuubi-docker] ulysses-you commented on a diff in pull request #1: Initial docker file
Posted by "ulysses-you (via GitHub)" <gi...@apache.org>.
ulysses-you commented on code in PR #1:
URL: https://github.com/apache/kyuubi-docker/pull/1#discussion_r1090511579
##########
1.6.1-incubating/scala2.12-java8-ubuntu/Dockerfile:
##########
@@ -0,0 +1,31 @@
+FROM eclipse-temurin:8-jre
Review Comment:
this docker file is using binary to build image
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kyuubi-docker] bowenliang123 commented on a diff in pull request #1: Initial docker file
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 commented on code in PR #1:
URL: https://github.com/apache/kyuubi-docker/pull/1#discussion_r1091352615
##########
.github/workflows/docker-image.yml:
##########
@@ -0,0 +1,58 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: Publish Docker image
+
+on:
+ push:
+ tags:
+ - '*'
+
+jobs:
+ push_to_registry:
+ name: Push Docker image to Docker Hub
+ if: ${{ startsWith(github.repository, 'apache/') }}
+ runs-on: ubuntu-22.04
+ strategy:
+ matrix:
+ include:
+ - suffix-name: ''
+ opts: '--flink-provided --spark-provided --hive-provided'
+ - suffix-name: '-spark'
+ opts: '--flink-provided --hive-provided'
+ - suffix-name: '-flink'
+ opts: '--spark-provided --hive-provided'
+ - suffix-name: '-all'
+ opts: ''
+ steps:
+ - name: Checkout
+ uses: actions/checkout@v3
+ - name: Login to Docker Hub
+ uses: docker/login-action@v2
+ with:
+ username: ${{ secrets.DOCKERHUB_USER }}
+ password: ${{ secrets.DOCKERHUB_TOKEN }}
+ - name: Build Kyuubi Docker Image
+ run: |
+ wget -O kyuubi.tgz https://archive.apache.org/dist/kyuubi/kyuubi-$(cat release/release_version)/apache-kyuubi-$(cat release/release_version)-source.tgz
+ tar -xvf kyuubi.tgz --strip-components=1
+ ./build/dist ${{ matrix.opts }} -Dmaven.javadoc.skip=true -Dmaven.scaladoc.skip=true -Drat.skip=true -Dscalastyle.skip=true -Dspotless.check.skip -DskipTests
+ docker build --tag apache/kyuubi:$(cat release/release_version)${{ matrix.suffix-name }} --file $(cat release/release_version)/*/Dockerfile .
Review Comment:
I think it's alright to use `.` as docker's build context here for now. It might not be the priority for the build performance, and copying these few files to context should not take much time and be done in a handful of seconds in CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kyuubi-docker] zwangsheng commented on a diff in pull request #1: Initial docker file
Posted by "zwangsheng (via GitHub)" <gi...@apache.org>.
zwangsheng commented on code in PR #1:
URL: https://github.com/apache/kyuubi-docker/pull/1#discussion_r1091480560
##########
1.6.1-incubating/scala2.12-java8-ubuntu/Dockerfile:
##########
@@ -0,0 +1,31 @@
+FROM eclipse-temurin:8-jre
+
+ARG kyuubi_uid=10009
+
+USER root
+
+ENV KYUUBI_HOME /opt/kyuubi
+ENV KYUUBI_LOG_DIR ${KYUUBI_HOME}/logs
+ENV KYUUBI_PID_DIR ${KYUUBI_HOME}/pid
+ENV KYUUBI_WORK_DIR_ROOT ${KYUUBI_HOME}/work
+
+RUN set -ex; \
+ sed -i 's/http:\/\/deb.\(.*\)/https:\/\/deb.\1/g' /etc/apt/sources.list; && \
+ apt-get update && \
+ apt install -y wget bash tini libc6 libpam-modules krb5-user libnss3 procps; && \
+ mkdir -p ${KYUUBI_HOME} ${KYUUBI_LOG_DIR} ${KYUUBI_PID_DIR} ${KYUUBI_WORK_DIR_ROOT} && \
+ rm -rf /var/cache/apt/* && rm -rf /var/lib/apt/lists/*
+
+COPY dist ${KYUUBI_HOME}
+
+# setup kyuubi
+RUN set -ex && \
+ useradd -u ${kyuubi_uid} -g root kyuubi && \
Review Comment:
According to [KYUUBI #3719](https://github.com/apache/kyuubi/pull/3719)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi-docker] ulysses-you commented on a diff in pull request #1: Initial docker file
Posted by "ulysses-you (via GitHub)" <gi...@apache.org>.
ulysses-you commented on code in PR #1:
URL: https://github.com/apache/kyuubi-docker/pull/1#discussion_r1091478278
##########
1.6.1-incubating/scala2.12-java8-ubuntu/Dockerfile:
##########
@@ -0,0 +1,31 @@
+FROM eclipse-temurin:8-jre
+
+ARG kyuubi_uid=10009
+
+USER root
+
+ENV KYUUBI_HOME /opt/kyuubi
+ENV KYUUBI_LOG_DIR ${KYUUBI_HOME}/logs
+ENV KYUUBI_PID_DIR ${KYUUBI_HOME}/pid
+ENV KYUUBI_WORK_DIR_ROOT ${KYUUBI_HOME}/work
+
+RUN set -ex; \
+ sed -i 's/http:\/\/deb.\(.*\)/https:\/\/deb.\1/g' /etc/apt/sources.list; && \
+ apt-get update && \
+ apt install -y wget bash tini libc6 libpam-modules krb5-user libnss3 procps; && \
+ mkdir -p ${KYUUBI_HOME} ${KYUUBI_LOG_DIR} ${KYUUBI_PID_DIR} ${KYUUBI_WORK_DIR_ROOT} && \
+ rm -rf /var/cache/apt/* && rm -rf /var/lib/apt/lists/*
+
+COPY dist ${KYUUBI_HOME}
+
+# setup kyuubi
+RUN set -ex && \
+ useradd -u ${kyuubi_uid} -g root kyuubi && \
Review Comment:
what does it use for ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi-docker] ulysses-you commented on a diff in pull request #1: Initial docker file
Posted by "ulysses-you (via GitHub)" <gi...@apache.org>.
ulysses-you commented on code in PR #1:
URL: https://github.com/apache/kyuubi-docker/pull/1#discussion_r1090534958
##########
release/DOI-Dockerfile.template:
##########
@@ -0,0 +1,44 @@
+FROM eclipse-temurin:8-jdk-focal
Review Comment:
I removed this file as it is not used
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kyuubi-docker] ulysses-you commented on a diff in pull request #1: Initial docker file
Posted by "ulysses-you (via GitHub)" <gi...@apache.org>.
ulysses-you commented on code in PR #1:
URL: https://github.com/apache/kyuubi-docker/pull/1#discussion_r1092826541
##########
.github/workflows/docker-image.yml:
##########
@@ -0,0 +1,58 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: Publish Docker image
+
+on:
+ push:
+ tags:
+ - '*'
+
+jobs:
+ push_to_registry:
+ name: Push Docker image to Docker Hub
+ if: ${{ startsWith(github.repository, 'apache/') }}
+ runs-on: ubuntu-22.04
+ strategy:
+ matrix:
+ include:
+ - suffix-name: ''
+ opts: '--flink-provided --spark-provided --hive-provided'
+ - suffix-name: '-spark'
+ opts: '--flink-provided --hive-provided'
+ - suffix-name: '-flink'
+ opts: '--spark-provided --hive-provided'
+ - suffix-name: '-all'
+ opts: ''
+ steps:
+ - name: Checkout
+ uses: actions/checkout@v3
+ - name: Login to Docker Hub
Review Comment:
> where to tell the arch of image from the dockfile or comments we are releasing?
@bowenliang123 It's an option in dockerhub if we build some, e.g.
<img width="1002" alt="image" src="https://user-images.githubusercontent.com/12025282/215972737-0800b15c-f3de-452f-ba1a-5e5c92161119.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi-docker] ulysses-you commented on a diff in pull request #1: Initial docker file
Posted by "ulysses-you (via GitHub)" <gi...@apache.org>.
ulysses-you commented on code in PR #1:
URL: https://github.com/apache/kyuubi-docker/pull/1#discussion_r1090534533
##########
1.6.1-incubating/scala2.12-java8-ubuntu/Dockerfile:
##########
@@ -0,0 +1,31 @@
+FROM eclipse-temurin:8-jre
Review Comment:
This is a point. In general, offical should provide a small enough image so I use jre rather jdk. I'm good with either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org