You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@drill.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/10/28 11:29:00 UTC

[jira] [Commented] (DRILL-8345) Fix Eclipse compatibility in the Maven resources plugin config

    [ https://issues.apache.org/jira/browse/DRILL-8345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625624#comment-17625624 ] 

ASF GitHub Bot commented on DRILL-8345:
---------------------------------------

jnturton opened a new pull request, #2694:
URL: https://github.com/apache/drill/pull/2694

   # [DRILL-8345](https://issues.apache.org/jira/browse/DRILL-8345): Replace maven.multiModuleProjectDirectory with session.executionRootDirectory
   
   ## Description
   
   The Maven resources plugin makes use of the undocumented variable maven.multiModuleProjectDirectory to copy /git.properties to target/classes in every sub-module. This variable breaks the project build in Eclipse 2022-03, even when a .mvn directory is present at the project root, and was probably never meant for use by the public. Replacing it with the session.executionRootDirectory Maven variable fixes the build in Eclipse and retains the intended copying of git.properties during builds.
   
   
   ## Documentation
   N/A
   
   ## Testing
   Import the Drill Maven project from scratch into Eclipse 2022-03 and run a unit test
   Import the Drill Maven project from scratch into IDEA 2021.2.4 and run a unit test
   Delete all but the root git.properties then build the project using mvn and check that a git.properties is present in target/classes of all modules.
   




> Fix Eclipse compatibility in the Maven resources plugin config
> --------------------------------------------------------------
>
>                 Key: DRILL-8345
>                 URL: https://issues.apache.org/jira/browse/DRILL-8345
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Tools, Build &amp; Test
>    Affects Versions: 1.20.2
>            Reporter: James Turton
>            Assignee: James Turton
>            Priority: Minor
>             Fix For: 1.20.3
>
>
> The Maven resources plugin makes use of the undocumented variable maven.multiModuleProjectDirectory to copy /git.properties to target/classes in every sub-module. This variable breaks the project build in Eclipse 2022-03, even when a .mvn directory is present at the project root, and was probably never meant for use by the public. Replacing it with the session.executionRootDirectory Maven variable fixes the build in Eclipse and retains the intended copying of git.properties during builds.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)