You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2016/01/12 02:49:23 UTC

Re: Review Request 41338: Added REASON_RESOURCES_PREEMPTED to mesos proto.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41338/#review113904
-----------------------------------------------------------


Looks like the diff doesn't show up on the WebUI (The downloaded version looks fine though).  This is possibly because r41434 is private.

- Joseph Wu


On Dec. 15, 2015, 8:47 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41338/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2015, 8:47 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Klaus Ma.
> 
> 
> Bugs: MESOS-4148
>     https://issues.apache.org/jira/browse/MESOS-4148
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added REASON_RESOURCES_PREEMPTED to mesos proto.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto a403d8eb832686aec9cdeb69c9cc2f0ea8b73b88 
>   include/mesos/v1/mesos.proto a07b08bd676904f94b6c6612e48f6e10b8060192 
> 
> Diff: https://reviews.apache.org/r/41338/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Re: Review Request 41338: Added REASON_RESOURCES_PREEMPTED to mesos proto.

Posted by Klaus Ma <kl...@gmail.com>.

> On Jan. 12, 2016, 9:49 a.m., Joseph Wu wrote:
> > Looks like the diff doesn't show up on the WebUI (The downloaded version looks fine though).  This is possibly because r41434 is private.

I've included this code in r41859. @Guangya, would you help to check whether this patch is still necessary?


- Klaus


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41338/#review113904
-----------------------------------------------------------


On Dec. 16, 2015, 12:47 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41338/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2015, 12:47 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Klaus Ma.
> 
> 
> Bugs: MESOS-4148
>     https://issues.apache.org/jira/browse/MESOS-4148
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added REASON_RESOURCES_PREEMPTED to mesos proto.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto a403d8eb832686aec9cdeb69c9cc2f0ea8b73b88 
>   include/mesos/v1/mesos.proto a07b08bd676904f94b6c6612e48f6e10b8060192 
> 
> Diff: https://reviews.apache.org/r/41338/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>