You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-commits@xmlgraphics.apache.org by sp...@apache.org on 2005/01/12 20:50:37 UTC

cvs commit: xml-fop build.xml

spepping    2005/01/12 11:50:36

  Modified:    .        build.xml
  Log:
  Fixed an error in the classpath of one of the junit tests
  
  Revision  Changes    Path
  1.113     +1 -0      xml-fop/build.xml
  
  Index: build.xml
  ===================================================================
  RCS file: /home/cvs/xml-fop/build.xml,v
  retrieving revision 1.112
  retrieving revision 1.113
  diff -u -r1.112 -r1.113
  --- build.xml	6 Jan 2005 19:20:37 -0000	1.112
  +++ build.xml	12 Jan 2005 19:50:36 -0000	1.113
  @@ -696,6 +696,7 @@
         <formatter type="brief" usefile="false"/>
         <classpath>
           <pathelement location="${build.dir}/test-classes"/>
  +        <path refid="libs-basic-run-classpath"/>
           <fileset dir="build">
             <include name="fop-transcoder-allinone.jar"/>
           </fileset>
  
  
  

---------------------------------------------------------------------
To unsubscribe, e-mail: fop-cvs-unsubscribe@xml.apache.org
For additional commands, e-mail: fop-cvs-help@xml.apache.org


Re: Xerces-dependency in Batik

Posted by Thomas DeWeese <Th...@Kodak.com>.
Hi All,

Jeremias Maerki wrote:

> (cc'ing batik-dev)
> 
> If I interpret this correctly, Batik uses the following entry in
> XMLResourceDescriptor.properties to instantiate a parser in
> SAXDocumentFactory through the SAX XMLReaderFactory:
> 
> org.xml.sax.driver = org.apache.xerces.parsers.SAXParser
> 
> There's no Xerces-dependency in Java code, only SAX. Neither does the
> PDFTranscoder use Xerces-specific functionality.
> 
> This should probably be improved in Batik.

    Yes, there is nothing against JAXP, this code was all written
before JAXP existed.  Since then no one has taken the time to
ensure we are using it properly.  Also Ideally there would be
some sort of transition where both might work.

    Contributions are always welcome! ;)


> On 13.01.2005 23:22:14 J.Pietschmann wrote:
> 
>>Jeremias Maerki wrote:
>>
>>>I see. I've added JAXP and Xerces to the classpath.
>>
>>Isn't it somewhat strange that org.apache.xerces.parsers.SAXParser
>>is explicitely referenced? I'd think everyone uses JAXP meanwhile.
>>Do you access Xerces specific functionality?
>>
>>J.Pietschmann
> 
> 
> 
> 
> Jeremias Maerki
> 


Re: Xerces-dependency in Batik

Posted by Thomas DeWeese <Th...@Kodak.com>.
Hi All,

Jeremias Maerki wrote:

> (cc'ing batik-dev)
> 
> If I interpret this correctly, Batik uses the following entry in
> XMLResourceDescriptor.properties to instantiate a parser in
> SAXDocumentFactory through the SAX XMLReaderFactory:
> 
> org.xml.sax.driver = org.apache.xerces.parsers.SAXParser
> 
> There's no Xerces-dependency in Java code, only SAX. Neither does the
> PDFTranscoder use Xerces-specific functionality.
> 
> This should probably be improved in Batik.

    Yes, there is nothing against JAXP, this code was all written
before JAXP existed.  Since then no one has taken the time to
ensure we are using it properly.  Also Ideally there would be
some sort of transition where both might work.

    Contributions are always welcome! ;)


> On 13.01.2005 23:22:14 J.Pietschmann wrote:
> 
>>Jeremias Maerki wrote:
>>
>>>I see. I've added JAXP and Xerces to the classpath.
>>
>>Isn't it somewhat strange that org.apache.xerces.parsers.SAXParser
>>is explicitely referenced? I'd think everyone uses JAXP meanwhile.
>>Do you access Xerces specific functionality?
>>
>>J.Pietschmann
> 
> 
> 
> 
> Jeremias Maerki
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: batik-dev-help@xml.apache.org


Re: Xerces-dependency in Batik (was: cvs commit: xml-fop build.xml)

Posted by Jeremias Maerki <de...@greenmail.ch>.
(cc'ing batik-dev)

If I interpret this correctly, Batik uses the following entry in
XMLResourceDescriptor.properties to instantiate a parser in
SAXDocumentFactory through the SAX XMLReaderFactory:

org.xml.sax.driver = org.apache.xerces.parsers.SAXParser

There's no Xerces-dependency in Java code, only SAX. Neither does the
PDFTranscoder use Xerces-specific functionality.

This should probably be improved in Batik.

On 13.01.2005 23:22:14 J.Pietschmann wrote:
> Jeremias Maerki wrote:
> > I see. I've added JAXP and Xerces to the classpath.
> 
> Isn't it somewhat strange that org.apache.xerces.parsers.SAXParser
> is explicitely referenced? I'd think everyone uses JAXP meanwhile.
> Do you access Xerces specific functionality?
> 
> J.Pietschmann



Jeremias Maerki


Re: Xerces-dependency in Batik (was: cvs commit: xml-fop build.xml)

Posted by Jeremias Maerki <de...@greenmail.ch>.
(cc'ing batik-dev)

If I interpret this correctly, Batik uses the following entry in
XMLResourceDescriptor.properties to instantiate a parser in
SAXDocumentFactory through the SAX XMLReaderFactory:

org.xml.sax.driver = org.apache.xerces.parsers.SAXParser

There's no Xerces-dependency in Java code, only SAX. Neither does the
PDFTranscoder use Xerces-specific functionality.

This should probably be improved in Batik.

On 13.01.2005 23:22:14 J.Pietschmann wrote:
> Jeremias Maerki wrote:
> > I see. I've added JAXP and Xerces to the classpath.
> 
> Isn't it somewhat strange that org.apache.xerces.parsers.SAXParser
> is explicitely referenced? I'd think everyone uses JAXP meanwhile.
> Do you access Xerces specific functionality?
> 
> J.Pietschmann



Jeremias Maerki


---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: batik-dev-help@xml.apache.org


Re: cvs commit: xml-fop build.xml

Posted by "J.Pietschmann" <j3...@yahoo.de>.
Jeremias Maerki wrote:
> I see. I've added JAXP and Xerces to the classpath.

Isn't it somewhat strange that org.apache.xerces.parsers.SAXParser
is explicitely referenced? I'd think everyone uses JAXP meanwhile.
Do you access Xerces specific functionality?

J.Pietschmann

Re: cvs commit: xml-fop build.xml

Posted by Jeremias Maerki <de...@greenmail.ch>.
I see. I've added JAXP and Xerces to the classpath. This approach still
allows us to verify that the repackaging process is set up correctly.
Sorry for the trouble. I rarely work with JDK 1.3 and I have Xerces and
Xalan in the endorsed directory for all my JDK 1.4+ VMs.

On 13.01.2005 21:14:25 Simon Pepping wrote:
> On Wed, Jan 12, 2005 at 09:02:37PM +0100, Jeremias Maerki wrote:
> > Uhm, the classpath was quite ok like it was. If you look into the
> > fop-transcoder-allinone.jar, it contains all classes (or at least should
> > contain all classes) that are needed to run the transcoder tests. That
> > JAR is for people who don't like all the little dependency JARs.
> > 
> > Why did you do the change in the first place? What was the problem?
> 
> Where else do I find the SAX2 driver class
> org.apache.xerces.parsers.SAXParser?
> 
>      [echo] Running basic functionality tests for fop-transcoder-allinone.jar
>     [junit] Testsuite: org.apache.fop.BasicTranscoderTestSuite
>     [junit] Tests run: 1, Failures: 0, Errors: 1, Time elapsed: 0.204 sec
> 
>     [junit] ------------- Standard Error -----------------
>     [junit] java.io.IOException: SAX2 driver class org.apache.xerces.parsers.SAXParser not found
>     [junit] 	at org.apache.batik.dom.util.SAXDocumentFactory.createDocument(Unknown Source)


Jeremias Maerki


Re: cvs commit: xml-fop build.xml

Posted by Simon Pepping <sp...@leverkruid.nl>.
On Wed, Jan 12, 2005 at 09:02:37PM +0100, Jeremias Maerki wrote:
> Uhm, the classpath was quite ok like it was. If you look into the
> fop-transcoder-allinone.jar, it contains all classes (or at least should
> contain all classes) that are needed to run the transcoder tests. That
> JAR is for people who don't like all the little dependency JARs.
> 
> Why did you do the change in the first place? What was the problem?

Where else do I find the SAX2 driver class
org.apache.xerces.parsers.SAXParser?

     [echo] Running basic functionality tests for fop-transcoder-allinone.jar
    [junit] Testsuite: org.apache.fop.BasicTranscoderTestSuite
    [junit] Tests run: 1, Failures: 0, Errors: 1, Time elapsed: 0.204 sec

    [junit] ------------- Standard Error -----------------
    [junit] java.io.IOException: SAX2 driver class org.apache.xerces.parsers.SAXParser not found
    [junit] 	at org.apache.batik.dom.util.SAXDocumentFactory.createDocument(Unknown Source)
    [junit] 	at org.apache.batik.dom.util.SAXDocumentFactory.createDocument(Unknown Source)
    [junit] 	at org.apache.batik.dom.svg.SAXSVGDocumentFactory.createDocument(Unknown Source)
    [junit] 	at org.apache.batik.dom.svg.SAXSVGDocumentFactory.createDocument(Unknown Source)
    [junit] 	at org.apache.batik.transcoder.XMLAbstractTranscoder.transcode(Unknown Source)
    [junit] 	at org.apache.batik.transcoder.SVGAbstractTranscoder.transcode(Unknown Source)
    [junit] 	at org.apache.fop.AbstractBasicTranscoderTestCase.testGenericPDFTranscoder(AbstractBasicTranscoderTestCase.java:70)
    [junit] 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    [junit] 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
    [junit] 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
    [junit] 	at java.lang.reflect.Method.invoke(Method.java:324)
    [junit] 	at junit.framework.TestCase.runTest(TestCase.java:154)
    [junit] 	at junit.framework.TestCase.runBare(TestCase.java:127)
    [junit] 	at junit.framework.TestResult$1.protect(TestResult.java:106)
    [junit] 	at junit.framework.TestResult.runProtected(TestResult.java:124)
    [junit] 	at junit.framework.TestResult.run(TestResult.java:109)
    [junit] 	at junit.framework.TestCase.run(TestCase.java:118)
    [junit] 	at junit.framework.TestSuite.runTest(TestSuite.java:208)
    [junit] 	at junit.framework.TestSuite.run(TestSuite.java:203)
    [junit] 	at junit.framework.TestSuite.runTest(TestSuite.java:208)
    [junit] 	at junit.framework.TestSuite.run(TestSuite.java:203)
    [junit] 	at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTestRunner.java:326)
    [junit] 	at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.main(JUnitTestRunner.java:560)
    [junit] ------------- ---------------- ---------------
    [junit] Testcase: testGenericPDFTranscoder(org.apache.fop.BasicPDFTranscoderTestCase):	Caused an ERROR
    [junit] null
    [junit] Enclosed Exception:
    [junit] SAX2 driver class org.apache.xerces.parsers.SAXParser not found
    [junit] org.apache.batik.transcoder.TranscoderException: null
    [junit] Enclosed Exception:
    [junit] SAX2 driver class org.apache.xerces.parsers.SAXParser not found
    [junit] 	at org.apache.batik.transcoder.XMLAbstractTranscoder.transcode(Unknown Source)
    [junit] 	at org.apache.batik.transcoder.SVGAbstractTranscoder.transcode(Unknown Source)
    [junit] 	at org.apache.fop.AbstractBasicTranscoderTestCase.testGenericPDFTranscoder(AbstractBasicTranscoderTestCase.java:70)
    [junit] 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    [junit] 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
    [junit] 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)

Simon

> On 12.01.2005 20:50:37 spepping wrote:
> > spepping    2005/01/12 11:50:36
> > 
> >   Modified:    .        build.xml
> >   Log:
> >   Fixed an error in the classpath of one of the junit tests
> >   
> >   Revision  Changes    Path
> >   1.113     +1 -0      xml-fop/build.xml
> >   
> >   Index: build.xml
> >   ===================================================================
> >   RCS file: /home/cvs/xml-fop/build.xml,v
> >   retrieving revision 1.112
> >   retrieving revision 1.113
> >   diff -u -r1.112 -r1.113
> >   --- build.xml	6 Jan 2005 19:20:37 -0000	1.112
> >   +++ build.xml	12 Jan 2005 19:50:36 -0000	1.113
> >   @@ -696,6 +696,7 @@
> >          <formatter type="brief" usefile="false"/>
> >          <classpath>
> >            <pathelement location="${build.dir}/test-classes"/>
> >   +        <path refid="libs-basic-run-classpath"/>
> >            <fileset dir="build">
> >              <include name="fop-transcoder-allinone.jar"/>
> >            </fileset>

-- 
Simon Pepping
home page: http://www.leverkruid.nl


Re: cvs commit: xml-fop build.xml

Posted by Jeremias Maerki <de...@greenmail.ch>.
Uhm, the classpath was quite ok like it was. If you look into the
fop-transcoder-allinone.jar, it contains all classes (or at least should
contain all classes) that are needed to run the transcoder tests. That
JAR is for people who don't like all the little dependency JARs.

Why did you do the change in the first place? What was the problem?


On 12.01.2005 20:50:37 spepping wrote:
> spepping    2005/01/12 11:50:36
> 
>   Modified:    .        build.xml
>   Log:
>   Fixed an error in the classpath of one of the junit tests
>   
>   Revision  Changes    Path
>   1.113     +1 -0      xml-fop/build.xml
>   
>   Index: build.xml
>   ===================================================================
>   RCS file: /home/cvs/xml-fop/build.xml,v
>   retrieving revision 1.112
>   retrieving revision 1.113
>   diff -u -r1.112 -r1.113
>   --- build.xml	6 Jan 2005 19:20:37 -0000	1.112
>   +++ build.xml	12 Jan 2005 19:50:36 -0000	1.113
>   @@ -696,6 +696,7 @@
>          <formatter type="brief" usefile="false"/>
>          <classpath>
>            <pathelement location="${build.dir}/test-classes"/>
>   +        <path refid="libs-basic-run-classpath"/>
>            <fileset dir="build">
>              <include name="fop-transcoder-allinone.jar"/>
>            </fileset>
>   
>   
>   



Jeremias Maerki