You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/17 13:58:15 UTC

[GitHub] [superset] michael-s-molina commented on a change in pull request #13037: feat: add autocopy functionality to CopyToClipboard (#10328)

michael-s-molina commented on a change in pull request #13037:
URL: https://github.com/apache/superset/pull/13037#discussion_r577630904



##########
File path: superset-frontend/spec/javascripts/dashboard/components/HeaderActionsDropdown_spec.jsx
##########
@@ -79,19 +79,19 @@ describe('HeaderActionsDropdown', () => {
       expect(menu.find(SaveModal)).not.toExist();
     });
 
-    it('should render five Menu items', () => {
+    it('should render four Menu items', () => {

Review comment:
       I changed to "should render available Menu items" since this is nested in a describe with the role being tested. This way future changes are not going to impact this text.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org