You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@jclouds.apache.org by jasdeep-hundal <no...@github.com> on 2014/03/17 23:45:34 UTC

[jclouds] Fix Keystone response for testing to not include Glance version (#319)

Please see this ticket: https://issues.apache.org/jira/browse/JCLOUDS-494

As well as this PR: https://github.com/jclouds/jclouds-labs-openstack/pull/82
You can merge this Pull Request by running:

  git pull https://github.com/jasdeep-hundal/jclouds fix_glance_endpoint

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds/pull/319

-- Commit Summary --

  * Fix Keystone response for testing to not include Glance version

-- File Changes --

    M apis/openstack-keystone/src/test/java/org/jclouds/openstack/keystone/v2_0/parse/ParseAccessTest.java (2)
    M apis/openstack-keystone/src/test/resources/keystoneAuthResponse.json (2)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/319.patch
https://github.com/jclouds/jclouds/pull/319.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/319

Re: [jclouds] Fix Keystone response for testing to not include Glance version (#319)

Posted by Ignasi Barrera <no...@github.com>.

Closed #319.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/319

Re: [jclouds] Fix Keystone response for testing to not include Glance version (#319)

Posted by CloudBees pull request builder plugin <no...@github.com>.

[jclouds-java-7-pull-requests #1136](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1136/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/319#issuecomment-37883515

Re: [jclouds] Fix Keystone response for testing to not include Glance version (#319)

Posted by BuildHive <no...@github.com>.

[jclouds » jclouds #920](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/920/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/319#issuecomment-37884174

Re: [jclouds] Fix Keystone response for testing to not include Glance version (#319)

Posted by Andrew Phillips <no...@github.com>.

Thanks, @jasdeep-hundal!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/319#issuecomment-37987013

Re: [jclouds] Fix Keystone response for testing to not include Glance version (#319)

Posted by jasdeep-hundal <no...@github.com>.

With Mark Washenberger's comment here https://github.com/jclouds/jclouds-labs-openstack/pull/82#issuecomment-38088893 , I think this is the right change to make, given that Devstack is (relatively) canonical and returns an unversioned endpoint.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/319#issuecomment-38089507

Re: [jclouds] Fix Keystone response for testing to not include Glance version (#319)

Posted by Andrew Phillips <no...@github.com>.

As per a previous discussion: +1 to this if the new response value `https://glance.jclouds.org:9292/` is one that could be realistically returned by an OpenStack installation. From what I recall, someone (@zack-shoylev? @everett-toews?) confirmed that that was indeed the case.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/319#issuecomment-37986969

Re: [jclouds] Fix Keystone response for testing to not include Glance version (#319)

Posted by Ignasi Barrera <no...@github.com>.

[Merged](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=22a8b9d04c110789a0a58c479d1525daa700c66b). As soon as [the build](https://jclouds.ci.cloudbees.com/job/jclouds/2560/) finishes and the snapshots are published to the local repo, you should be able to update https://github.com/jclouds/jclouds-labs-openstack/issues/82 accordingly.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/319#issuecomment-38117222

Re: [jclouds] Fix Keystone response for testing to not include Glance version (#319)

Posted by CloudBees pull request builder plugin <no...@github.com>.

[jclouds-pull-requests #666](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/666/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/319#issuecomment-37883115