[GitHub] [helix] junkaixue commented on a change in pull request #1797: Add response metadata to response header for partitionAssignment

[GitBox <gi...@apache.org>]

junkaixue commented on a change in pull request #1797:
URL: https://github.com/apache/helix/pull/1797#discussion_r673574533



##########
File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/AbstractResource.java
##########
@@ -130,6 +130,13 @@ protected Response OK() {
     return Response.ok().build();
   }
 
+  protected Response OKWithHeader(Object entity, String headerName, Object headerValue) {
+    if (headerName == null || headerName.length()==0)
+      return OK(entity);
+    else

Review comment:
       NIT: remove the else and add {} to if statement. Let's respect our coding convention.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org