You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/23 08:44:07 UTC
[GitHub] [flink] zhijiangW opened a new pull request #10662:
[FLINK-15306][network] Adjust the default netty transport option from nio
to auto
zhijiangW opened a new pull request #10662: [FLINK-15306][network] Adjust the default netty transport option from nio to auto
URL: https://github.com/apache/flink/pull/10662
## What is the purpose of the change
*The default option of `taskmanager.network.netty.transport` in `NettyShuffleEnvironmentOptions` is `nio` now. As we know, the `epoll` mode can get better performance, less GC and have more advanced features which are only available on linux. Therefore it is better to adjust the default option to `auto` instead, and then the framework would automatically choose the proper mode based on the platform.*
## Brief change log
- *Modify the default option value for `NettyShuffleEnvironmentOptions#taskmanager.network.netty.transport`*
- *Re-generates the related html files*
## Verifying this change
via micro-benchmark
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (**yes** / no)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10662:
[FLINK-15306][network] Adjust the default netty transport option from nio
to auto
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10662: [FLINK-15306][network] Adjust the default netty transport option from nio to auto
URL: https://github.com/apache/flink/pull/10662#issuecomment-568414118
<!--
Meta data
Hash:17d9878cab7e52a256ef0708268e36718d651a38 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3858 TriggerType:PUSH TriggerID:17d9878cab7e52a256ef0708268e36718d651a38
Hash:17d9878cab7e52a256ef0708268e36718d651a38 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142091300 TriggerType:PUSH TriggerID:17d9878cab7e52a256ef0708268e36718d651a38
Hash:8483699a80534aa33823090e1091ece6736837be Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142203675 TriggerType:PUSH TriggerID:8483699a80534aa33823090e1091ece6736837be
Hash:8483699a80534aa33823090e1091ece6736837be Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3881 TriggerType:PUSH TriggerID:8483699a80534aa33823090e1091ece6736837be
-->
## CI report:
* 17d9878cab7e52a256ef0708268e36718d651a38 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142091300) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3858)
* 8483699a80534aa33823090e1091ece6736837be Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142203675) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3881)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10662:
[FLINK-15306][network] Adjust the default netty transport option from nio
to auto
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10662: [FLINK-15306][network] Adjust the default netty transport option from nio to auto
URL: https://github.com/apache/flink/pull/10662#issuecomment-568414118
<!--
Meta data
Hash:17d9878cab7e52a256ef0708268e36718d651a38 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3858 TriggerType:PUSH TriggerID:17d9878cab7e52a256ef0708268e36718d651a38
Hash:17d9878cab7e52a256ef0708268e36718d651a38 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142091300 TriggerType:PUSH TriggerID:17d9878cab7e52a256ef0708268e36718d651a38
Hash:8483699a80534aa33823090e1091ece6736837be Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:8483699a80534aa33823090e1091ece6736837be
-->
## CI report:
* 17d9878cab7e52a256ef0708268e36718d651a38 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142091300) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3858)
* 8483699a80534aa33823090e1091ece6736837be UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhijiangW merged pull request #10662:
[FLINK-15306][network] Adjust the default netty transport option from nio
to auto
Posted by GitBox <gi...@apache.org>.
zhijiangW merged pull request #10662: [FLINK-15306][network] Adjust the default netty transport option from nio to auto
URL: https://github.com/apache/flink/pull/10662
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10662:
[FLINK-15306][network] Adjust the default netty transport option from nio
to auto
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10662: [FLINK-15306][network] Adjust the default netty transport option from nio to auto
URL: https://github.com/apache/flink/pull/10662#issuecomment-568414118
<!--
Meta data
Hash:17d9878cab7e52a256ef0708268e36718d651a38 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3858 TriggerType:PUSH TriggerID:17d9878cab7e52a256ef0708268e36718d651a38
Hash:17d9878cab7e52a256ef0708268e36718d651a38 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142091300 TriggerType:PUSH TriggerID:17d9878cab7e52a256ef0708268e36718d651a38
Hash:8483699a80534aa33823090e1091ece6736837be Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142203675 TriggerType:PUSH TriggerID:8483699a80534aa33823090e1091ece6736837be
Hash:8483699a80534aa33823090e1091ece6736837be Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3881 TriggerType:PUSH TriggerID:8483699a80534aa33823090e1091ece6736837be
-->
## CI report:
* 17d9878cab7e52a256ef0708268e36718d651a38 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142091300) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3858)
* 8483699a80534aa33823090e1091ece6736837be Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142203675) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3881)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10662: [FLINK-15306][network]
Adjust the default netty transport option from nio to auto
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10662: [FLINK-15306][network] Adjust the default netty transport option from nio to auto
URL: https://github.com/apache/flink/pull/10662#issuecomment-568405496
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 17d9878cab7e52a256ef0708268e36718d651a38 (Mon Dec 23 08:46:25 UTC 2019)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10662: [FLINK-15306][network]
Adjust the default netty transport option from nio to auto
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10662: [FLINK-15306][network] Adjust the default netty transport option from nio to auto
URL: https://github.com/apache/flink/pull/10662#issuecomment-568414118
<!--
Meta data
Hash:17d9878cab7e52a256ef0708268e36718d651a38 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:17d9878cab7e52a256ef0708268e36718d651a38
-->
## CI report:
* 17d9878cab7e52a256ef0708268e36718d651a38 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10662:
[FLINK-15306][network] Adjust the default netty transport option from nio
to auto
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10662: [FLINK-15306][network] Adjust the default netty transport option from nio to auto
URL: https://github.com/apache/flink/pull/10662#issuecomment-568414118
<!--
Meta data
Hash:17d9878cab7e52a256ef0708268e36718d651a38 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3858 TriggerType:PUSH TriggerID:17d9878cab7e52a256ef0708268e36718d651a38
Hash:17d9878cab7e52a256ef0708268e36718d651a38 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142091300 TriggerType:PUSH TriggerID:17d9878cab7e52a256ef0708268e36718d651a38
-->
## CI report:
* 17d9878cab7e52a256ef0708268e36718d651a38 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142091300) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3858)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10662:
[FLINK-15306][network] Adjust the default netty transport option from nio
to auto
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10662: [FLINK-15306][network] Adjust the default netty transport option from nio to auto
URL: https://github.com/apache/flink/pull/10662#issuecomment-568414118
<!--
Meta data
Hash:17d9878cab7e52a256ef0708268e36718d651a38 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3858 TriggerType:PUSH TriggerID:17d9878cab7e52a256ef0708268e36718d651a38
Hash:17d9878cab7e52a256ef0708268e36718d651a38 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142091300 TriggerType:PUSH TriggerID:17d9878cab7e52a256ef0708268e36718d651a38
Hash:8483699a80534aa33823090e1091ece6736837be Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142203675 TriggerType:PUSH TriggerID:8483699a80534aa33823090e1091ece6736837be
Hash:8483699a80534aa33823090e1091ece6736837be Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3881 TriggerType:PUSH TriggerID:8483699a80534aa33823090e1091ece6736837be
-->
## CI report:
* 17d9878cab7e52a256ef0708268e36718d651a38 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142091300) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3858)
* 8483699a80534aa33823090e1091ece6736837be Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142203675) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3881)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10662:
[FLINK-15306][network] Adjust the default netty transport option from nio
to auto
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10662: [FLINK-15306][network] Adjust the default netty transport option from nio to auto
URL: https://github.com/apache/flink/pull/10662#issuecomment-568414118
<!--
Meta data
Hash:17d9878cab7e52a256ef0708268e36718d651a38 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3858 TriggerType:PUSH TriggerID:17d9878cab7e52a256ef0708268e36718d651a38
Hash:17d9878cab7e52a256ef0708268e36718d651a38 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142091300 TriggerType:PUSH TriggerID:17d9878cab7e52a256ef0708268e36718d651a38
-->
## CI report:
* 17d9878cab7e52a256ef0708268e36718d651a38 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142091300) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3858)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services