You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/09/09 02:08:34 UTC

[GitHub] [pinot] somandal opened a new pull request, #9351: Fix jdk8 build issue due to missing pom dependency

somandal opened a new pull request, #9351:
URL: https://github.com/apache/pinot/pull/9351

   This PR fixes a build failure. 
   
   The following command fails:
   
   ```
   mvn clean install -DskipTests -Pbin-dist -Pbuild-shaded-jar -Ppresto-driver --no-transfer-progress -Djdk.version=8
   ```
   
   With error:
   
   ```
   Error:  Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.0:compile (default-compile) on project pinot-java-client-jdk8: Compilation failure: Compilation failure: 
   Error:  /home/runner/work/pinot-elr/pinot-elr/pinot/pinot-connectors/prestodb-pinot-dependencies/pinot-java-client-jdk8/src/main/java/org/apache/pinot/client/utils/ConnectionUtils.java:[28,37] error: package org.apache.pinot.common.config does not exist
   Error:  /home/runner/work/pinot-elr/pinot-elr/pinot/pinot-connectors/prestodb-pinot-dependencies/pinot-java-client-jdk8/src/main/java/org/apache/pinot/client/utils/ConnectionUtils.java:[29,36] error: package org.apache.pinot.common.utils does not exist
   Error:  /home/runner/work/pinot-elr/pinot-elr/pinot/pinot-connectors/prestodb-pinot-dependencies/pinot-java-client-jdk8/src/main/java/org/apache/pinot/client/utils/ConnectionUtils.java:[52,4] error: cannot find symbol
   Error:    symbol:   class TlsConfig
   Error:    location: class ConnectionUtils
   Error:  /home/runner/work/pinot-elr/pinot-elr/pinot/pinot-connectors/prestodb-pinot-dependencies/pinot-java-client-jdk8/src/main/java/org/apache/pinot/client/utils/ConnectionUtils.java:[52,26] error: cannot find symbol
   Error:    symbol:   variable TlsUtils
   Error:    location: class ConnectionUtils
   Error:  /home/runner/work/pinot-elr/pinot-elr/pinot/pinot-connectors/prestodb-pinot-dependencies/pinot-java-client-jdk8/src/main/java/org/apache/pinot/client/utils/ConnectionUtils.java:[54,4] error: cannot find symbol
   Error:    symbol:   variable TlsUtils
   Error:    location: class ConnectionUtils
   Error:  /home/runner/work/pinot-elr/pinot-elr/pinot/pinot-connectors/prestodb-pinot-dependencies/pinot-java-client-jdk8/src/main/java/org/apache/pinot/client/utils/ConnectionUtils.java:[55,11] error: cannot find symbol
   Error:    symbol:   variable TlsUtils
   Error:    location: class ConnectionUtils
   Error:  -> [Help 1]
   Error:  
   Error:  To see the full stack trace of the errors, re-run Maven with the -e switch.
   Error:  Re-run Maven using the -X switch to enable full debug logging.
   Error:  
   Error:  For more information about the errors and possible solutions, please read the following articles:
   Error:  [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
   Error:  
   Error:  After correcting the problems, you can resume the build with the command
   Error:    mvn <args> -rf :pinot-java-client-jdk8
   ```
   
   This is failing because a file `ConnectionUtils.java` was added as part of PR https://github.com/apache/pinot/pull/9230 to the `pinot-java-client` which is sym-linked in the `pinot-java-client-jdk8` directory under `pinot-connector`. Compilation was failing because the pom file wasn't updated to add the new dependency on  the `pinot-common` file.
   
   cc @siddharthteotia 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [pinot] siddharthteotia merged pull request #9351: Fix jdk8 build issue due to missing pom dependency

Posted by GitBox <gi...@apache.org>.
siddharthteotia merged PR #9351:
URL: https://github.com/apache/pinot/pull/9351


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [pinot] xiangfu0 commented on a diff in pull request #9351: Fix jdk8 build issue due to missing pom dependency

Posted by GitBox <gi...@apache.org>.
xiangfu0 commented on code in PR #9351:
URL: https://github.com/apache/pinot/pull/9351#discussion_r966649342


##########
pinot-connectors/prestodb-pinot-dependencies/pinot-java-client-jdk8/pom.xml:
##########
@@ -59,6 +59,11 @@
       <artifactId>pinot-spi-jdk8</artifactId>
       <version>${project.version}</version>
     </dependency>
+    <dependency>
+      <groupId>org.apache.pinot</groupId>
+      <artifactId>pinot-common</artifactId>

Review Comment:
   actually, this should be `pinot-common-jdk8`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [pinot] codecov-commenter commented on pull request #9351: Fix jdk8 build issue due to missing pom dependency

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #9351:
URL: https://github.com/apache/pinot/pull/9351#issuecomment-1241438975

   # [Codecov](https://codecov.io/gh/apache/pinot/pull/9351?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#9351](https://codecov.io/gh/apache/pinot/pull/9351?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b194489) into [master](https://codecov.io/gh/apache/pinot/commit/9d76fcf2444d1c419b48d0ad0d1740b0d887ee5d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9d76fcf) will **decrease** coverage by `2.27%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #9351      +/-   ##
   ============================================
   - Coverage     28.43%   26.15%   -2.28%     
   + Complexity       53       44       -9     
   ============================================
     Files          1872     1872              
     Lines         99911    99911              
     Branches      15211    15211              
   ============================================
   - Hits          28408    26135    -2273     
   - Misses        68752    71152    +2400     
   + Partials       2751     2624     -127     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | integration1 | `26.15% <ø> (-0.04%)` | :arrow_down: |
   | integration2 | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/pinot/pull/9351?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../apache/pinot/server/access/RequesterIdentity.java](https://codecov.io/gh/apache/pinot/pull/9351/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3Qvc2VydmVyL2FjY2Vzcy9SZXF1ZXN0ZXJJZGVudGl0eS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...t/core/plan/StreamingInstanceResponsePlanNode.java](https://codecov.io/gh/apache/pinot/pull/9351/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9wbGFuL1N0cmVhbWluZ0luc3RhbmNlUmVzcG9uc2VQbGFuTm9kZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...ore/operator/streaming/StreamingResponseUtils.java](https://codecov.io/gh/apache/pinot/pull/9351/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9zdHJlYW1pbmcvU3RyZWFtaW5nUmVzcG9uc2VVdGlscy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...server/starter/helix/SegmentReloadStatusValue.java](https://codecov.io/gh/apache/pinot/pull/9351/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zZXJ2ZXIvc3RhcnRlci9oZWxpeC9TZWdtZW50UmVsb2FkU3RhdHVzVmFsdWUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [.../operator/blocks/results/MetadataResultsBlock.java](https://codecov.io/gh/apache/pinot/pull/9351/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9ibG9ja3MvcmVzdWx0cy9NZXRhZGF0YVJlc3VsdHNCbG9jay5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...ager/realtime/PeerSchemeSplitSegmentCommitter.java](https://codecov.io/gh/apache/pinot/pull/9351/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvUGVlclNjaGVtZVNwbGl0U2VnbWVudENvbW1pdHRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...urces/ServerReloadControllerJobStatusResponse.java](https://codecov.io/gh/apache/pinot/pull/9351/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9hcGkvcmVzb3VyY2VzL1NlcnZlclJlbG9hZENvbnRyb2xsZXJKb2JTdGF0dXNSZXNwb25zZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...t/broker/broker/BasicAuthAccessControlFactory.java](https://codecov.io/gh/apache/pinot/pull/9351/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL0Jhc2ljQXV0aEFjY2Vzc0NvbnRyb2xGYWN0b3J5LmphdmE=) | `0.00% <0.00%> (-90.91%)` | :arrow_down: |
   | [...t/plugin/minion/tasks/purge/PurgeTaskExecutor.java](https://codecov.io/gh/apache/pinot/pull/9351/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtcGx1Z2lucy9waW5vdC1taW5pb24tdGFza3MvcGlub3QtbWluaW9uLWJ1aWx0aW4tdGFza3Mvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3BsdWdpbi9taW5pb24vdGFza3MvcHVyZ2UvUHVyZ2VUYXNrRXhlY3V0b3IuamF2YQ==) | `0.00% <0.00%> (-90.91%)` | :arrow_down: |
   | [...ator/streaming/StreamingSelectionOnlyOperator.java](https://codecov.io/gh/apache/pinot/pull/9351/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9zdHJlYW1pbmcvU3RyZWFtaW5nU2VsZWN0aW9uT25seU9wZXJhdG9yLmphdmE=) | `0.00% <0.00%> (-90.00%)` | :arrow_down: |
   | ... and [210 more](https://codecov.io/gh/apache/pinot/pull/9351/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [pinot] somandal commented on a diff in pull request #9351: Fix jdk8 build issue due to missing pom dependency

Posted by GitBox <gi...@apache.org>.
somandal commented on code in PR #9351:
URL: https://github.com/apache/pinot/pull/9351#discussion_r966650616


##########
pinot-connectors/prestodb-pinot-dependencies/pinot-java-client-jdk8/pom.xml:
##########
@@ -59,6 +59,11 @@
       <artifactId>pinot-spi-jdk8</artifactId>
       <version>${project.version}</version>
     </dependency>
+    <dependency>
+      <groupId>org.apache.pinot</groupId>
+      <artifactId>pinot-common</artifactId>

Review Comment:
   oops, let me sent out another PR once I test that the build works with this. thanks for the catch!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [pinot] xiangfu0 commented on pull request #9351: Fix jdk8 build issue due to missing pom dependency

Posted by GitBox <gi...@apache.org>.
xiangfu0 commented on PR #9351:
URL: https://github.com/apache/pinot/pull/9351#issuecomment-1241525256

   Thanks for fixing this!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [pinot] somandal commented on a diff in pull request #9351: Fix jdk8 build issue due to missing pom dependency

Posted by GitBox <gi...@apache.org>.
somandal commented on code in PR #9351:
URL: https://github.com/apache/pinot/pull/9351#discussion_r966653362


##########
pinot-connectors/prestodb-pinot-dependencies/pinot-java-client-jdk8/pom.xml:
##########
@@ -59,6 +59,11 @@
       <artifactId>pinot-spi-jdk8</artifactId>
       <version>${project.version}</version>
     </dependency>
+    <dependency>
+      <groupId>org.apache.pinot</groupId>
+      <artifactId>pinot-common</artifactId>

Review Comment:
   @xiangfu0 I've opened this PR to address this: https://github.com/apache/pinot/pull/9353 
   can you take a look when you get a chance?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org