You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "mslapek (via GitHub)" <gi...@apache.org> on 2023/03/18 17:56:21 UTC

[GitHub] [arrow-datafusion] mslapek commented on a diff in pull request #5623: Add LogicalPlanSignature and use in the optimizer loop

mslapek commented on code in PR #5623:
URL: https://github.com/apache/arrow-datafusion/pull/5623#discussion_r1141080502


##########
datafusion/optimizer/src/optimizer.rs:
##########
@@ -419,6 +412,34 @@ impl Optimizer {
     }
 }
 
+/// Returns an error if plans have different schemas.

Review Comment:
   The Boy Scout Rule: "Leave the campground cleaner than you found it" 🤣



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org