You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Thejas Nair <th...@hortonworks.com> on 2014/07/16 00:48:16 UTC
Review Request 23527: HIVE-7416 - provide context information to
authorization checkPrivileges api call
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23527/
-----------------------------------------------------------
Review request for hive.
Bugs: HIVE-7416
https://issues.apache.org/jira/browse/HIVE-7416
Repository: hive-git
Description
-------
See jira
Diffs
-----
itests/hive-unit/src/test/java/org/apache/hive/jdbc/authorization/TestHS2AuthzContext.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/Driver.java ac76214
ql/src/java/org/apache/hadoop/hive/ql/exec/ExplainTask.java 92545d8
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizationValidator.java 7ffbc44
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizer.java dbef61a
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizerImpl.java 558d4ff
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthzContext.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizationValidator.java 8937cfa
ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 6686bc6
service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 6a7ee7a
Diff: https://reviews.apache.org/r/23527/diff/
Testing
-------
New tests included.
Thanks,
Thejas Nair
Re: Review Request 23527: HIVE-7416 - provide context information to
authorization checkPrivileges api call
Posted by Thejas Nair <th...@hortonworks.com>.
> On July 16, 2014, 11:26 p.m., Jason Dere wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizationValidator.java, line 67
> > <https://reviews.apache.org/r/23527/diff/1/?file=632950#file632950line67>
> >
> > Is this the only current usage of the context info? Should it be logged for failed auth checks?
This patch is only enabling additional audit information to be logged (with the API changes). Note that this log message is also logged at DEBUG level, while most installations are likely to use INFO or WARN level logging.
I didn't want to club the auditing enhancements into this patch. However, with this change any other implementations of this API can make use of it.
- Thejas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23527/#review47953
-----------------------------------------------------------
On July 15, 2014, 10:48 p.m., Thejas Nair wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23527/
> -----------------------------------------------------------
>
> (Updated July 15, 2014, 10:48 p.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-7416
> https://issues.apache.org/jira/browse/HIVE-7416
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> See jira
>
>
> Diffs
> -----
>
> itests/hive-unit/src/test/java/org/apache/hive/jdbc/authorization/TestHS2AuthzContext.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/Driver.java ac76214
> ql/src/java/org/apache/hadoop/hive/ql/exec/ExplainTask.java 92545d8
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizationValidator.java 7ffbc44
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizer.java dbef61a
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizerImpl.java 558d4ff
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthzContext.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizationValidator.java 8937cfa
> ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 6686bc6
> service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 6a7ee7a
>
> Diff: https://reviews.apache.org/r/23527/diff/
>
>
> Testing
> -------
>
> New tests included.
>
>
> Thanks,
>
> Thejas Nair
>
>
Re: Review Request 23527: HIVE-7416 - provide context information to
authorization checkPrivileges api call
Posted by Jason Dere <jd...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23527/#review47953
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizationValidator.java
<https://reviews.apache.org/r/23527/#comment84196>
Is this the only current usage of the context info? Should it be logged for failed auth checks?
- Jason Dere
On July 15, 2014, 10:48 p.m., Thejas Nair wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23527/
> -----------------------------------------------------------
>
> (Updated July 15, 2014, 10:48 p.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-7416
> https://issues.apache.org/jira/browse/HIVE-7416
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> See jira
>
>
> Diffs
> -----
>
> itests/hive-unit/src/test/java/org/apache/hive/jdbc/authorization/TestHS2AuthzContext.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/Driver.java ac76214
> ql/src/java/org/apache/hadoop/hive/ql/exec/ExplainTask.java 92545d8
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizationValidator.java 7ffbc44
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizer.java dbef61a
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizerImpl.java 558d4ff
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthzContext.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizationValidator.java 8937cfa
> ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 6686bc6
> service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 6a7ee7a
>
> Diff: https://reviews.apache.org/r/23527/diff/
>
>
> Testing
> -------
>
> New tests included.
>
>
> Thanks,
>
> Thejas Nair
>
>