You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/04/15 13:24:07 UTC
[GitHub] [maven] mthmulders opened a new pull request #337: [MNG-6891]
Improve user-friendliness of error message
mthmulders opened a new pull request #337: [MNG-6891] Improve user-friendliness of error message
URL: https://github.com/apache/maven/pull/337
Following this checklist to help us incorporate your contribution quickly and easily:
- [X] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. **See [MNG-6891](https://issues.apache.org/jira/browse/MNG-6891).**
- [X] Each commit in the pull request should have a meaningful subject line and body.
- [X] Format the pull request title like `[MNG-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MNG-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message.
- [X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [X] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully. There's one test case that fails (_testitMNG6386UnicodeChars_) but it also fails on master.
- [X] If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. **ICLA and CCLA have been signed**
To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box.
- [X] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven] mthmulders commented on issue #337: [MNG-6891] Improve
user-friendliness of error message
Posted by GitBox <gi...@apache.org>.
mthmulders commented on issue #337: [MNG-6891] Improve user-friendliness of error message
URL: https://github.com/apache/maven/pull/337#issuecomment-614041231
This merge request is only addressing the first part of MNG-6891. I'm planning to do the second part (support WARNING as well) in a follow-up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven] mthmulders commented on issue #337: [MNG-6891] Improve
user-friendliness --fail-on-severity
Posted by GitBox <gi...@apache.org>.
mthmulders commented on issue #337: [MNG-6891] Improve user-friendliness --fail-on-severity
URL: https://github.com/apache/maven/pull/337#issuecomment-614191357
On second thought, I'll add the remainder of [MNG-6891](https://issues.apache.org/jira/browse/MNG-6891) to this merge request, too. That is, the part that says "it'd be nice if WARNING was accepted next to WARN".
Since this feature hasn't been released yet, I took the liberty to change the message for severity levels that we don't accept for `--fos`. Instead of "Logging severity thresholds can only be set to WARN or ERROR" it'll now give the same message "INFO is not a valid log severity threshold. Valid severities are WARN/WARNING and ERROR.".
This shouldn't break anything, as the feature hasn't been released yet, but makes the code a little easier to read, and it saves us one try/catch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven] michael-o commented on issue #337: [MNG-6891] Improve
user-friendliness of error message
Posted by GitBox <gi...@apache.org>.
michael-o commented on issue #337: [MNG-6891] Improve user-friendliness of error message
URL: https://github.com/apache/maven/pull/337#issuecomment-614039825
Looks incomplete, what about? `ERROR(ERROR_INT, "ERROR"), WARN(WARN_INT, "WARN"), INFO(INFO_INT, "INFO"), DEBUG(DEBUG_INT, "DEBUG"), TRACE(TRACE_INT, "TRACE");`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services